GitLab

This tests both the cases when the DLV trust anchor is of an
unsupported or disabled algorithm, as well as if the DLV zone
contains a key with an unsupported or disabled algorithm.

Some values returned by dstkey_fromconfig() indicate that key loading
should be interrupted, others do not.  There are also certain subsequent
checks to be made after parsing a key from configuration and the results
of these checks also affect the key loading process.  All of this
complicates the key loading logic.

In order to make the relevant parts of the code easier to follow, reduce
the body of the inner for loop in load_view_keys() to a single call to a
new function, process_key().  Move dstkey_fromconfig() error handling to
process_key() as well and add comments to clearly describe the effects
of various key loading errors.

More specifically: ignore configured trusted and managed keys that
match a disabled algorithm.  The behavioral change is that
associated responses no longer SERVFAIL, but return insecure.

Move from conf.sh.in to conf.sh.common as they will also need to be
added to conf.sh.win32.  Add variables for testing disabled
algorithms.

Make ifconfig.sh resilient to the directory where it is run

See merge request !1715

Add automake-compatible test driver for system tests

See merge request !1714

Make stop.pl wait for lock file cleanup

Closes #944

See merge request !1704

bin/tests/system/stop.pl only waits for the PID file to be cleaned up
while named cleans up the lock file after the PID file.  Thus, the
aforementioned script may consider a named instance to be fully shut
down when in fact it is not.

Fix by also checking whether the lock file exists when determining a
given instance's shutdown status.  This change assumes that if a named
instance uses a lock file, it is called "named.lock".

Also rename clean_pid_file() to pid_file_exists(), so that it is called
more appropriately (it does not clean up the PID file itself, it only
returns the server's identifier if its PID file is not yet cleaned up).

MR !1141 broke the way stop.pl is invoked when start.pl fails:

  - start.pl changes the working directory to $testdir/$server before
    attempting to start $server,

  - commit 27ee629e causes the $testdir
    variable in stop.pl to be determined using the $SYSTEMTESTTOP
    environment variable, which is set to ".." by all tests.sh scripts,

  - commit e227815a makes start.pl pass
    $test (the test's name) rather than $testdir (the path to the test's
    directory) to stop.pl when a given server fails to start.

Thus, when a server is restarted from within a tests.sh script and such
a restart fails, stop.pl attempts to look for the server directory in a
nonexistent location ($testdir/$server/../$test, i.e. $testdir/$test,
instead of $testdir/../$test).  Fix the issue by changing the working
directory before stop.pl is invoked in the scenario described above.

update bind.keys comments

See merge request !1707

Resolve "Remove revoked root key from bind.keys."

Closes #945

See merge request !1705

Revert "Merge branch 'placeholder-5889' into 'master'"

See merge request !1703

This reverts merge request !1702

placeholder

See merge request !1702

deprecate "dnssec-enable"

Closes #866

See merge request !1666

Fix regression in dnstap_test with native pkcs11

Closes #940

See merge request !1688

Change to cmocka broken initialization of TZ environment. This time,
commit 1cf12540 is not soon enough. Has
to be moved more forward, before any other tests. It library is not full
reinitialized on each test.

rename-shadowed-variable

See merge request !1698

Improve printing of the cmdline to also correctly print the control characters…

See merge request !1280

Test named logs control characters, special characters and large cmd line respectively as octal escaped, special escaped and elipsis

- Print control characters in octal
- Shorten using an ellipsis when necessary

Resolve "Cppcheck format issues."

Closes #938

See merge request !1685

Resolve "Assert the hevent->rdataset is non-NULL."

Closes #890

See merge request !1543