GitLab

It checks both that a process is running and uses dig to make sure it is
answering queries.  It's definately simple and probably a stop-gap solution.

  statements.

- Post-load of named.conf check verifies a slave zone has non-empty list
  of masters defined.

- New per-zone boolean:

	enable-zone yes | no ;

- intended to let a zone be disabled without having to comment out the
  entire zone statement.

- New global and per-view option:

	max-cache-ttl number

- New global and per-view option:

	addition-data internal | minimal | maximal;

the wildcard address, as a temporary (?) fix for the server failing with
'socket is not bound' during startup

line 356: remark(1174): parameter "dev" was declared but never referenced

This is true when ISC_NET_BSD44MSGHDR is not defined.  UNUSED()s were added.

line 1580: remark(1552): variable "task" was set but never used
line 1670: remark(1552): variable "task" was set but never used

I removed the stack variable and its assignment in each case.

line 2915: remark(1552): variable "ret" was set but never used

It was apparent that the variable was meant to be the return value
of isc_socket_getsockname, so the return statement was changed to use it.

Also ...

Changed function declarations to ISC coding style.

Wrapped two lines that were wider than column 79.

Removed two UNUSED() macros for variables that were no longer unused.

the same thing

                        formatting socket addresses in log messages.

transfer can be dispatched immediately whenever quota becomes available

line 383: remark(1498): no prototype for the call to setup
line 405: remark(1498): no prototype for the call to cleanup
The missing prototypes were added.

(Condition signaled: time for bed.)

ISC_TF() added to the return value of an isc_boolean_t function.

line 684: remark(1692): prototyped function redeclared without prototype
line 700: remark(1692): prototyped function redeclared without prototype
Prototypes fixed.

line 331: remark(1552): variable "n" was set but never used.
Variable removed.

It was removed and the function call that set it (getword) was cast to void.
In the context in which it was being used, the return value was not needed.

line 84: remark(1692): prototyped function redeclared without prototype
line 137: remark(1692): prototyped function redeclared without prototype

The missing prototypes were added.

Now used in place of more complex expression.

Prototype added.

Removed variable.

          "unsigned char":  rounding, sign extension, or loss of accuracy may
          result

Fixed by ensuring suitable range before assignment.

Fixed.

          to "long":  rounding, sign extension, or loss of accuracy may result

Fixed by ensuring unsigned long ctx->timeout does not overflow the signed
long timeout.tv_sec.

Removed "version" from function.

          used

Removed rdataset from function.

"tkey.c", line 220: remark(1552): variable "tsigkey" was set but never used
"tkey.c", line 846: remark(1552): variable "tsigkey" was set but never used

by removing the unused variables.