GitLab

"nxt.c", line 42: remark(1552): variable "byte" was set but never used
"nxt.c", line 56: remark(1552): variable "byte" was set but never used

"name.c", line 201: remark(1552): variable "byte" was set but never used

"keytable.c", line 286: remark(1552): variable "knode" was set but never used

"journal.c", line 169: remark(1552): variable "zoneclass" was set but never
          used

by removing zoneclass declaration and zoneclass = dns_db_class(db) from
dns_db_createsoatuple.

"adb.c", line 2042: remark(1552): variable "result" was set but never used
        isc_result_t result;
                     ^

"adb.c", line 3082: warning(1185): enumerated type mixed with another type
                               NAME_GLUEOK(adbname), NAME_HINTOK(adbname),
                                                     ^

"adb.c", line 3187: warning(1185): enumerated type mixed with another type
                               now, NAME_GLUEOK(adbname), NAME_HINTOK(adbname),

Note that the first is in timer_cleanup, a function returning void in a context
that can't do anything with something other than void (as an isc_taskaction_t).
It calls isc_timer_reset, which could conceivably return ISC_R_NOMEMORY or
ISC_R_UNEXPECTED.  For now the call has been cast to void, but someone
who knows the code better should have a look and see whether something more
intelligent could be done with an error (and, if not, remove my XXX and
make sure the comment is clear as to why ignoring the return is the
best that can be done).

"confzone.c", line 445: remark(1552): variable "res" was set but never used

Made *_zone_init functions return void since they all always returned
ISC_R_SUCCESS.

"confndc.c", line 1149: remark(1552): variable "mem" was set but never used

"confctl.c", line 177: remark(1552): variable "rval" was set but never used

"hmac_link.c", line 92: remark(1692): prototyped function redeclared without
          prototype
  dst_s_hmacmd5_init() {

"dst_parse.c", line 201: remark(1552): variable "error" was set but never used

"bsafe_link.c", line 116: remark(1692): prototyped function redeclared without
          prototype
  dst_s_bsafersa_init() {

and several variations of:

"bsafe_link.c", line 155: remark(1552): variable "status" was set but never
          used
        int status = 0;

along with style lint (notably bitwise operands used as truth values:
mode & DST_SIGMODE_INIT   versus  (mode & DST_SIGMODE_INIT) != 0.

to better clarify what is going on with regard to the symbol.

the CPP symbol it uses from *_HAVENETINET6* to *_NEEDNETINET6* to better
clarify what's going on with regard to the symbol.

Moved processing of --with-kame to before the in6addr_any check, since
it needs to set LIBS for the check to work.  [related to RT #105, and
previous configure.in revision 1.108.]

in6_pkinfo check only needs AC_TRY_COMPILE, not AC_TRY_LINK.

said they add to a list; this is no longer true, they now set the whole list

ISC_R_NOTFOUND as that seriously confuses query_find().  Introduced new
result codes DNS_R_NOVALIDSIG and DNS_R_NOVALIDNXT to use instead.

library if it is available; therefore the --with-mit-pthreads
option is no longer needed.  The --with-ptl2 option is now documented
as being experimental and applying to NetBSD only.

the mention of --with-mit-pthreads as this option no longer exists, and of
--with-ptl2 as this option is for experimental use only

library if it is available; therefore the --with-mit-pthreads
option is no longer needed.  The --with-ptl2 option is now documented
as being experimental and applying to NetBSD only.

Fix bug in nslookup interactive mode.

also briefly point to the tests programs built with make all_tests in bin/tests.

roots; check that key name is appropriate even if it is a security
root; added/clarified log messages

command a bit more obvious.
Addition of TCP fallback on UDP failure.  Will add option to disable this.
Further work on nslookup.
(nslookup is not built by default now, and is far from fully functional.
Interactive mode currently segfaults.)

allow-query ACL, subsequent accesses to the same zone were denied because
dbversion->queryok was not being set.  This caused mandatory glue to be
omitted from referral responses, ultimately causing lookups to fail if all
authoritative servers for the parent zone were running bind9.

when i wanted to cast the int to unsigned then make a pointer.