GitLab

Add a helper shell function, rndc_dumpdb(), which provides a convenient
way to call "rndc dumpdb" for a given server with optional additional
arguments.  Since database dumping is an asynchronous process, the
function waits until the dump is complete before returning, which
prevents false positives in system tests caused by inspecting the dump
before its preparation is finished.  The function also renames the dump
file before returning so that it does not get overwritten by subsequent
calls; this retains forensic data in case of an unexpected test failure.

configure.ac: autodetect 'pause' instruction presence on sparc

See merge request !2243

Sergei Trofimovich authored Aug 08, 2019 and Ondřej Surý committed Aug 08, 2019

The change fixes the following build failure on sparc T3 and older CPUs:

```
sparc-unknown-linux-gnu-gcc ... -O2 -mcpu=niagara2 ... -c rwlock.c
{standard input}: Assembler messages:
{standard input}:398: Error: Architecture mismatch on "pause ".
{standard input}:398: (Requires v9e|v9v|v9m|m8; requested architecture is v9b.)
make[1]: *** [Makefile:280: rwlock.o] Error 1
```

`pause` insutruction exists only on `-mcpu=niagara4` (`T4`) and upper.

The change adds `pause` configure-time autodetection and uses it if available.
config.h.in got new `HAVE_SPARC_PAUSE` knob. Fallback is a fall-through no-op.

Build-tested on:

- sparc-unknown-linux-gnu-gcc (no `pause`, build succeeds)
- sparc-unknown-linux-gnu-gcc -mcpu=niagara4 (`pause`, build succeeds)

Reported-by: Rolf Eike Beer
Bug: https://bugs.gentoo.org/691708

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

minor bugfix in mdig: when using +multi, +norrcomments was ignored

See merge request !2208

Resolve "deadlock hangs named"

Closes #1148

See merge request !2236

so that cleanup can all be done in dns_client_destroy().

(cherry picked from commit e80c4c34)
(cherry picked from commit ebc48cda)

Mark Andrews authored Aug 06, 2019 and Ondřej Surý committed Aug 07, 2019

so that cleanup can all be done in dns_view_weakattach().

(cherry picked from commit be8af3af)
(cherry picked from commit e3946327)

There's a deadlock in BIND 9 code where (dns_view_t){ .lock } and
(dns_resolver_t){ .buckets[i].lock } gets locked in different order.  When
view->weakrefs gets converted to a reference counting we can reduce the locking
in dns_view_weakdetach only to cases where it's the last instance of the
dns_view_t object.

(cherry picked from commit a7c9a52c)
(cherry picked from commit 232140ed)

Update the flycheck configuration for gcc and cppcheck

See merge request !2234

Resolve "dig +nocomment still comments"

Closes #1170

See merge request !2207

Resolve "Use referral DS record when validating"

Closes #964

See merge request !1755

so that the validator can validate the records as part of validating
the current request.

Resolve "a race in ht.c can cause REQUIRE failures"

Closes #1175

See merge request !2225

Do not use target-specific variables in Makefiles and fix LD_WRAP for non-libtool builds

Closes #1174

See merge request !2224

Remove the autoconf checks for etags/ctags and `make tags` target

Closes #4

See merge request !2223

There's no strong reason to keep `make tags` in our build system.  The previous
functionality of `make tags` could be simply retained by aliasing variant of:

    etags $(git ls-files '*.c' '*.h')

which would be universal for all C-code projects.

Convert the configure.ac rules for zlib library to use pkg-config

Closes #4

See merge request !2222

Resolve "Bits 64..71 of the dns64 prefix are supposed to be zero"

Closes #1159

See merge request !2193

Cleanup the isc_thread API

See merge request !2159

Previously isc_thread_join() would return ISC_R_UNEXPECTED on a failure to
create new thread.  All such occurences were caught and wrapped into assert
function at higher level.  The function was simplified to assert directly in the
isc_thread_join() function and all caller level assertions were removed.

Previously isc_thread_create() would return ISC_R_UNEXPECTED on a failure to
create new thread.  All such occurences were caught and wrapped into assert
function at higher level.  The function was simplified to assert directly in the
isc_thread_create() function and all caller level assertions were removed.