1. 15 Jul, 2020 3 commits
  2. 14 Jul, 2020 12 commits
    • Matthijs Mekking's avatar
      Merge branch '2006-coverity-checked-return-keymgr' into 'main' · f8ef2c04
      Matthijs Mekking authored
      Fix Coverity keymgr reports
      Closes #2006
      See merge request !3808
    • Matthijs Mekking's avatar
      Check return value of dst_key_getbool() · e645d2ef
      Matthijs Mekking authored
      Fix Coverity CHECKED_RETURN reports for dst_key_getbool().  In most
      cases we do not really care about its return value, but it is prudent
      to check it.
      In one case, where a dst_key_getbool() error should be treated
      identically as success, cast the return value to void and add a relevant
    • Michał Kępień's avatar
      Merge branch 'michal/use-image-key-in-qemu-based-ci-job-templates' into 'main' · df72c522
      Michał Kępień authored
      Use "image" key in QEMU-based CI job templates
      See merge request !3855
    • Michał Kępień's avatar
      Use "image" key in QEMU-based CI job templates · 72201bad
      Michał Kępień authored
      Our GitLab Runner Custom executor scripts now use the "image" key
      instead of the job name for determining the QCOW2 image to use for a
      given CI job.  Update .gitlab-ci.yml to reflect that change.
    • Mark Andrews's avatar
      Merge branch 'u/fanf2/fix-signing' into 'main' · c53bfb30
      Mark Andrews authored
      Fix re-signing when `sig-validity-interval` has two arguments
      See merge request !3735
    • Mark Andrews's avatar
      Add release note for [GL !3735] · 3ff60b88
      Mark Andrews authored
    • Mark Andrews's avatar
      Add CHANGES note for [GL !3735] · f4fbca6e
      Mark Andrews authored
    • Mark Andrews's avatar
      Add regression test for [GL !3735] · 11ecf790
      Mark Andrews authored
      Check that resign interval is actually in days rather than hours
      by checking that RRSIGs are all within the allowed day range.
    • Tony Finch's avatar
      Fix re-signing when `sig-validity-interval` has two arguments · 030674b2
      Tony Finch authored
      Since October 2019 I have had complaints from `dnssec-cds` reporting
      that the signatures on some of my test zones had expired. These were
      zones signed by BIND 9.15 or 9.17, with a DNSKEY TTL of 24h and
      `sig-validity-interval 10 8`.
      This is the same setup we have used for our production zones since
      2015, which is intended to re-sign the zones every 2 days, keeping
      at least 8 days signature validity. The SOA expire interval is 7
      days, so even in the presence of zone transfer problems, no-one
      should ever see expired signatures. (These timers are a bit too
      tight to be completely correct, because I should have increased
      the expiry timers when I increased the DNSKEY TTLs from 1h to 24h.
      But that should only matter when zone transfers are broken, which
      was not the case for the error reports that led to this patch.)
      For example, this morning my test zone contained:
              dev.dns.cam.ac.uk. 86400 IN RRSIG DNSKEY 13 5 86400 (
                                      20200701221418 20200621213022 ...)
      But one of my resolvers had cached:
              dev.dns.cam.ac.uk. 21424 IN RRSIG DNSKEY 13 5 86400 (
                                      20200622063022 20200612061136 ...)
      This TTL was captured at 20200622105807 so the resolver cached the
      RRset 64976 seconds previously (18h02m56s), at 20200621165511
      only about 12h before expiry.
      The other symptom of this error was incorrect `resign` times in
      the output from `rndc zonestatus`.
      For example, I have configured a test zone
              zone fast.dotat.at {
                      file "../u/z/fast.dotat.at";
                      type primary;
                      auto-dnssec maintain;
                      sig-validity-interval 500 499;
      The zone is reset to a minimal zone containing only SOA and NS
      records, and when `named` starts it loads and signs the zone. After
      that, `rndc zonestatus` reports:
              next resign node: fast.dotat.at/NS
              next resign time: Fri, 28 May 2021 12:48:47 GMT
      The resign time should be within the next 24h, but instead it is
      near the signature expiry time, which the RRSIG(NS) says is
      20210618074847. (Note 499 hours is a bit more than 20 days.)
      May/June 2021 is less than 500 days from now because expiry time
      jitter is applied to the NS records.
      Using this test I bisected this bug to 09990672 which contained a
      mistake leading to the resigning interval always being calculated in
      hours, when days are expected.
      This bug only occurs for configurations that use the two-argument form
      of `sig-validity-interval`.
    • Mark Andrews's avatar
      Merge branch... · 2ac2d832
      Mark Andrews authored
      Merge branch '1994-netscope-c-23-50-error-unused-parameter-addr-when-have_if_nametoindex-undefined-on-illumos' into 'main'
      Resolve "netscope.c:23:50: error: unused parameter 'addr' when HAVE_IF_NAMETOINDEX undefined on illumos"
      Closes #1994
      See merge request !3829
    • Mark Andrews's avatar
      Mark 'addr' as unused if HAVE_IF_NAMETOINDEX is not defined · e7662c4c
      Mark Andrews authored
      Also 'zone' should be initialised to zero.
    • Mark Andrews's avatar
      Merge branch... · 1a1e52b7
      Mark Andrews authored
      Merge branch '1995-gssapictx-c-681-10-error-implicit-declaration-of-function-gsskrb5_register_acceptor_identity' into 'main'
      Resolve "gssapictx.c:681:10: error: implicit declaration of function 'gsskrb5_register_acceptor_identity' on illumos"
      Closes #1995
      See merge request !3830
  3. 13 Jul, 2020 25 commits