1. 03 Mar, 2020 1 commit
  2. 28 Feb, 2020 1 commit
    • Michał Kępień's avatar
      Add ZLIB_LIBS to ISCLIBS · fc967ba0
      Michał Kępień authored
      When --with-zlib is passed to ./configure (or when the latter
      autodetects zlib's presence), libisc uses certain zlib functions and
      thus libisc's users should be linked against zlib in that case.  Adjust
      Makefile variables appropriately to prevent shared build failures caused
      by underlinking.
      fc967ba0
  3. 27 Feb, 2020 4 commits
  4. 24 Feb, 2020 3 commits
  5. 21 Feb, 2020 2 commits
  6. 20 Feb, 2020 1 commit
  7. 14 Feb, 2020 1 commit
  8. 13 Feb, 2020 3 commits
    • Evan Hunt's avatar
      apply the modified style · e851ed0b
      Evan Hunt authored
      e851ed0b
    • Ondřej Surý's avatar
      Use clang-tidy to add curly braces around one-line statements · 056e133c
      Ondřej Surý authored
      The command used to reformat the files in this commit was:
      
      ./util/run-clang-tidy \
      	-clang-tidy-binary clang-tidy-11
      	-clang-apply-replacements-binary clang-apply-replacements-11 \
      	-checks=-*,readability-braces-around-statements \
      	-j 9 \
      	-fix \
      	-format \
      	-style=file \
      	-quiet
      clang-format -i --style=format $(git ls-files '*.c' '*.h')
      uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h')
      clang-format -i --style=format $(git ls-files '*.c' '*.h')
      056e133c
    • Ondřej Surý's avatar
      Use coccinelle to add braces to nested single line statement · 36c6105e
      Ondřej Surý authored
      Both clang-tidy and uncrustify chokes on statement like this:
      
      for (...)
      	if (...)
      		break;
      
      This commit uses a very simple semantic patch (below) to add braces around such
      statements.
      
      Semantic patch used:
      
      @@
      statement S;
      expression E;
      @@
      
      while (...)
      - if (E) S
      + { if (E) { S } }
      
      @@
      statement S;
      expression E;
      @@
      
      for (...;...;...)
      - if (E) S
      + { if (E) { S } }
      
      @@
      statement S;
      expression E;
      @@
      
      if (...)
      - if (E) S
      + { if (E) { S } }
      36c6105e
  9. 12 Feb, 2020 3 commits
  10. 10 Feb, 2020 1 commit
  11. 08 Feb, 2020 1 commit
    • Michał Kępień's avatar
      Fix the "pipelined" system test on OpenBSD · a5e90f2a
      Michał Kępień authored
      On OpenBSD, the bin/tests/system/pipelined/ans5/ans.py script does not
      shut down when it is sent the SIGTERM signal.  What seems to be
      happening is that starting the UDP listening thread somehow makes the
      accept() calls in the script's main thread uninterruptible and thus the
      SIGTERM signal sent to the main thread does not get processed until a
      TCP connection is established with the script's TCP socket.  Work around
      the issue by setting a timeout for operations performed on the script's
      TCP socket, so that each accept() call in the main thread's infinite
      loop returns after at most 1 second, allowing termination signals sent
      to the script to be processed.
      a5e90f2a
  12. 07 Feb, 2020 13 commits
  13. 06 Feb, 2020 3 commits
    • Michał Kępień's avatar
      Fix the "dnssec" system test on Windows · 2f694f0b
      Michał Kępień authored
      Make sure carriage return characters are stripped from awk input to
      enable the "dnssec" system test to pass on Windows.
      2f694f0b
    • Matthijs Mekking's avatar
      Update kasp test with CDNSKEY checks · e6c5ecd6
      Matthijs Mekking authored
      Add checks to the kasp system test to verify CDNSKEY publication.
      This test is not entirely complete, because when there is a CDNSKEY
      available but there should not be one for KEY N, it is hard to tell
      whether the existing CDNSKEY actually belongs to KEY N or another
      key.
      
      The check works if we expect a CDNSKEY although we cannot guarantee
      that the CDNSKEY is correct: The test verifies existence, not
      correctness of the record.
      e6c5ecd6
    • Matthijs Mekking's avatar
      Fix kasp bug new KSK on restart [#1593] · b378d037
      Matthijs Mekking authored
      When you do a restart or reconfig of named, or rndc loadkeys, this
      triggers the key manager to run.  The key manager will check if new
      keys need to be created. If there is an active key, and key rollover
      is scheduled far enough away, no new key needs to be created.
      
      However, there was a bug that when you just start to sign your zone,
      it takes a while before the KSK becomes an active key. An active KSK
      has its DS submitted or published, but before the key manager allows
      that, the DNSKEY needs to be omnipresent. If you restart named
      or rndc loadkeys in quick succession when you just started to sign
      your zone, new keys will be created because the KSK is not yet
      considered active.
      
      Fix is to check for introducing as well as active keys. These keys
      all have in common that their goal is to become omnipresent.
      b378d037
  14. 05 Feb, 2020 1 commit
    • Mark Andrews's avatar
      's' must be non NULL, remove test. · 714594d4
      Mark Andrews authored
      122 cleanup:
      
      	CID 1452696 (#1 of 1): Dereference before null check (REVERSE_INULL)
      	check_after_deref: Null-checking s suggests that it may be
      	null, but it has already been dereferenced on all paths
      	leading to the check.
      
      123        if (s != NULL)
      124                isc_mem_free(mctx, s);
      714594d4
  15. 04 Feb, 2020 2 commits
    • Matthijs Mekking's avatar
      Increase TTL in serve-stale test · 2c0c333d
      Matthijs Mekking authored
      Increase the short lived record TTL and negative SOA TTL to make
      this test less vulnerable to timing issues. The drawback is that we
      also have to sleep longer in this test.
      2c0c333d
    • Matthijs Mekking's avatar
      Add test for "Others" rrtype stat counter · 7135ef78
      Matthijs Mekking authored
      Add queries and checks for CAA RRtype in the serve-stale test.
      Ensure that the "Others" rrtype stat counter is incremented and
      decremented properly if the RRset becomes stale/ancient.
      
      The low max-stale-ttl config option needs to be increased in order
      to match the timing when things expire (aka become ancient).
      7135ef78