1. 09 Dec, 2019 27 commits
  2. 06 Dec, 2019 13 commits
    • Ondřej Surý's avatar
    • Mark Andrews's avatar
      Merge branch '1401-intermittent-failures-in-the-catz-system-test' into 'master' · fe31fedc
      Mark Andrews authored
      Debug "Intermittent failures in the catz system test"
      
      See merge request !2715
      fe31fedc
    • Mark Andrews's avatar
      Increase wait_for_message attempts to 20. · 4dd9ec89
      Mark Andrews authored
      4dd9ec89
    • Mark Andrews's avatar
      save wait_for_message contents · 1334daae
      Mark Andrews authored
      1334daae
    • Michał Kępień's avatar
      Merge branch '1452-system-test-framework-cleanup-tweaks' into 'master' · dd6f9391
      Michał Kępień authored
      System test framework: cleanup tweaks
      
      Closes #1452
      
      See merge request !2717
      dd6f9391
    • Michał Kępień's avatar
      Merge branch '1452-detect-missing-system-test-results' into 'master' · 34fb70b1
      Michał Kępień authored
      Detect missing system test results
      
      See merge request !2708
      34fb70b1
    • Michał Kępień's avatar
      Automatically run clean.sh from run.sh · d8905b7a
      Michał Kępień authored
      The first step in all existing setup.sh scripts is to call clean.sh.  To
      reduce code duplication and ensure all system tests added in the future
      behave consistently with existing ones, invoke clean.sh from run.sh
      before calling setup.sh.
      d8905b7a
    • Michał Kępień's avatar
      Detect missing system test results · 3c3085be
      Michał Kępień authored
      At the end of each system test suite run, the system test framework
      collects all existing test.output files from system test subdirectories
      and produces bin/tests/system/systests.output from those files.
      However, it does not check whether a test.output file was found for
      every executed test.  Thus, if the test.output file is accidentally
      deleted by the system test itself (e.g. due to an overly broad file
      removal wildcard present in clean.sh), its output will not be included
      in bin/tests/system/systests.output.  Since the result of each system
      test suite run is determined by bin/tests/system/testsummary.sh, which
      only operates on the contents of bin/tests/system/systests.output, this
      can lead to test failures being ignored.  Fix by ensuring the number of
      test results found in bin/tests/system/systests.output is equal to the
      number of tests run and triggering a system test suite failure in case
      of a discrepancy between these two values.
      3c3085be
    • Michał Kępień's avatar
      Remove bin/tests/system/clean.sh · bf3eeac0
      Michał Kępień authored
      Since the role of the bin/tests/system/clean.sh script has now been
      reduced to calling a given system test's clean.sh script, remove the
      former altogether and replace its only use with a direct invocation of
      the latter.
      bf3eeac0
    • Michał Kępień's avatar
      Remove the -r switch from system test scripts · b4d37878
      Michał Kępień authored
      Since files containing system test output are no longer stored in test
      subdirectories, bin/tests/system/clean.sh no longer needs to take care
      of removing the test.output file for a given test as testsummary.sh
      already takes care of that and even if a test suite terminates
      abnormally and another one is started, tee invoked without the -a
      command line switch overwrites the destination file if it exists, so
      leftover test.output.* files from previous test suite runs are not a
      concern.  Remove the -r command line switch and the code associated with
      it from the relevant scripts.
      b4d37878
    • Michał Kępień's avatar
      Store system test output in bin/tests/system/ · b0916bba
      Michał Kępień authored
      Some clean.sh scripts contain overly broad file deletion wildcards which
      cause the test.output file (used by the system test framework for
      collecting output) in a given system test's directory to be erroneously
      removed immediately after the test is started (due to setup.sh scripts
      calling clean.sh at the beginning).  This prevents the test's output
      from being placed in bin/tests/system/systests.output at the end of a
      test suite run and thus can lead to test failures being ignored.  Fix by
      storing each test's output in a test.output.<test-name> file in
      bin/tests/system/, which prevents clean.sh scripts from removing it (as
      they should only ever affect files contained in a given system test's
      directory).
      b0916bba
    • Matthijs Mekking's avatar
      Merge branch '1460-duration-ttlval-print-bug' into 'master' · 26ee43da
      Matthijs Mekking authored
      Resolve "checkconf test failure on Solaris"
      
      Closes #1460
      
      See merge request !2718
      26ee43da
    • Ondřej Surý's avatar
      Add semantic patch to find void f() { ... return ((void)g())); ... } · 9dfa3305
      Ondřej Surý authored
      When a function returns void, it can be used as an argument to return in
      function returning also void, e.g.:
      
      void in(void) {
        return;
      }
      
      void out(void) {
        return (in());
      }
      
      while this is legal, it should be rewritten as:
      
      void out(void) {
        in();
        return;
      }
      
      The semantic patch just find the occurrences, and they need to be fixed
      by hand.
      9dfa3305