1. 22 Feb, 2019 10 commits
    • Matthijs Mekking's avatar
      Remove rpz->db_registered · 67562802
      Matthijs Mekking authored
      As pointed out in !813 db_registered is sort of redundant.  It is
      set to `true` only in `dns_zone_rpz_enable_db()` right before the
      `dns_rpz_dbupdate_callback()` callback is registered.  It is only
      required in that callback and it is the only place that the callback
      is registered.  Therefore there is no path that that `REQUIRE` can
      fail.
      
      The `db_registered` variable is only set to `false` in
      `dns_rpz_new_zone`, so it is not like the variable is unset again
      later.
      
      The only other place where `db_registered` is checked is in
      `rpz_detach()`.  If `true`, it will call
      `dns_db_updatenotify_unregister()`.  However if that happens, the
      `db_registered` is not set back to `false` thus this implies that
      this may happen multiple times.  If called a second time, most
      likely the unregister function will return `ISC_R_NOTFOUND`, but
      the return value is not checked anyway.  So it can do without the
      `db_registered` check.
      67562802
    • Matthijs Mekking's avatar
      Add curly brackets on if statements · 2e5e4296
      Matthijs Mekking authored
      2e5e4296
    • Matthijs Mekking's avatar
      named crashes on shutdown after load rpz failed · a490c091
      Matthijs Mekking authored
      This may happen when loading an RPZ failed and the code path skips
      calling dns_db_endload().  The dns_rpz_zone_t object is still kept
      marked as having registered db.  So when this object is finally
      destroyed in rpz_detach(), this code will incorrectly call
      `dns_db_updatenotify_unregister()`:
      
         if (rpz->db_registered)
           dns_db_updatenotify_unregister(rpz->db,
                                          dns_rpz_dbupdate_callback, rpz);
      
      and trigger this assertion failure:
      
         REQUIRE(db != NULL);
      
      To fix this, only call `dns_db_updatenotify_unregister()` when
      `rpz->db` is not NULL.
      a490c091
    • Matthijs Mekking's avatar
      Make RPZ tests more readable · 8d392f90
      Matthijs Mekking authored
      8d392f90
    • Matthijs Mekking's avatar
      Add README to RPZ tests · 9ecdb292
      Matthijs Mekking authored
      9ecdb292
    • Mark Andrews's avatar
      Merge branch '892-fix-redirect-name' into 'master' · f9b50a40
      Mark Andrews authored
      use qname in redirect2
      
      Closes #892
      
      See merge request !1561
      f9b50a40
    • Mark Andrews's avatar
      add CHANGES · ad785e4f
      Mark Andrews authored
      ad785e4f
    • Mark Andrews's avatar
      use client->query.qname · 8758d36a
      Mark Andrews authored
      8758d36a
    • Evan Hunt's avatar
      Merge branch 'prep-915' into 'master' · 138268b7
      Evan Hunt authored
      documentation changes setting up 9.15 development branch
      
      See merge request !1560
      138268b7
    • Evan Hunt's avatar
      efb0d1e8
  2. 21 Feb, 2019 21 commits
  3. 20 Feb, 2019 3 commits
    • Evan Hunt's avatar
      Merge branch '428-remove-contrib-sdb' into 'master' · f4ade46f
      Evan Hunt authored
      remove contrib/sdb
      
      Closes #428
      
      See merge request !1501
      f4ade46f
    • Evan Hunt's avatar
      CHANGES · bcc2fd67
      Evan Hunt authored
      bcc2fd67
    • Evan Hunt's avatar
      remove contrib/sdb · c79e2f12
      Evan Hunt authored
      removed the SDB databases in contrib/sdb as they hadn't been
      maintained in some time, and were no longer able to link to named
      without modification.  also:
      
      - cleaned up contrib/README, which still referred to contrib
        subdirectores that were removed already, and linked to an obsolete URL.
      - removed references to sdb in doc/misc/roadmap and doc/misc/sdb.
      c79e2f12
  4. 19 Feb, 2019 6 commits