1. 25 May, 2020 15 commits
    • Evan Hunt's avatar
      68a1c9d6
    • Mark Andrews's avatar
      Merge branch... · 1093c366
      Mark Andrews authored
      Merge branch '1860-delv-crashes-processing-deprecated-trusted-keys-clause-in-anchor-file' into 'master'
      
      Resolve "delv crashes processing deprecated "trusted-keys" clause in anchor file"
      
      Closes #1860
      
      See merge request !3568
      1093c366
    • Mark Andrews's avatar
      Add CHANGES · 7854b652
      Mark Andrews authored
      7854b652
    • Mark Andrews's avatar
      d807febd
    • Mark Andrews's avatar
      26b3ca7a
    • Michał Kępień's avatar
      Merge branch '1868-edns-udp-buffer-size-tweaks' into 'master' · 8422b23c
      Michał Kępień authored
      EDNS UDP buffer size tweaks
      
      Closes #1868
      
      See merge request !3576
      8422b23c
    • Michał Kępień's avatar
      Add CHANGES entry · 862a51d8
      Michał Kępień authored
      5417.	[cleanup]	The code determining the advertised UDP buffer size in
      			outgoing EDNS queries has been refactored to improve its
      			clarity. [GL #1868]
      862a51d8
    • Michał Kępień's avatar
      Update "edns-udp-size" documentation in the ARM · 8ddd5c2f
      Michał Kępień authored
      Update the description of the process for determining the advertised UDP
      buffer size in outgoing queries so that it matches the code.
      8ddd5c2f
    • Michał Kępień's avatar
      Improve the "hint" variable comment · fb123df2
      Michał Kępień authored
      Replace an existing comment with a more verbose explanation of when the
      "hint" variable is set in resquery_send() and how its value affects the
      advertised UDP buffer size in outgoing queries.
      fb123df2
    • Michał Kępień's avatar
      Ensure server-specific "edns-udp-size" is obeyed · d27f96cc
      Michał Kępień authored
      If "edns-udp-size" is set in a "server" block matching the queried
      server, it is accounted for in the process of determining the advertised
      UDP buffer size, but its value may still be overridden before the query
      is sent.  This behavior contradicts the ARM which claims that when set,
      the server-specific "edns-udp-size" value is used for all EDNS queries
      sent to a given server.
      
      Furthermore, calling dns_peer_getudpsize() with the "udpsize" variable
      as an argument makes the code hard to follow as that call may either
      update the value of "udpsize" or leave it untouched.
      
      Ensure the code matches the documentation by moving the
      dns_peer_getudpsize() call below all other blocks of code potentially
      affecting the advertised UDP buffer size, which is where it was located
      when server-specific "edns-udp-size" support was first implemented [1].
      Improve code readability by calling dns_peer_getudpsize() with a helper
      variable instead of "udpsize".
      
      [1] see commit 1c153afc
      d27f96cc
    • Michał Kępień's avatar
      Restore semantic meaning of DNS_FETCHOPT_EDNS512 · d7583e79
      Michał Kępień authored
      When the DNS_FETCHOPT_EDNS512 flag was first introduced [1], it enforced
      advertising a 512-byte UDP buffer size in an outgoing query.  Ever since
      EDNS processing code got updated [2], that flag has still been set upon
      detection of certain query timeout patterns, but it has no longer been
      affecting the calculations of the advertised UDP buffer size in outgoing
      queries.  Restore original semantic meaning of DNS_FETCHOPT_EDNS512 by
      ensuring the advertised UDP buffer size is set to 512 bytes when that
      flag is set.  Update existing comments and add new ones to improve code
      readability.
      
      [1] see commit 08c90261
      [2] see commit 8e15d5eb
      d7583e79
    • Michał Kępień's avatar
      Remove fctx->reason and a misleading log message · 949d9a3e
      Michał Kępień authored
      The following message:
      
          success resolving '<name>' (in '<domain>'?) after reducing the advertised EDNS UDP packet size to 512 octets
      
      can currently be logged even if the EDNS UDP buffer size advertised in
      queries sent to a given server had already been set to 512 octets before
      the fetch context was created (e.g. due to the server responding
      intermittently).  In other words, this log message may be misleading as
      lowering the advertised EDNS UDP buffer size may not be the actual cause
      of <name> being successfully resolved.  Remove the log message in
      question to prevent confusion.
      
      As this log message is the only existing user of the "reason" field in
      struct fetchctx, remove that field as well, along with all the code
      related to it.
      949d9a3e
    • Mark Andrews's avatar
      Merge branch '1861-named_checknames_get-missing-dbc' into 'master' · bb1ec1f6
      Mark Andrews authored
      Resolve "named_checknames_get missing DBC"
      
      Closes #1861
      
      See merge request !3567
      bb1ec1f6
    • Mark Andrews's avatar
      Add DBC checks to named_checknames_get · 20c07da4
      Mark Andrews authored
      20c07da4
    • Mark Andrews's avatar
      Set obj to NULL so INSIST makes sense · ac9e2667
      Mark Andrews authored
      ac9e2667
  2. 21 May, 2020 11 commits
  3. 20 May, 2020 2 commits
  4. 19 May, 2020 12 commits