1. 14 May, 2000 17 commits
  2. 13 May, 2000 23 commits
    • David Lawrence's avatar
      Fixed IRIX warnings: · 71f88e82
      David Lawrence authored
      "./rdata/any_255/tsig_250.c", line 74: remark(1506): implicit conversion from
                "unsigned long" to "int":  rounding, sign extension, or loss of
                accuracy may result
      "./rdata/any_255/tsig_250.c", line 95: remark(1506): implicit conversion from
                "unsigned long" to "int":  rounding, sign extension, or loss of
                accuracy may result
      
      The values in question were already being checked to be within the range of
      a short, so where the warnings were occuring they were just cast to int.
      71f88e82
    • David Lawrence's avatar
      Fixed IRIX warnings: · 652c8043
      David Lawrence authored
      "./rdata/generic/tkey_249.c", line 89: remark(1506): implicit conversion from
                "unsigned long" to "int":  rounding, sign extension, or loss of
                accuracy may result
      "./rdata/generic/tkey_249.c", line 98: remark(1506): implicit conversion from
                "unsigned long" to "int":  rounding, sign extension, or loss of
                accuracy may result
      
      The values in question were already being checked to be within the range of
      a short, so where the warnings were occuring they were just cast to int.
      652c8043
    • David Lawrence's avatar
      Fixed IRIX warning: · e14969d2
      David Lawrence authored
      "./rdata/generic/unspec_103.c", line 138: warning(1184): possible use of "="
                where "==" was intended
      by changing to ==, which is clearly what was intended.
      e14969d2
    • David Lawrence's avatar
      Fixed IRIX warning: · 17547ed8
      David Lawrence authored
      "./rdata/generic/opt_41.c", line 73: remark(1552): variable "option" was set
                but never used
      by removing option, because there was nothing to do with its value.
      17547ed8
    • David Lawrence's avatar
      Fixed IRIX warning: · 7c7d67b5
      David Lawrence authored
      "./rdata/in_1/a6_38.c", line 259: remark(1552): variable "octets" was set but
                never used
      by using UNUSED() on this stack variable.  I didn't take it out altogether
      because this function is not yet finished, but someone was starting to
      do some work on it and I didn't want to undo that.
      7c7d67b5
    • David Lawrence's avatar
      Fixed IRIX warning: · 873484b4
      David Lawrence authored
      "./rdata/generic/nxt_30.c", line 66: warning(1042): operand types are
                incompatible ("char *" and "void *")
      by casting to char *, as already being done with several other uses of
      token.value.as_pointer.
      873484b4
    • David Lawrence's avatar
      needs string.h for memset() prototype. · 3d181bc9
      David Lawrence authored
      3d181bc9
    • David Lawrence's avatar
      Fixed several instances of this IRIX warning: · 22520194
      David Lawrence authored
      "./rdata/generic/loc_29.c", line ??: remark(1506): implicit conversion from
                "unsigned long" to "int":  rounding, sign extension, or loss of
                accuracy may result
      by making sure that the range was suitable for an int and casting to
      int in each case.  (This appeared to be more desirable than changing
      all of the variables in question to longs.)
      22520194
    • David Lawrence's avatar
      Fixed IRIX warning: · f1f3bb3a
      David Lawrence authored
      "./rdata/generic/mx_15.c", line 202: warning(1184): possible use of "=" where
                "==" was intended
      by changing to == since it was clear that test was desired, not assignment.
      f1f3bb3a
    • David Lawrence's avatar
      Fixed IRIX warnings: · 44d74084
      David Lawrence authored
      "./rdata/in_1/a_1.c", line 178: warning(1184): possible use of "=" where "=="
                was intended
      "./rdata/in_1/a_1.c", line 179: warning(1184): possible use of "=" where "=="
                was intended
      
      By chaning them to ==, because (a) we don't allow side-effects in REQUIRE()
      and (b) it is clear from the rest of the code that it really was a test that
      was desired and not an assignment.
      44d74084
    • David Lawrence's avatar
      Fixed IRIX warnings: · 29aa703d
      David Lawrence authored
      "rbtdb.c", line 1579: remark(1552): parameter "now" was set but never used
      "rbtdb.c", line 2888: remark(1552): parameter "version" was set but never used
      
      by using UNUSED() rather than setting variables to unused values.
      29aa703d
    • David Lawrence's avatar
      *FIXED* IRIX warnings: · 421cb938
      David Lawrence authored
      "nxt.c", line 42: remark(1552): variable "byte" was set but never used
      "nxt.c", line 56: remark(1552): variable "byte" was set but never used
      421cb938
    • David Lawrence's avatar
      Silence IRIX warning: · d3d03f73
      David Lawrence authored
      "name.c", line 201: remark(1552): variable "byte" was set but never used
      d3d03f73
    • David Lawrence's avatar
      Silence IRIX warning: · 0911d40d
      David Lawrence authored
      "keytable.c", line 286: remark(1552): variable "knode" was set but never used
      0911d40d
    • David Lawrence's avatar
      Silence IRIX warning: · 56a2bee1
      David Lawrence authored
      "journal.c", line 169: remark(1552): variable "zoneclass" was set but never
                used
      
      by removing zoneclass declaration and zoneclass = dns_db_class(db) from
      dns_db_createsoatuple.
      56a2bee1
    • David Lawrence's avatar
      Silence IRIX warnings: · c6715d23
      David Lawrence authored
      "adb.c", line 2042: remark(1552): variable "result" was set but never used
              isc_result_t result;
                           ^
      
      "adb.c", line 3082: warning(1185): enumerated type mixed with another type
                                     NAME_GLUEOK(adbname), NAME_HINTOK(adbname),
                                                           ^
      
      "adb.c", line 3187: warning(1185): enumerated type mixed with another type
                                     now, NAME_GLUEOK(adbname), NAME_HINTOK(adbname),
      
      Note that the first is in timer_cleanup, a function returning void in a context
      that can't do anything with something other than void (as an isc_taskaction_t).
      It calls isc_timer_reset, which could conceivably return ISC_R_NOMEMORY or
      ISC_R_UNEXPECTED.  For now the call has been cast to void, but someone
      who knows the code better should have a look and see whether something more
      intelligent could be done with an error (and, if not, remove my XXX and
      make sure the comment is clear as to why ignoring the return is the
      best that can be done).
      c6715d23
    • David Lawrence's avatar
      Silence IRIX warning: · 605c0315
      David Lawrence authored
      "confzone.c", line 445: remark(1552): variable "res" was set but never used
      
      Made *_zone_init functions return void since they all always returned
      ISC_R_SUCCESS.
      605c0315
    • David Lawrence's avatar
      Silence IRIX warning: · 34e52a88
      David Lawrence authored
      "confndc.c", line 1149: remark(1552): variable "mem" was set but never used
      34e52a88
    • David Lawrence's avatar
      Silence IRIX warning: · aef7d54a
      David Lawrence authored
      "confctl.c", line 177: remark(1552): variable "rval" was set but never used
      aef7d54a
    • David Lawrence's avatar
      Silence IRIX warning: · 48a7c6ab
      David Lawrence authored
      "hmac_link.c", line 92: remark(1692): prototyped function redeclared without
                prototype
        dst_s_hmacmd5_init() {
      48a7c6ab
    • David Lawrence's avatar
      Silence IRIX warning: · 8e63fe63
      David Lawrence authored
      "dst_parse.c", line 201: remark(1552): variable "error" was set but never used
      8e63fe63
    • David Lawrence's avatar
      Shut up IRIX warnings, including: · 29ee206b
      David Lawrence authored
      "bsafe_link.c", line 116: remark(1692): prototyped function redeclared without
                prototype
        dst_s_bsafersa_init() {
      
      and several variations of:
      
      "bsafe_link.c", line 155: remark(1552): variable "status" was set but never
                used
              int status = 0;
      
      along with style lint (notably bitwise operands used as truth values:
      mode & DST_SIGMODE_INIT   versus  (mode & DST_SIGMODE_INIT) != 0.
      29ee206b
    • David Lawrence's avatar