1. 01 Jun, 2000 2 commits
    • David Lawrence's avatar
      Megacommit of many files. · 6d12fdf9
      David Lawrence authored
      Mostly, several functions that take pointers as arguments, almost
      always char * pointers, had those pointers qualified with "const".
      Those that returned pointers to previously const-qualified arguments
      had their return values qualified as const.  Some structure members
      were qualified as const to retain that attribute from the variables
      from which they were assigned.
      
      The macro DE_CONST is used to deal with a handful of very special
      places where something is qualified as const but really needs to have
      its const qualifier removed.
      
      rdata.c now defines macros for the prototypes of the basic rdata functions,
      and all of the lib/dns/rdata/**/*.c files now use them.
      
      Some minor integer-compatibility issues.  (IE, ~0x03 is a signed int,
      so assigning it to an unsigned int should use a cast.  The type of an
      enum member is int, so there are some conversion issues there, too.)
      
      A pointers-to-function should not be cast to a pointer-to-object.
      
      Variables should not be named for C reserved identifiers.
      
      One or two set-but-not-used variables removed.
      
      Minor other ISC style cleanups.
      6d12fdf9
    • Andreas Gustafsson's avatar
      fd6de7af
  2. 25 May, 2000 1 commit
  3. 24 May, 2000 1 commit
  4. 22 May, 2000 2 commits
  5. 19 May, 2000 9 commits
  6. 18 May, 2000 2 commits
  7. 17 May, 2000 1 commit
  8. 15 May, 2000 1 commit
  9. 13 May, 2000 9 commits
    • David Lawrence's avatar
      Fixed IRIX warnings: · 71f88e82
      David Lawrence authored
      "./rdata/any_255/tsig_250.c", line 74: remark(1506): implicit conversion from
                "unsigned long" to "int":  rounding, sign extension, or loss of
                accuracy may result
      "./rdata/any_255/tsig_250.c", line 95: remark(1506): implicit conversion from
                "unsigned long" to "int":  rounding, sign extension, or loss of
                accuracy may result
      
      The values in question were already being checked to be within the range of
      a short, so where the warnings were occuring they were just cast to int.
      71f88e82
    • David Lawrence's avatar
      Fixed IRIX warnings: · 652c8043
      David Lawrence authored
      "./rdata/generic/tkey_249.c", line 89: remark(1506): implicit conversion from
                "unsigned long" to "int":  rounding, sign extension, or loss of
                accuracy may result
      "./rdata/generic/tkey_249.c", line 98: remark(1506): implicit conversion from
                "unsigned long" to "int":  rounding, sign extension, or loss of
                accuracy may result
      
      The values in question were already being checked to be within the range of
      a short, so where the warnings were occuring they were just cast to int.
      652c8043
    • David Lawrence's avatar
      Fixed IRIX warning: · e14969d2
      David Lawrence authored
      "./rdata/generic/unspec_103.c", line 138: warning(1184): possible use of "="
                where "==" was intended
      by changing to ==, which is clearly what was intended.
      e14969d2
    • David Lawrence's avatar
      Fixed IRIX warning: · 17547ed8
      David Lawrence authored
      "./rdata/generic/opt_41.c", line 73: remark(1552): variable "option" was set
                but never used
      by removing option, because there was nothing to do with its value.
      17547ed8
    • David Lawrence's avatar
      Fixed IRIX warning: · 7c7d67b5
      David Lawrence authored
      "./rdata/in_1/a6_38.c", line 259: remark(1552): variable "octets" was set but
                never used
      by using UNUSED() on this stack variable.  I didn't take it out altogether
      because this function is not yet finished, but someone was starting to
      do some work on it and I didn't want to undo that.
      7c7d67b5
    • David Lawrence's avatar
      Fixed IRIX warning: · 873484b4
      David Lawrence authored
      "./rdata/generic/nxt_30.c", line 66: warning(1042): operand types are
                incompatible ("char *" and "void *")
      by casting to char *, as already being done with several other uses of
      token.value.as_pointer.
      873484b4
    • David Lawrence's avatar
      Fixed several instances of this IRIX warning: · 22520194
      David Lawrence authored
      "./rdata/generic/loc_29.c", line ??: remark(1506): implicit conversion from
                "unsigned long" to "int":  rounding, sign extension, or loss of
                accuracy may result
      by making sure that the range was suitable for an int and casting to
      int in each case.  (This appeared to be more desirable than changing
      all of the variables in question to longs.)
      22520194
    • David Lawrence's avatar
      Fixed IRIX warning: · f1f3bb3a
      David Lawrence authored
      "./rdata/generic/mx_15.c", line 202: warning(1184): possible use of "=" where
                "==" was intended
      by changing to == since it was clear that test was desired, not assignment.
      f1f3bb3a
    • David Lawrence's avatar
      Fixed IRIX warnings: · 44d74084
      David Lawrence authored
      "./rdata/in_1/a_1.c", line 178: warning(1184): possible use of "=" where "=="
                was intended
      "./rdata/in_1/a_1.c", line 179: warning(1184): possible use of "=" where "=="
                was intended
      
      By chaning them to ==, because (a) we don't allow side-effects in REQUIRE()
      and (b) it is clear from the rest of the code that it really was a test that
      was desired and not an assignment.
      44d74084
  10. 12 May, 2000 1 commit
  11. 11 May, 2000 1 commit
  12. 08 May, 2000 2 commits
  13. 05 May, 2000 4 commits
  14. 04 May, 2000 2 commits
  15. 03 May, 2000 1 commit
  16. 01 May, 2000 1 commit