Fix regex used for mangling druz/DNSKEY (in the "dlv" system test)

See merge request !1641

During "dlv" system test setup, the "sed" regex used for mangling the
DNSKEY RRset for the "druz" zone does not include the plus sign ("+"),
which may:

  - cause the replacement to happen near the end of DNSKEY RDATA, which
    can cause the latter to become an invalid Base64 string,

  - prevent the replacement from being performed altogether.

Both cases prevent the "dlv" system test from behaving as intended and
may trigger false positives.  Add the missing character to the
aforementioned regex to ensure the replacement is always performed on
bytes 10-25 of DNSKEY RDATA.

Make delv use OS-supplied ephemeral port range

Closes #925

See merge request !1611

5180.	[bug]		delv now honors the operating system's preferred
			ephemeral port range. [GL #925]

Make delv honor the operating system's preferred ephemeral port range
instead of always using the default 1024-65535 range for outgoing
messages.

cleanup: use dns_secalg_t and dns_dsdigest_t where appropriate

See merge request !1498

Tony Finch authored Feb 08, 2019 and Mark Andrews committed Mar 08, 2019

Use them in structs for various rdata types where they are missing.
This doesn't change the structs since we are replacing explicit
uint8_t field types with aliases for uint8_t.

Use dns_dsdigest_t in library function arguments.

Improve dnssec-cds with these more specific types.

#include <limits.h> for PATH_MAX, define if not found

See merge request !1635

silence a warning about potential snprintf overrun

See merge request !1558

Resolve "Hang when unexpected errno encountered during log rename"

Closes #902

See merge request !1567

fix the use of dns_wildcardname as an optimisation in DLZ

Closes #884

See merge request !1532

the wrong variable was used to count the test cases in one place.

See merge request !1625

Resolve "teach clang that _fail() does not return."

Closes #927

See merge request !1621

Merge branch '865-option-to-disable-information-leak-on-rpz-rewrites-isc-support-14178' into 'master'

Resolve "Option to disable information leak on RPZ rewrites [ISC-support #14178]"

Closes #865

See merge request !1514

Resolve "statschannel system tests fails json only (no libxml)"

Closes #926

See merge request !1614

Resolve "Zone data cannot be loaded with dnssec-coverage"

Closes #882

See merge request !1522

cleanup dnssec-keygen manual page

See merge request !1557

Tony Finch authored Feb 21, 2019 and Evan Hunt committed Mar 06, 2019

Alphabetize options and synopsis; remove spurious -z from synopsis;
remove remnants of deprecated -k option; remove mention of long-gone
TSIG support; refer to -T KEY in options that are only relevant to
pre-RFC3755 DNSSEC; remove unnecessary -n ZONE from the example, and
add a -f KSK example.

Fix a race in socket code

Closes #874

See merge request !1590

Witold Kręcicki authored Feb 15, 2019 and Evan Hunt committed Mar 06, 2019

from event loop on an socket and, in the meantime, someone has closed this
socket.

Log plugin unloading at debug level

See merge request !1608

Michał Kępień authored Mar 06, 2019 and Evan Hunt committed Mar 06, 2019

During server reconfiguration, plugin instances set up for the old views
are unloaded very close to the end of the whole process, after new
plugin instances are set up.  As the log message announcing plugin
unloading is emitted at the default "info" level, the user might be
misled into thinking that it is the new plugin instances that are being
unloaded for some reason, particularly because all other messages logged
at the "info" level around the same time inform about setting things up
rather than tearing them down.  Since no distinction is currently made
between destroying a view due to reconfiguration and due to a shutdown
in progress, there is no easy way to vary the contents of the log
message depending on circumstances.  Since this message is not a
particularly critical one, demote it to debug level to prevent
confusion.

Make nsupdate use OS-supplied ephemeral port range

Closes #905

See merge request !1569