1. 18 Jun, 2020 3 commits
  2. 17 Jun, 2020 1 commit
  3. 11 Jun, 2020 1 commit
  4. 10 Jun, 2020 1 commit
    • Witold Krecicki's avatar
      Fix a race in TCP accepting. · 85d8e4bf
      Witold Krecicki authored
      There's a possibility of a race in TCP accepting code:
      T1 accepts a connection C1
      T2 accepts a connection C2
      T1 tries to accept a connection C3, but we hit a quota,
         isc_quota_cb_init() sets quota_accept_cb for the socket,
         we return from accept_connection
      T2 drops C2, but we race in quota_release with accepting C3 so
         we don't see quota->waiting is > 0, we don't launch the callback
      T1 accepts a connection C4, we are able to get the quota we clear
         the quota_accept_cb from sock->quotacb
      T1 drops C1, tries to call the callback which is zeroed, sigsegv.
      85d8e4bf
  5. 05 Jun, 2020 3 commits
  6. 04 Jun, 2020 5 commits
  7. 03 Jun, 2020 3 commits
  8. 02 Jun, 2020 3 commits
    • Matthijs Mekking's avatar
      Retire predecessor when creating successor · e71d6029
      Matthijs Mekking authored
      When creating the successor, the current active key (predecessor)
      should change its goal state to HIDDEN.
      
      Also add two useful debug logs in the keymgr_key_rollover function.
      e71d6029
    • Matthijs Mekking's avatar
      Fix bug in keymgr_key_has_successor · 0d578097
      Matthijs Mekking authored
      The logic in `keymgr_key_has_successor(key, keyring)` is flawed, it
      returns true if there is any key in the keyring that has a successor,
      while what we really want here is to make sure that the given key
      has a successor in the given keyring.
      
      Rather than relying on `keymgr_key_exists_with_state`, walk the
      list of keys in the keyring and check if the key is a successor of
      the given predecessor key.
      0d578097
    • Matthijs Mekking's avatar
      Add change entry · bcf3c9fe
      Matthijs Mekking authored
      bcf3c9fe
  9. 29 May, 2020 2 commits
  10. 26 May, 2020 1 commit
  11. 25 May, 2020 2 commits
  12. 20 May, 2020 1 commit
    • Witold Krecicki's avatar
      Fix possible deadlock in unix/socket.c · 0eec2594
      Witold Krecicki authored
      In process_fd we lock sock->lock and then internal_accept locks mgr->lock,
      in isc_sockmgr_render* functions we lock mgr->lock and then lock sock->lock,
      that can cause a deadlock when accessing stats. Unlock sock->lock early in
      all the internal_{send,recv,connect,accept} functions instead of late
      in process_fd.
      0eec2594
  13. 19 May, 2020 3 commits
  14. 18 May, 2020 2 commits
  15. 14 May, 2020 1 commit
  16. 13 May, 2020 2 commits
  17. 12 May, 2020 4 commits
  18. 07 May, 2020 1 commit
  19. 05 May, 2020 1 commit