GitLab

[v9_11] Use "image" key in QEMU-based CI job templates

See merge request !3857

Our GitLab Runner Custom executor scripts now use the "image" key
instead of the job name for determining the QCOW2 image to use for a
given CI job.  Update .gitlab-ci.yml to reflect that change.

(cherry picked from commit 72201bad)

Merge branch '1994-netscope-c-23-50-error-unused-parameter-addr-when-have_if_nametoindex-undefined-on-illumos-v9_11' into 'v9_11'

Mark 'addr' as unused if HAVE_IF_NAMETOINDEX is not defined

See merge request !3851

Also 'zone' should be initialised to zero.

(cherry picked from commit e7662c4c)

ensure new_zone_lock is released after count_newzones()

See merge request !3846

it was possible for the count_newzones() function to try to
unlock view->new_zone_lock on return before locking it, which
caused a crash on shutdown.

(cherry picked from commit ed37c63e)

Fallback to built in trust-anchors, managed-keys, or trusted-keys

See merge request !3844

if the bind.keys file cannot be parsed.

(cherry picked from commit d02a14c7)

Merge branch '2012-add-assertion-check-to-silence-dereference-before-null-check-in-tsig_test-c-v9_11-v9_11' into 'v9_11'

Assert tsigout is non-NULL

See merge request !3840

(cherry picked from commit 827746e8)

check returns from inet_pton()

See merge request !3838

(cherry picked from commit 9499adeb)

Resolve "Potential NULL pointer dereference (9.11) in dnstap.c"

See merge request !3813

[v9_11] Fix locking for LMDB 0.9.26

See merge request !3832

(cherry picked from commit 7fffa5ab)

When "rndc reconfig" is run, named first configures a fresh set of views
and then tears down the old views.  Consider what happens for a single
view with LMDB enabled; "envA" is the pointer to the LMDB environment
used by the original/old version of the view, "envB" is the pointer to
the same LMDB environment used by the new version of that view:

 1. mdb_env_open(envA) is called when the view is first created.
 2. "rndc reconfig" is called.
 3. mdb_env_open(envB) is called for the new instance of the view.
 4. mdb_env_close(envA) is called for the old instance of the view.

This seems to have worked so far.  However, an upstream change [1] in
LMDB which will be part of its 0.9.26 release prevents the above
sequence of calls from working as intended because the locktable mutexes
will now get destroyed by the mdb_env_close() call in step 4 above,
causing any subsequent mdb_txn_begin() calls to fail (because all of the
above steps are happening within a single named process).

Preventing the above scenario from happening would require either
redesigning the way we use LMDB in BIND, which is not something we can
easily backport, or redesigning the way BIND carries out its
reconfiguration process, which would be an even more severe change.

To work around the problem, set MDB_NOLOCK when calling mdb_env_open()
to stop LMDB from controlling concurrent access to the database and do
the necessary locking in named instead.  Reuse the view->new_zone_lock
mutex for this purpose to prevent the need for modifying struct dns_view
(which would necessitate library API version bumps).  Drop use of
MDB_NOTLS as it is made redundant by MDB_NOLOCK: MDB_NOTLS only affects
where LMDB reader locktable slots are stored while MDB_NOLOCK prevents
the reader locktable from being used altogether.

[1] https://git.openldap.org/openldap/openldap/-/commit/2fd44e325195ae81664eb5dc36e7d265927c5ebc

(cherry picked from commit 53120279)

Adjust range limit of unknown meta types

See merge request !3824

(cherry picked from commit 092a159d)

Resolve "Update ISC logo in documentation"

See merge request !3812

[v9_11] Add CHANGES entry for #1627

See merge request !3798

(cherry picked from commit dee2b3c7)

Resolve "Again: BIND | rbtdb.c:2162: INSIST with bind with 9.11.20  (see #1718)"

See merge request !3783

(cherry picked from commit 4c12709d)

(cherry picked from commit c8f2d55a)

Silence PyYAML warning

See merge request !3770

Make yaml.load_all() use yaml.SafeLoader to address a warning currently
emitted when bin/tests/system/dnstap/ydump.py is run:

    ydump.py:28: YAMLLoadWarning: calling yaml.load_all() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
      for l in yaml.load_all(f.stdout):

(cherry picked from commit 62f631f7)

U/fanf2/dnstap roll v9 11

See merge request !3755

(cherry picked from commit a289a57c)

[v9_11] Add Ubuntu 20.04, Fedora 32, Alpine 3.12, OpenBSD 6.7, and FreeBSD 11.4

See merge request !3763