1. 25 Aug, 2018 1 commit
  2. 24 Aug, 2018 13 commits
  3. 23 Aug, 2018 14 commits
  4. 22 Aug, 2018 11 commits
    • Evan Hunt's avatar
      Merge branch '484-fix-non-libtool-build' into 'master' · d30b90db
      Evan Hunt authored
      Resolve "Build Fails with --enable-developer when building without libtool"
      
      Closes #484
      
      See merge request !676
      d30b90db
    • Evan Hunt's avatar
      e67f81bb
    • Michał Kępień's avatar
      Merge branch '435-fix-reloading-inline-signed-zones' into 'master' · cb28c27b
      Michał Kępień authored
      Fix reloading inline-signed zones
      
      Closes #435
      
      See merge request !664
      cb28c27b
    • Michał Kępień's avatar
      Add CHANGES entry · f9931f1d
      Michał Kępień authored
      5015.	[bug]		Reloading all zones caused zone maintenance to cease
      			for inline-signed zones. [GL #435]
      f9931f1d
    • Michał Kępień's avatar
      Fix reloading inline-signed zones · 54315839
      Michał Kępień authored
      While "rndc reload" causes dns_zone_asyncload() to be called for the
      signed version of an inline-signed zone, the subsequent zone_load() call
      causes the raw version to be reloaded from storage.  This means that
      DNS_ZONEFLG_LOADPENDING gets set for the signed version of the zone by
      dns_zone_asyncload() before the reload is attempted, but zone_postload()
      is only called for the raw version and thus DNS_ZONEFLG_LOADPENDING is
      cleared for the raw version, but not for the signed version.  This in
      turn prevents zone maintenance from happening for the signed version of
      the zone.
      
      Until commit 29b7efdd, this problem
      remained dormant because DNS_ZONEFLG_LOADPENDING was previously
      immediately, unconditionally cleared after zone loading was started
      (whereas it should only be cleared when zone loading is finished or an
      error occurs).  This behavior caused other issues [1] and thus had to be
      changed.
      
      Fix reloading inline-signed zones by clearing DNS_ZONEFLG_LOADPENDING
      for the signed version of the zone once the raw version reload
      completes.  Take care not to clear it prematurely during initial zone
      load.  Also make sure that DNS_ZONEFLG_LOADPENDING gets cleared when
      zone_postload() encounters an error or returns early, to prevent other
      scenarios from resulting in the same problem.  Add comments aiming to
      help explain code flow.
      
      [1] see RT #47076
      54315839
    • Michał Kępień's avatar
      Merge branch '482-fix-secure-journal-loading-for-inline-signed-zones' into 'master' · d2785afe
      Michał Kępień authored
      Set DNS_JOURNALOPT_RESIGN when loading the secure journal for an inline-signed zone
      
      Closes #482
      
      See merge request !663
      d2785afe
    • Michał Kępień's avatar
      Add CHANGES entry · b3b1a908
      Michał Kępień authored
      5014.	[bug]		Signatures loaded from the journal for the signed
      			version of an inline-signed zone were not scheduled for
      			refresh. [GL #482]
      b3b1a908
    • Michał Kępień's avatar
      Set DNS_JOURNALOPT_RESIGN when loading the secure journal for an inline-signed zone · 8db550c4
      Michał Kępień authored
      When an inline-signed zone is loaded, the master file for its signed
      version is loaded and then a rollforward of the journal for the signed
      version of the zone is performed.  If DNS_JOURNALOPT_RESIGN is not set
      during the latter phase, signatures loaded from the journal for the
      signed version of the zone will not be scheduled for refresh.  Fix the
      conditional expression determining which flags should be used for the
      dns_journal_rollforward() call so that DNS_JOURNALOPT_RESIGN is set when
      zone_postload() is called for the signed version of an inline-signed
      zone.
      
      Extend bin/tests/system/stop.pl so that it can use "rndc halt" instead
      of "rndc stop" as the former allows master file flushing upon shutdown
      to be suppressed.
      8db550c4
    • Michał Kępień's avatar
      Merge branch... · 71793853
      Michał Kępień authored
      Merge branch '390-do-not-treat-a-referral-with-a-non-empty-answer-section-as-an-error' into 'master'
      
      Do not treat a referral with a non-empty ANSWER section as an error
      
      Closes #390
      
      See merge request !628
      71793853
    • Michał Kępień's avatar
      Add CHANGES entry · 2923ab49
      Michał Kępień authored
      5013.	[bug]		A referral response with a non-empty ANSWER section was
      			inadvertently being treated as an error. [GL #390]
      2923ab49
    • Michał Kępień's avatar
      Do not treat a referral with a non-empty ANSWER section as an error · 24b9ec55
      Michał Kępień authored
      As part of resquery_response() refactoring [1], a goto statement was
      replaced [2] with a call to a new function - originally called
      rctx_delegation(), now folded into rctx_answer_none() - extracted from
      existing code.  However, one call site of that refactored function does
      not reset the "result" variable, causing a referral with a non-empty
      ANSWER section to be inadvertently treated as an error, which prevents
      resolution of names reliant on servers sending such responses.  Fix by
      resetting the "result" variable to ISC_R_SUCCESS when a response
      containing a non-empty ANSWER section can be treated as a delegation.
      
      [1] see RT #45362
      
      [2] see commit e1380a16741a3b4a57e54d7a9ce09dd12691522f
      24b9ec55
  5. 21 Aug, 2018 1 commit