1. 25 Mar, 2020 3 commits
    • Ondřej Surý's avatar
      Fix 'Dereference of null pointer' from scan-build-10 · 9b76eea0
      Ondřej Surý authored
      These are mostly false positives, the clang-analyzer FAQ[1] specifies
      why and how to fix it:
      
      > The reason the analyzer often thinks that a pointer can be null is
      > because the preceding code checked compared it against null. So if you
      > are absolutely sure that it cannot be null, remove the preceding check
      > and, preferably, add an assertion as well.
      
      The 2 warnings reported are:
      
      byname_test.c:308:34: warning: Access to field 'fwdtable' results in a dereference of a null pointer (loaded from variable 'view')
                      RUNTIME_CHECK(dns_fwdtable_add(view->fwdtable, dns_rootname,
                                                     ^~~~~~~~~~~~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/util.h:318:52: note: expanded from macro 'RUNTIME_CHECK'
                                                         ^~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/error.h:50:21: note: expanded from macro 'ISC_ERROR_RUNTIMECHECK'
              ((void)(ISC_LIKELY(cond) ||  \
                                 ^~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/likely.h:23:43: note: expanded from macro 'ISC_LIKELY'
                                                  ^
      1 warning generated.
      
      --
      
      ./rndc.c:255:6: warning: Dereference of null pointer (loaded from variable 'host')
              if (*host == '/') {
                  ^~~~~
      1 warning generated.
      
      References:
      1. https://clang-analyzer.llvm.org/faq.html#null_pointer
      
      (cherry picked from commit ddd0d356)
      9b76eea0
    • Ondřej Surý's avatar
      Fix 'Dead nested assignment's from scan-build-10 · 138dded9
      Ondřej Surý authored
      The 3 warnings reported are:
      
      os.c:872:7: warning: Although the value stored to 'ptr' is used in the enclosing expression, the value is never actually read from 'ptr'
              if ((ptr = strtok_r(command, " \t", &last)) == NULL) {
                   ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 warning generated.
      
      --
      
      rpz.c:1117:10: warning: Although the value stored to 'zbits' is used in the enclosing expression, the value is never actually read from 'zbits'
              return (zbits &= x);
                      ^        ~
      1 warning generated.
      
      --
      
      openssleddsa_link.c:532:10: warning: Although the value stored to 'err' is used in the enclosing expression, the value is never actually read from 'err'
              while ((err = ERR_get_error()) != 0) {
                      ^     ~~~~~~~~~~~~~~~
      1 warning generated.
      
      (cherry picked from commit 262f087b)
      138dded9
    • Ondřej Surý's avatar
      Merge branch 'ondrej/remove-debian-jessie-from-gitlab-ci-v9_11' into 'v9_11' · df81669a
      Ondřej Surý authored
      Remove Debian 8 ("Jessie") from the GitLab CI
      
      See merge request !3284
      df81669a
  2. 24 Mar, 2020 1 commit
    • Ondřej Surý's avatar
      Remove Debian 8 ("Jessie") from the GitLab CI · e2d6d0ee
      Ondřej Surý authored
      There are several reason why remove Debian 8 from the CI:
      
      * Debian 8 ("jessie") has been superseded by Debian 9 ("stretch").
      * Regular security support updates have been discontinued as of
        June 17th, 2018.
      * Jessie LTS is supported from 17th June 2018 to June 30, 2020.
      
      In other words, it's no longer officially supported by Debian security
      team, but by the volunteer/paid contributor composed LTS team.  And the
      release will be discontinued in three months from now.  We can use the
      freed CI resources to bring new platforms or just to make the jobs run a
      bit faster.
      
      (cherry picked from commit 75f46cc3)
      e2d6d0ee
  3. 20 Mar, 2020 13 commits
    • Ondřej Surý's avatar
      Merge branch '4-gitlab-ci.yml-improvement-v9_11' into 'v9_11' · 54e6a881
      Ondřej Surý authored
      Improve GitLab CI configuration (v9.11)
      
      See merge request !3261
      54e6a881
    • Ondřej Surý's avatar
      Rename MAKE environment variable to MAKE_COMMAND · 10d671ae
      Ondřej Surý authored
      The environment variable MAKE has been replaced with MAKE_COMMAND,
      because overriding MAKE variable also changed the definition of the MAKE
      inside the Makefiles, and we want only a single wrapper around the whole
      build process.
      
      Previously, setting `MAKE` to `bear make` meant that `bear make` would
      be run at every nested make invocation, which messed up the upcoming
      automake transition as compile_commands.json would be generated in every
      subdirectory instead of just having one central file at the top of the
      build tree.
      
      (cherry picked from commit de1a637a)
      10d671ae
    • Ondřej Surý's avatar
      Replace dependencies+needs with needs+artifacts in GitLabCI config · 8fa8ed29
      Ondřej Surý authored
      All jobs now use solely the newer needs configuration to declare
      dependencies between jobs:
      
          needs:
            - job: <foo>
              artifacts: true
      
      instead of combination of dependencies and needs which is deprecated.
      This change completely unbundles the stages (alas the stages still needs
      to stay because the job graph has to stay acyclic between the stages).
      
      (cherry picked from commit 66ba808c)
      8fa8ed29
    • Michal Nowak's avatar
      Merge branch 'mnowak/abi-tracker-helper-v9.17.0-v9_11' into 'v9_11' · 6975b3a8
      Michal Nowak authored
      [v9_11] Bump BIND baseline version for abi-check
      
      See merge request !3271
      6975b3a8
    • Michal Nowak's avatar
      Bump BIND baseline version for abi-check · ba6ed675
      Michal Nowak authored
      (cherry picked from commit 3730d59b)
      ba6ed675
    • Michal Nowak's avatar
      Merge branch 'mnowak/unit-test-debugging-enhancements-v9_11' into 'v9_11' · 1befd980
      Michal Nowak authored
      [v9_11] Enhance unit test debugging
      
      See merge request !3268
      1befd980
    • Michal Nowak's avatar
      Enhance unit test debugging · 0603dc86
      Michal Nowak authored
      When unit test fails, core file is created. Kyua's 'debug' command can
      run GDB on it and provide backtrace. Unfortunately Kyua is picky about
      location of these core files we opt to use custom Kyua fork and copy
      core files from Kyua working directory to source tree and make it
      available in GitLab.
      
      (cherry picked from commit 94fa27e4)
      0603dc86
    • Matthijs Mekking's avatar
      Merge branch 'v9_11_17-release' into 'v9_11' · c17114d1
      Matthijs Mekking authored
      Apply 9.11.17 release branch
      
      See merge request !3264
      c17114d1
    • Michał Kępień's avatar
      Ensure util/check-make-install.in is exported · 7beca6a4
      Michał Kępień authored
      ./configure needs util/check-make-install.in to be present in the source
      directory in order to complete successfully.  Make sure this file is
      included in source tarballs created from the repository.
      7beca6a4
    • Tinderbox User's avatar
      Adjust lib/isc/api version · 4236979e
      Tinderbox User authored
      The libisc LIBINTERFACE bump for 9.11.17 is unnecessary.
      A lot of headers were altered but the ABI tool did not report anything.
      Trust the ABI tool on this and decrement LIBINTERFACE and increment
      LIBREVISION.
      4236979e
    • Tinderbox User's avatar
      Note 9.11.17 in README · bee39b12
      Tinderbox User authored
      bee39b12
    • Tinderbox User's avatar
      regen v9_11 · 05ceac54
      Tinderbox User authored
      Michal caught at the last moment that a CHANGES entry did
      not have a GitLab issue/mr reference.  This check was omitted from
      the release process documentation.  The wiki is updated and the
      CHANGES file is updated in this commit.
      05ceac54
    • Tinderbox User's avatar
      prep 9.11.17 · d050ec24
      Tinderbox User authored
      Bumped the version file and added release line in CHANGES.
      
      API files:
      - lib/bind9/api:
        No changes because only changes in comments.
      - lib/dns/api:
        Increment LIBINTERFACE because of the added field structure in
        dns_struct_update.
      - lib/isc/api:
        Increment LIBINTERFACE because of the PKCS#11 replacement.
      - lib/isccc/api:
        No changes because no source code changes.
      - lib/isccfg/api:
        Increment LIBREVISION because of minor source code changes.
      - lib/lwres/api:
        No changes because no source code changes.
      
      I decided no changes to README.md or the release notes were necessary.
      
      Perflab graphs look sane.
      d050ec24
  4. 19 Mar, 2020 2 commits
  5. 18 Mar, 2020 3 commits
  6. 17 Mar, 2020 6 commits
  7. 16 Mar, 2020 6 commits
  8. 15 Mar, 2020 1 commit
  9. 13 Mar, 2020 5 commits