GitLab

These are mostly false positives, the clang-analyzer FAQ[1] specifies
why and how to fix it:

> The reason the analyzer often thinks that a pointer can be null is
> because the preceding code checked compared it against null. So if you
> are absolutely sure that it cannot be null, remove the preceding check
> and, preferably, add an assertion as well.

The 2 warnings reported are:

byname_test.c:308:34: warning: Access to field 'fwdtable' results in a dereference of a null pointer (loaded from variable 'view')
                RUNTIME_CHECK(dns_fwdtable_add(view->fwdtable, dns_rootname,
                                               ^~~~~~~~~~~~~~
/builds/isc-projects/bind9/lib/isc/include/isc/util.h:318:52: note: expanded from macro 'RUNTIME_CHECK'
                                                   ^~~~
/builds/isc-projects/bind9/lib/isc/include/isc/error.h:50:21: note: expanded from macro 'ISC_ERROR_RUNTIMECHECK'
        ((void)(ISC_LIKELY(cond) ||  \
                           ^~~~
/builds/isc-projects/bind9/lib/isc/include/isc/likely.h:23:43: note: expanded from macro 'ISC_LIKELY'
                                            ^
1 warning generated.

--

./rndc.c:255:6: warning: Dereference of null pointer (loaded from variable 'host')
        if (*host == '/') {
            ^~~~~
1 warning generated.

References:
1. https://clang-analyzer.llvm.org/faq.html#null_pointer

(cherry picked from commit ddd0d356)

(cherry picked from commit 994e6569)
(cherry picked from commit 88492940)

(cherry picked from commit cb6a185c)
(cherry picked from commit d61e6a31)

(cherry picked from commit 55a10b7a)

4867.	[cleanup]	Normalize rndc on/off commands (validation and
			querylog) so they accept the same synonyms
			for on/off (yes/no, true/false, enable/disable).
			Thanks to Tony Finch. [RT #47022]

(cherry picked from commit cf8f4241)

(cherry picked from commit 1b0ca5d5)

Patch submitted by Tony Finch (dot@dotat.at).

(cherry picked from commit e9917a51)

(cherry picked from commit 7bb9972a)

                        the specific PKCS11 providers capabilities. [RT #42458]

(cherry picked from commit 8ee6f289)

(cherry picked from commit f814343d)

                        in named and rndc. (CVE-2016-1285) [RT #41666]

Squashed commit of the following:

commit 73f0bba7d8d4763763ff88731c739ac646714ac8
Author: Mukund Sivaraman <muks@isc.org>
Date:   Mon Jul 13 05:40:35 2015 +0530

    Update rndc usage output

    This is based on a patch sent by Tony Finch.

3938.	[func]		Added quotas to be used in recursive resolvers
			that are under high query load for names in zones
			whose authoritative servers are nonresponsive or
			are experiencing a denial of service attack.

			- "fetches-per-server" limits the number of
			  simultaneous queries that can be sent to any
			  single authoritative server.  The configured
			  value is a starting point; it is automatically
			  adjusted downward if the server is partially or
			  completely non-responsive. The algorithm used to
			  adjust the quota can be configured via the
			  "fetch-quota-params" option.
			- "fetches-per-zone" limits the number of
			  simultaneous queries that can be sent for names
			  within a single domain.  (Note: Unlike
			  "fetches-per-server", this value is not
			  self-tuning.)
			- New stats counters have been added to count
			  queries spilled due to these quotas.

			See the ARM for details of these options. [RT #37125]

4115.	[func]		"rndc -r" now prints the result code (e.g.,
			ISC_R_SUCCESS, ISC_R_TIMEOUT, etc) after
			running the requested command. [RT #38913]

4039.	[cleanup]	Cleaned up warnings from gcc -Wshadow. [RT #37381]

4005.	[func]		The buffer used for returning text from rndc
			commands is now dynamically resizable, allowing
			arbitrarily large amounts of text to be sent back
			to the client. (Prior to this change, it was
			possible for the output of "rndc tsig-list" to be
			truncated.) [RT #37731]

3776.	[bug]		"rndc -q" suppresses output from successful
			rndc commands. Errors are printed on stderr.
                        [RT #21393]

                        information will be automatically updated if the
                        OS supports routing sockets.  Use
                        "automatic-interface-scan no;" to disable.

                        Add "rndc scan" to trigger a scan. [RT #23027]

3698.	[cleanup]	Replaced all uses of memcpy() with memmove().
			[RT #35120]

3513.	[bug]		named could crash when deleting inline-signing
			zones with "rndc delzone". [RT #34066]

3585.	[func]		"rndc delzone -clean" option removes zone files
			when deleting a zone. [RT #33570]

                        [RT #33571]

3525.	[func]		Support for additional signing algorithms in rndc:
			hmac-sha1, -sha224, -sha256, -sha384, and -sha512.
			The -A option to rndc-confgen can be used to
			select the algorithm for the generated key.
			(The default is still hmac-md5; this may
			change in a future release.) [RT #20363]

3401.	[bug]		Addressed Coverity warnings. [RT #31484]