1. 16 Jan, 2020 2 commits
  2. 15 Jan, 2020 1 commit
  3. 14 Jan, 2020 5 commits
  4. 13 Jan, 2020 3 commits
    • Evan Hunt's avatar
      count statistics in netmgr UDP code · 90a1dabe
      Evan Hunt authored
      - also restored a test in the statistics test which was changed when
        the netmgr was introduced because active sockets were not being
        counted.
      90a1dabe
    • Evan Hunt's avatar
      associate socket stats counters with netmgr socket objects · 80a5c9f5
      Evan Hunt authored
      - the socket stat counters have been moved from socket.h to stats.h.
      - isc_nm_t now attaches to the same stats counter group as
        isc_socketmgr_t, so that both managers can increment the same
        set of statistics
      - isc__nmsocket_init() now takes an interface as a paramter so that
        the address family can be determined when initializing the socket.
      - based on the address family and socket type, a group of statistics
        counters will be associated with the socket - for example, UDP4Active
        with IPv4 UDP sockets and TCP6Active with IPv6 TCP sockets.  note
        that no counters are currently associated with TCPDNS sockets; those
        stats will be handled by the underlying TCP socket.
      - the counters are not actually used by netmgr sockets yet; counter
        increment and decrement calls will be added in a later commit.
      80a5c9f5
    • Tony Finch's avatar
      Fix line spacing in `rndc secroots` · 5b600c2c
      Tony Finch authored
      Before this change, there was a missing blank line between the
      negative trust anchors for one view, and the heading line for the next
      view. This is because dns_ntatable_totext() omits the last newline.
      There is an example of the incorrect output below; the fixed output
      has a blank line before "Start view auth".
      
      secure roots as of 21-Oct-2019 12:03:23.500:
      
       Start view rec
         Secure roots:
      
      ./RSASHA256/20326 ; managed
      
         Negative trust anchors:
      
      example.com: expiry 21-Oct-2019 13:03:15.000
       Start view auth
         Secure roots:
      
      ./RSASHA256/20326 ; managed
      
         Negative trust anchors:
      
      example.com: expiry 21-Oct-2019 13:03:07.000
      5b600c2c
  5. 08 Jan, 2020 1 commit
  6. 07 Jan, 2020 4 commits
  7. 06 Jan, 2020 1 commit
  8. 03 Jan, 2020 1 commit
  9. 20 Dec, 2019 2 commits
  10. 17 Dec, 2019 2 commits
  11. 13 Dec, 2019 1 commit
    • Mark Andrews's avatar
      Fix autosign system test issues. · 17d25dbf
      Mark Andrews authored
      * report when NSEC3PARAM is not yet present
      * allow more time for NSEC3PARAM to become present
      * adjust frequency failure message
      17d25dbf
  12. 12 Dec, 2019 2 commits
  13. 11 Dec, 2019 4 commits
  14. 10 Dec, 2019 1 commit
    • Michał Kępień's avatar
      Only use LC_ALL=C where intended · 2ee7ff23
      Michał Kępień authored
      The LC_ALL=C assignments in the "idna" system test, which were only
      meant to affect a certain subset of checks, in fact persist throughout
      all the subsequent checks in that system test.  That affects the test's
      behavior and is misleading.
      
      When the "VARIABLE=value command ..." syntax is used in a shell script,
      in order for the variable assignment to only apply to "command", the
      latter must be an external binary; otherwise, the VARIABLE=value
      assignment persists for all subsequent commands in a script:
      
          $ cat foo.sh
          #!/bin/sh
      
          foo() {
              /bin/sh bar.sh
          }
      
          BAR="baz0"
          BAR="baz1" /bin/sh bar.sh
          echo "foo: BAR=${BAR}"
          BAR="baz2" foo
          echo "foo: BAR=${BAR}"
      
          $ cat bar.sh
          #!/bin/sh
      
          echo "bar: BAR=${BAR}"
      
          $ /bin/sh foo.sh
          bar: BAR=baz1
          foo: BAR=baz0
          bar: BAR=baz2
          foo: BAR=baz2
          $
      
      Fix by saving the value of LC_ALL before the relevant set of checks in
      the "idna" system test, restoring it afterwards, and dropping the
      "LC_ALL=C command ..." syntax.
      2ee7ff23
  15. 09 Dec, 2019 10 commits
    • Ondřej Surý's avatar
      Bail-out early if dig fails to finish successfully or takes too long · 2a65a47f
      Ondřej Surý authored
      Before, the zero system test could get stuck almost infinitely, because
      the first test sends > 300 queries with 5 seconds timeout on each in
      each pass.  If named crashed early, it would took the test more than 4
      hours to properly timeout.
      
      This commit introduces a "watchdog" on the dig commands running in the
      background and failing the test on timeout, failing any test if any dig
      command fails to return successfully, and making the tests.sh script
      shellcheck clean.
      2a65a47f
    • Ondřej Surý's avatar
    • Ondřej Surý's avatar
      Make forward system test shellcheck clean · 0e15cbb0
      Ondřej Surý authored
      0e15cbb0
    • Ondřej Surý's avatar
    • Ondřej Surý's avatar
      Add the standard $n to each test · 64df488e
      Ondřej Surý authored
      64df488e
    • Witold Kręcicki's avatar
    • Mark Andrews's avatar
      loop waiting for the redirect zone to load · 9e8cd3cc
      Mark Andrews authored
      9e8cd3cc
    • Matthijs Mekking's avatar
      Fix get key id from key_idpad · 2e7cb497
      Matthijs Mekking authored
      The kasp system test has a call to sed to retrieve the key identifier
      without leading zeros.  The sed call could not handle key id 0.
      Update the kasp test to also correctly deal with this case.
      2e7cb497
    • Matthijs Mekking's avatar
      bd403590
    • Matthijs Mekking's avatar
      Fix race in autosign test · 2e4273b5
      Matthijs Mekking authored
      The autosign test has a test case where a DNSSEC maintaiend zone
      has a set of DNSSEC keys without any timing metadata set.  It
      tests if named picks up the key for publication and signing if a
      delayed dnssec-settime/loadkeys event has occured.
      
      The test failed intermittently despite the fact it sleeps for 5
      seconds but the triggered key reconfigure action should happen after
      3 seconds.
      
      However, the test output showed that the test query came in before
      the key reconfigure action was complete (see excerpts below).
      
      The loadkeys command is received:
      
      15:38:36 received control channel command 'loadkeys delay.example.'
      
      The reconfiguring zone keys action is triggered after 3 seconds:
      
      15:38:39 zone delay.example/IN: reconfiguring zone keys
      15:38:39 DNSKEY delay.example/NSEC3RSASHA1/7484 (ZSK) is now published
      15:38:39 DNSKEY delay.example/NSEC3RSASHA1/7455 (KSK) is now published
      15:38:39 writing to journal
      
      Two seconds later the test query comes in:
      
      15:38:41 client @0x7f1b8c0562b0 10.53.0.1#44177: query
      15:38:41 client @0x7f1b8c0562b0 10.53.0.1#44177: endrequest
      
      And 6 more seconds later the reconfigure keys action is complete:
      
      15:38:47 zone delay.example/IN: next key event: 05-Dec-2019 15:48:39
      
      This commit fixes the test by checking the "next key event" log has
      been seen before executing the test query, making sure that the
      reconfigure keys action has been complete.
      
      This commit however does not fix, nor explain why it took such a long
      time (8 seconds) to reconfigure the keys.
      2e4273b5