1. 16 Jan, 2020 1 commit
  2. 15 Jan, 2020 1 commit
  3. 14 Jan, 2020 2 commits
  4. 13 Jan, 2020 2 commits
    • Evan Hunt's avatar
      count statistics in netmgr UDP code · 90a1dabe
      Evan Hunt authored
      - also restored a test in the statistics test which was changed when
        the netmgr was introduced because active sockets were not being
    • Tony Finch's avatar
      Fix line spacing in `rndc secroots` · 5b600c2c
      Tony Finch authored
      Before this change, there was a missing blank line between the
      negative trust anchors for one view, and the heading line for the next
      view. This is because dns_ntatable_totext() omits the last newline.
      There is an example of the incorrect output below; the fixed output
      has a blank line before "Start view auth".
      secure roots as of 21-Oct-2019 12:03:23.500:
       Start view rec
         Secure roots:
      ./RSASHA256/20326 ; managed
         Negative trust anchors:
      example.com: expiry 21-Oct-2019 13:03:15.000
       Start view auth
         Secure roots:
      ./RSASHA256/20326 ; managed
         Negative trust anchors:
      example.com: expiry 21-Oct-2019 13:03:07.000
  5. 08 Jan, 2020 1 commit
  6. 07 Jan, 2020 4 commits
  7. 13 Dec, 2019 1 commit
    • Mark Andrews's avatar
      Fix autosign system test issues. · 17d25dbf
      Mark Andrews authored
      * report when NSEC3PARAM is not yet present
      * allow more time for NSEC3PARAM to become present
      * adjust frequency failure message
  8. 12 Dec, 2019 1 commit
  9. 11 Dec, 2019 4 commits
  10. 10 Dec, 2019 1 commit
    • Michał Kępień's avatar
      Only use LC_ALL=C where intended · 2ee7ff23
      Michał Kępień authored
      The LC_ALL=C assignments in the "idna" system test, which were only
      meant to affect a certain subset of checks, in fact persist throughout
      all the subsequent checks in that system test.  That affects the test's
      behavior and is misleading.
      When the "VARIABLE=value command ..." syntax is used in a shell script,
      in order for the variable assignment to only apply to "command", the
      latter must be an external binary; otherwise, the VARIABLE=value
      assignment persists for all subsequent commands in a script:
          $ cat foo.sh
          foo() {
              /bin/sh bar.sh
          BAR="baz1" /bin/sh bar.sh
          echo "foo: BAR=${BAR}"
          BAR="baz2" foo
          echo "foo: BAR=${BAR}"
          $ cat bar.sh
          echo "bar: BAR=${BAR}"
          $ /bin/sh foo.sh
          bar: BAR=baz1
          foo: BAR=baz0
          bar: BAR=baz2
          foo: BAR=baz2
      Fix by saving the value of LC_ALL before the relevant set of checks in
      the "idna" system test, restoring it afterwards, and dropping the
      "LC_ALL=C command ..." syntax.
  11. 09 Dec, 2019 13 commits
  12. 06 Dec, 2019 7 commits
    • Mark Andrews's avatar
      Increase wait_for_message attempts to 20. · 4dd9ec89
      Mark Andrews authored
    • Mark Andrews's avatar
      save wait_for_message contents · 1334daae
      Mark Andrews authored
    • Michał Kępień's avatar
      Automatically run clean.sh from run.sh · d8905b7a
      Michał Kępień authored
      The first step in all existing setup.sh scripts is to call clean.sh.  To
      reduce code duplication and ensure all system tests added in the future
      behave consistently with existing ones, invoke clean.sh from run.sh
      before calling setup.sh.
    • Michał Kępień's avatar
      Detect missing system test results · 3c3085be
      Michał Kępień authored
      At the end of each system test suite run, the system test framework
      collects all existing test.output files from system test subdirectories
      and produces bin/tests/system/systests.output from those files.
      However, it does not check whether a test.output file was found for
      every executed test.  Thus, if the test.output file is accidentally
      deleted by the system test itself (e.g. due to an overly broad file
      removal wildcard present in clean.sh), its output will not be included
      in bin/tests/system/systests.output.  Since the result of each system
      test suite run is determined by bin/tests/system/testsummary.sh, which
      only operates on the contents of bin/tests/system/systests.output, this
      can lead to test failures being ignored.  Fix by ensuring the number of
      test results found in bin/tests/system/systests.output is equal to the
      number of tests run and triggering a system test suite failure in case
      of a discrepancy between these two values.
    • Michał Kępień's avatar
      Remove bin/tests/system/clean.sh · bf3eeac0
      Michał Kępień authored
      Since the role of the bin/tests/system/clean.sh script has now been
      reduced to calling a given system test's clean.sh script, remove the
      former altogether and replace its only use with a direct invocation of
      the latter.
    • Michał Kępień's avatar
      Remove the -r switch from system test scripts · b4d37878
      Michał Kępień authored
      Since files containing system test output are no longer stored in test
      subdirectories, bin/tests/system/clean.sh no longer needs to take care
      of removing the test.output file for a given test as testsummary.sh
      already takes care of that and even if a test suite terminates
      abnormally and another one is started, tee invoked without the -a
      command line switch overwrites the destination file if it exists, so
      leftover test.output.* files from previous test suite runs are not a
      concern.  Remove the -r command line switch and the code associated with
      it from the relevant scripts.
    • Michał Kępień's avatar
      Store system test output in bin/tests/system/ · b0916bba
      Michał Kępień authored
      Some clean.sh scripts contain overly broad file deletion wildcards which
      cause the test.output file (used by the system test framework for
      collecting output) in a given system test's directory to be erroneously
      removed immediately after the test is started (due to setup.sh scripts
      calling clean.sh at the beginning).  This prevents the test's output
      from being placed in bin/tests/system/systests.output at the end of a
      test suite run and thus can lead to test failures being ignored.  Fix by
      storing each test's output in a test.output.<test-name> file in
      bin/tests/system/, which prevents clean.sh scripts from removing it (as
      they should only ever affect files contained in a given system test's
  13. 05 Dec, 2019 2 commits
    • Mark Andrews's avatar
      loop waiting for the redirect zone to load · e4b1d0b6
      Mark Andrews authored
    • Ondřej Surý's avatar
      Test for the hard fetchlimit instead of soft fetchlimit · c35a4e05
      Ondřej Surý authored
      Previously, the fetchlimit tested the recursive-clients soft limit
      that's defined as 90% of the hard limit (the actual configured value).
      This worked previously because the reaping of the oldest recursive
      client was put on the same event queue as the current TCP client, thus
      the cleaning has happened before the new TCP client established a new
      With the change in BIND 9.14 that added a multiple event queues the
      cleaning of the oldests clients is no longer synchronous and could
      happen stochastically making the soft limit testing fail often.  The
      situation became even worse with the new networking manager, thus we
      change the system test to fail only if the hard limit bound is not
      Changing the accounting of the already reaped TCP clients so the soft
      limit testing is possible again is out of the scope for this change.