1. 07 Feb, 2020 18 commits
  2. 06 Feb, 2020 9 commits
  3. 05 Feb, 2020 13 commits
    • Michal Nowak's avatar
      Merge branch 'mnowak/windows-raise-port-range' into 'master' · 5214f24d
      Michal Nowak authored
      Windows: Prevent tools from clashing with named in system tests
      
      Closes #1566
      
      See merge request !2998
      5214f24d
    • Michal Nowak's avatar
      Windows: Prevent tools from clashing with named in system tests · 7f0fcb8a
      Michal Nowak authored
      In system tests on Windows tool's local port can sometimes clash with
      'named'. On Unix the system is poked for the minimal local port,
      otherwise is set to 32768 as a sane minimum. For Windows we don't
      poke but set a hardcoded limit; this change aligns the limit with
      Unix and changes it to 32768.
      7f0fcb8a
    • Mark Andrews's avatar
      Merge branch 'marka-coverity-master' into 'master' · dd6598f3
      Mark Andrews authored
      Address various minor issues identified by coverity on master
      
      See merge request !2999
      dd6598f3
    • Mark Andrews's avatar
      'dispatch' must be non NULL, remove test. · 891f24fa
      Mark Andrews authored
      10067 cleanup:
      
      	CID 1452683 (#1 of 1): Dereference before null check (REVERSE_INULL)
      	check_after_deref: Null-checking dispatch suggests that it
      	may be null, but it has already been dereferenced on all
      	paths leading to the check.
      
      10068        if (dispatch != NULL)
      10069                isc_mem_put(server->mctx, dispatch, sizeof(*dispatch));
      891f24fa
    • Mark Andrews's avatar
      'dctx' must be non NULL, remove test. · fccf65a5
      Mark Andrews authored
      1549 cleanup:
      1550        if (dctx->dbiter != NULL)
      1551                dns_dbiterator_destroy(&dctx->dbiter);
      1552        if (dctx->db != NULL)
      1553                dns_db_detach(&dctx->db);
      
      	CID 1452686 (#1 of 1): Dereference before null check (REVERSE_INULL)
      	check_after_deref: Null-checking dctx suggests that it may
      	be null, but it has already been dereferenced on all paths
      	leading to the check.
      
      1554        if (dctx != NULL)
      1555                isc_mem_put(mctx, dctx, sizeof(*dctx));
      fccf65a5
    • Mark Andrews's avatar
      'dir_list' must be non NULL, remove test. · bf7a99a3
      Mark Andrews authored
      707 complete_allnds:
      
      	CID 1452689 (#1 of 1): Dereference before null check (REVERSE_INULL)
      	check_after_deref: Null-checking dir_list suggests that it
      	may be null, but it has already been dereferenced on all
      	paths leading to the check.
      
      708        if (dir_list != NULL) {
      709                /* clean up entries from list. */
      bf7a99a3
    • Mark Andrews's avatar
      'lcfg' must be non NULL, remove test. · 7ba1af02
      Mark Andrews authored
      389        else
      
      	CID 1452695 (#1 of 1): Dereference before null check (REVERSE_INULL)
      	check_after_deref: Null-checking lcfg suggests that it may
      	be null, but it has already been dereferenced on all paths
      	leading to the check.
      
      390                if (lcfg != NULL)
      391                        isc_logconfig_destroy(&lcfg);
      7ba1af02
    • Mark Andrews's avatar
      's' must be non NULL, remove test. · 714594d4
      Mark Andrews authored
      122 cleanup:
      
      	CID 1452696 (#1 of 1): Dereference before null check (REVERSE_INULL)
      	check_after_deref: Null-checking s suggests that it may be
      	null, but it has already been dereferenced on all paths
      	leading to the check.
      
      123        if (s != NULL)
      124                isc_mem_free(mctx, s);
      714594d4
    • Mark Andrews's avatar
      'tql' must be non NULL, remove test. · 44b08521
      Mark Andrews authored
      255 flag_fail:
      256        /* get rid of what was build of the query list */
      
      	CID 1452697 (#1 of 1): Dereference before null check (REVERSE_INULL)
      	check_after_deref: Null-checking tql suggests that it may
      	be null, but it has already been dereferenced on all paths
      	leading to the check.
      
      257        if (tql != NULL)
      258                destroy_querylist(mctx, &tql);
      44b08521
    • Mark Andrews's avatar
      'closest' must be non NULL, remove test. · 0312e73e
      Mark Andrews authored
      6412 cleanup:
      6413        dns_rdataset_disassociate(&neg);
      6414        dns_rdataset_disassociate(&negsig);
      
      	CID 1452700 (#1 of 1): Dereference before null check (REVERSE_INULL)
      	check_after_deref: Null-checking closest suggests that it
      	may be null, but it has already been dereferenced on all
      	paths leading to the check.
      
      6415        if (closest != NULL)
      6416                free_noqname(mctx, &closest);
      0312e73e
    • Mark Andrews's avatar
      cleanup error handling. · d6492184
      Mark Andrews authored
      336 cleanup_mem:
      337        /* cleanup memory */
      338
      339        /* free tmpPath memory */
      
      	CID 1452701 (#1 of 1): Dereference before null check (REVERSE_INULL)
      	check_after_deref: Null-checking tmpPath suggests that it
      	may be null, but it has already been dereferenced on all
      	paths leading to the check.
      
      340        if (tmpPath != NULL && result != ISC_R_SUCCESS)
      341                isc_mem_free(named_g_mctx, tmpPath);
      342
      343        /* free tmpPath memory */
      344        return (result);
      d6492184
    • Mark Andrews's avatar
      'stub' cannot be non NULL, remove test. · 2e189bb0
      Mark Andrews authored
      13429 cleanup:
      13430        cancel_refresh(zone);
      
      	CID 1452702 (#1 of 1): Dereference before null check (REVERSE_INULL)
      	check_after_deref: Null-checking stub suggests that it may
      	be null, but it has already been dereferenced on all paths
      	leading to the check.
      
      13431        if (stub != NULL) {
      13432                stub->magic = 0;
      2e189bb0
    • Mark Andrews's avatar
      'noqname' must be non NULL, remove test. · 1b1a94ea
      Mark Andrews authored
      6367cleanup:
      6368        dns_rdataset_disassociate(&neg);
      6369        dns_rdataset_disassociate(&negsig);
      
      	CID 1452704 (#1 of 1): Dereference before null check
      	(REVERSE_INULL) check_after_deref: Null-checking noqname
      	suggests that it may be null, but it has already been
      	dereferenced on all paths leading to the check.
      
      6370        if (noqname != NULL)
      6371                free_noqname(mctx, &noqname);
      1b1a94ea