1. 06 Feb, 2019 29 commits
  2. 05 Feb, 2019 1 commit
  3. 01 Feb, 2019 3 commits
    • Michał Kępień's avatar
      Test "make install" in one of the build jobs · 2a231b62
      Michał Kępień authored
      Running "make install" in a separate job in the "test" phase of a CI
      pipeline causes a lot of object files to be rebuilt due to the way
      artifacts are passed between GitLab CI jobs (object files extracted from
      the artifacts archive have older modification times than their
      respective source files checked out using Git by the worker running the
      "install" job).  Test "make install" in one of the build jobs instead,
      in order to prevent object rebuilding.
      
      Using 'after_script' for this purpose was not an option because its
      failures are ignored.
      
      Duplicating the build script in two places would be error-prone in the
      long run and thus was rejected as a solution.  YAML anchors would also
      not help in this case.
      
      A "positive" test (`test -n "${RUN_MAKE_INSTALL}" && make install`)
      would not work because:
      
        - it would cause the build script to fail for any job not supposed to
          run "make install",
      
        - appending `|| :` to the shell pipeline would prevent "make install"
          errors from causing a job failure.
      
      Due to the above, a "negative" test is performed, so that:
      
        - jobs not supposed to run "make install" succeed immediately,
      
        - jobs supposed to run "make install" only succeed when "make install"
          succeeds.
      2a231b62
    • Evan Hunt's avatar
      Merge branch 'each-win-tests' into 'master' · 1557d116
      Evan Hunt authored
      tests failing on windows due to false crash-on-shutdown reports
      
      See merge request !1446
      1557d116
    • Evan Hunt's avatar
  4. 31 Jan, 2019 7 commits
    • Evan Hunt's avatar
      Merge branch '513-add-xfer-stats-for-primary-servers' into 'master' · acf42a75
      Evan Hunt authored
      Make primary's transfer log more detailed
      
      See merge request !1427
      acf42a75
    • Michał Kępień's avatar
      Add CHANGES entry · ed6317a1
      Michał Kępień authored
      5153.	[func]		Zone transfer statistics (size, number of records, and
      			number of messages) are now logged for outgoing
      			transfers as well as incoming ones. [GL #513]
      ed6317a1
    • Michał Kępień's avatar
      Add system tests for IXFR statistics · a9a47c79
      Michał Kępień authored
      Ensure IXFR statistics are calculated correctly by dig and named, both
      for incoming and outgoing transfers.  Disable EDNS when using dig to
      request an IXFR so that the same reference file can be used for testing
      statistics calculated by both dig and named (dig uses EDNS by default
      when sending transfer requests, which affects the number of bytes
      transferred).
      a9a47c79
    • Michał Kępień's avatar
      Add system tests for AXFR statistics · a22e24a4
      Michał Kępień authored
      Ensure AXFR statistics are calculated correctly by dig and named, both
      for incoming and outgoing transfers.  Rather than employing a zone which
      is already used in the "xfer" system test, create a new one whose AXFR
      form spans multiple TCP messages.  Disable EDNS when using dig to
      request an AXFR so that the same reference file can be used for testing
      statistics calculated by both dig and named (dig uses EDNS by default
      when sending transfer requests, which affects the number of bytes
      transferred).
      a22e24a4
    • Michał Kępień's avatar
      Add functions for extracting transfer statistics · 6071c6cc
      Michał Kępień authored
      Add two helper shell functions to facilitate extracting transfer
      statistics from dig output and named log files.
      6071c6cc
    • Michał Kępień's avatar
      Maintain and report outgoing transfer statistics · 7f52b872
      Michał Kępień authored
      Transfer statistics are currently only reported for incoming transfers,
      even though they are equally useful for outgoing transfers.  Define a
      separate structure for keeping track of the number of messages, records,
      and bytes sent during each outgoing transfer, along with the time each
      outgoing transfer took.  Repurpose the 'nmsg' field of the xfrout_ctx_t
      structure for tracking the number of messages actually sent, ensuring it
      is only increased after isc_socket_send() indicates success.  Report the
      statistics gathered when an outgoing transfer completes.
      7f52b872
    • Michał Kępień's avatar
      Track QUESTION section presence using a boolean · c20d81fd
      Michał Kępień authored
      The 'nmsg' field of the xfrout_ctx_t structure is an integer, even
      though it is only ever compared against 0 (for tracking whether the
      QUESTION section has already been sent to the client).  Use a boolean
      instead as it is more appropriate and also enables 'nmsg' to be
      repurposed.
      c20d81fd