(cherry picked from commit 48ca11df)

(cherry picked from commit a04bb769)

(cherry picked from commit b71a1386)

(cherry picked from commit e8249dcd)

(cherry picked from commit 70d192eb)

(cherry picked from commit a4186b18)

(cherry picked from commit f2c22662)

(cherry picked from commit dcd309be)

adjust goto target and conditional compilation so that cleanup_spillattimer and cleanup_alglock labels match the element to be cleanup and so that they are always used

(cherry picked from commit 7b27be54)

Resolve "upforwd test error"

See merge request !72

(cherry picked from commit 54e010d5)

Tidy runall.sh environment variables

See merge request !18

Michał Kępień authored Feb 21, 2018 and Evan Hunt committed Feb 24, 2018

This enables the environment variables controlling run.sh behavior to be
permanently set in a working environment (e.g. to automatically force
colored output without using "-c" in each runall.sh invocation).

Relevant runall.sh command line arguments still have a higher priority.

(cherry picked from commit d989d20f)

Michał Kępień authored Feb 21, 2018 and Evan Hunt committed Feb 24, 2018

As parallel.mk and runsequential.sh both pipe system test output through
"tee" (for the purpose of creating test.output), run.sh invoked from
these two files detects it is not writing to a terminal, which prevents
colored output from being generated.  Allow forcing colored output using
a new command line argument for runall.sh, "-c", which sets an
environment variable (SYSTEMTEST_FORCE_COLOR) causing conf.sh to
unconditionally enable colored output.

The same environment variable can also be used directly to force colored
output when using "make test" instead of runall.sh.

(cherry picked from commit a324031a)

Michał Kępień authored Feb 21, 2018 and Evan Hunt committed Feb 24, 2018

Instead of exporting an environment variable containing a command line
argument (NOCLEAN="-n"), extend run.sh to handle a "boolean" environment
variable (SYSTEMTEST_NO_CLEAN) itself.  The former method is buggy
because the value of NOCLEAN is set in parallel.mk when that file is
first created, but it is not subsequently updated upon each test run
(because make considers parallel.mk to be up to date).

To retain backward compatibility, the "-n" command line argument for
run.sh is still supported (and has a higher priority than the relevant
environment variable).

The SYSTEMTEST_NO_CLEAN environment variable can also be used directly
to prevent cleanup when using "make test" instead of runall.sh.

Apart from fixing a bug, this simplifies the way runall.sh controls
run.sh behavior due to the Makefile being bypassed.  Direct processing
of environment variables in run.sh is more scalable in the long run,
given that the previously utilized technique, even with its
implementation fixed, would still require Makefile.in to be modified in
two places each time a new flag needed to be passed from runall.sh to
run.sh.

(cherry picked from commit 38620438)

chg: dev: Improve the resilience of the xfer system test, which could be flaky under load.

Closes #71

See merge request !61

(cherry picked from commit 5d7d6881)
(cherry picked from commit 09a1a261)

chg: dev: Unit tests were broken in out-of-tree builds.

See merge request !57

Petr Menšík authored Feb 22, 2018 and Evan Hunt committed Feb 23, 2018

 generated into builddir. If out-of-tree build is used, make unit
will always fail. Kyuafiles and testdata still have to be copied
manually into the builddir.

(cherry picked from commit 95cde360)

Code cleanups

See merge request !36

Petr Menšík authored Feb 15, 2018 and Evan Hunt committed Feb 23, 2018

Use common part once a bit later.

(cherry picked from commit 2a70eae0)
(cherry picked from commit d04af522)

Petr Menšík authored Jan 17, 2018 and Evan Hunt committed Feb 23, 2018

(cherry picked from commit e7a93321)
(cherry picked from commit cb98ce8e)

Resolve "dyndb system test fails intermittently"

Closes #95

See merge request !63

- no longer grep for specific line numbers when checking
  parameter logging, as those can change
- report the failure immediatey if parameter check fails

(cherry picked from commit 749df056)

chg: dev: Convert most of the remaining system tests to be able to run in parallel [GL #91]

Closes #91

See merge request !59

- lengthed the wait loop for the transfers to complete

(cherry picked from commit b9246ce7)
(cherry picked from commit a5015d77)

- this was a test for the allow-v6-synthesis option, which was
  deprecated and no longer works. the test was removed
  from conf.sh.in long ago.

(cherry picked from commit 474b10a1)
(cherry picked from commit 79718736)

(cherry picked from commit 731ad28b)
(cherry picked from commit 17245b86)

(cherry picked from commit 56e440f6)
(cherry picked from commit 4429f8b2)

(cherry picked from commit c032c54d)
(cherry picked from commit 2b81f322)

Allow parallel run of system tests

See merge request !7

(cherry picked from commit dbf753b5)

1. Track changes to conf.sh.in in conf.sh.win32
2. Modifications to prevent Windows "Configure" script replacing
   the sed "@PORT@" substitution tokens in conf.sh.win32.
3. runall.sh now runs Windows tests sequentially

(cherry picked from commit 7bb9a979)

(cherry picked from commit 7222c9fc)

It was TESTNAME, but this is an obvious name and was used in one of
the system tests, something that interfered with the content of
progress messages.  It is now SYSTESTDIR.

(cherry picked from commit 30cd931a)

Michał Kępień authored Jan 29, 2018 and Stephen Morris committed Feb 22, 2018

(cherry picked from commit 2c519531)

Michał Kępień authored Jan 29, 2018 and Stephen Morris committed Feb 22, 2018

(cherry picked from commit e005fb94)

(cherry picked from commit 3dfb7c17)