1. 17 Sep, 2019 4 commits
    • Michal Nowak's avatar
      Remove unused configure checks for dblatex · c871dda0
      Michal Nowak authored
      c871dda0
    • Michal Nowak's avatar
      Find docbook-xsl and dblatex templates on Red Hat/Fedora · 0055b961
      Michal Nowak authored
      `/usr/share/sgml/docbook/xsl-stylesheets` and `/usr/share/dblatex` are
      places where docbook-style-xsl and, respectively, dblatex packages on
      Red Hat systems put their XSL templates. Unless we hint this place it
      has to be added to `./configure` manually (`--with-docbook-xsl=...`):
      https://src.fedoraproject.org/rpms/bind/blob/master/f/bind.spec#_691.
      
      On Fedora 30:
      
      Before
      ```
      ./configure
      ...
      checking for Docbook-XSL path... auto
      checking for html/docbook.xsl... "not found"
      checking for xhtml/docbook.xsl... "not found"
      checking for manpages/docbook.xsl... "not found"
      checking for html/chunk.xsl... "not found"
      checking for xhtml/chunk.xsl... "not found"
      checking for html/chunktoc.xsl... "not found"
      checking for xhtml/chunktoc.xsl... "not found"
      checking for html/maketoc.xsl... "not found"
      checking for xhtml/maketoc.xsl... "not found"
      checking for xsl/docbook.xsl... "not found"
      checking for xsl/latex_book_fast.xsl... "not found"
      ```
      
      After:
      ```
      ./configure
      ...
      checking for Docbook-XSL path... auto
      checking for html/docbook.xsl... /usr/share/sgml/docbook/xsl-stylesheets/html/docbook.xsl
      checking for xhtml/docbook.xsl... /usr/share/sgml/docbook/xsl-stylesheets/xhtml/docbook.xsl
      checking for manpages/docbook.xsl... /usr/share/sgml/docbook/xsl-stylesheets/manpages/docbook.xsl
      checking for html/chunk.xsl... /usr/share/sgml/docbook/xsl-stylesheets/html/chunk.xsl
      checking for xhtml/chunk.xsl... /usr/share/sgml/docbook/xsl-stylesheets/xhtml/chunk.xsl
      checking for html/chunktoc.xsl... /usr/share/sgml/docbook/xsl-stylesheets/html/chunktoc.xsl
      checking for xhtml/chunktoc.xsl... /usr/share/sgml/docbook/xsl-stylesheets/xhtml/chunktoc.xsl
      checking for html/maketoc.xsl... /usr/share/sgml/docbook/xsl-stylesheets/html/maketoc.xsl
      checking for xhtml/maketoc.xsl... /usr/share/sgml/docbook/xsl-stylesheets/xhtml/maketoc.xsl
      checking for xsl/docbook.xsl... /usr/share/dblatex/xsl/docbook.xsl
      checking for xsl/latex_book_fast.xsl... /usr/share/dblatex/xsl/latex_book_fast.xsl
      ```
      0055b961
    • Ondřej Surý's avatar
      Merge branch 'ondrej/improve-flycheck-configuration' into 'master' · 12142cbe
      Ondřej Surý authored
      Remove the current directory from the flycheck configuration
      
      See merge request !2347
      12142cbe
    • Ondřej Surý's avatar
  2. 16 Sep, 2019 3 commits
    • Ondřej Surý's avatar
      Merge branch '414-use-p11-kit-headers' into 'master' · c3d684cf
      Ondřej Surý authored
      Resolve "Legal issue with pkcs11 headers"
      
      Closes #414
      
      See merge request !2251
      c3d684cf
    • Ondřej Surý's avatar
      Use standard PKCS#11 standard error codes instead of custom error codes · f6922d6e
      Ondřej Surý authored
      * CKR_CRYPTOKI_ALREADY_INITIALIZED: This value can only be returned by
        `C_Initialize`. It means that the Cryptoki library has already been
        initialized (by a previous call to `C_Initialize` which did not have a
        matching `C_Finalize` call).
      
      * CKR_FUNCTION_NOT_SUPPORTED: The requested function is not supported by this
        Cryptoki library. Even unsupported functions in the Cryptoki API should have a
        “stub” in the library; this stub should simply return the value
        CKR_FUNCTION_NOT_SUPPORTED.
      
      * CKR_LIBRARY_LOAD_FAILED: The Cryptoki library could not load a dependent
        shared library.
      f6922d6e
    • Ondřej Surý's avatar
      Replace the OASIS PKCS#11 header file with one from p11-kit · c47fad24
      Ondřej Surý authored
      The OASIS pkcs11.h header has a restrictive license.  Replace the
      pkcs11.h pkcs11f.h and pkcs11t.h headers with pkcs11.h from p11-kit.
      
      For source distribution, the license for the OASIS headers itself
      doesn't pose any licensing problem when combined with MPL license, but
      it possibly creates problem for downstream distributors of BIND 9.
      c47fad24
  3. 13 Sep, 2019 7 commits
  4. 12 Sep, 2019 21 commits
    • Michal Nowak's avatar
      Merge branch 'mnowak_README_fixes' into 'master' · 6ba5a08c
      Michal Nowak authored
      Various README.md and README fixes
      
      See merge request !2323
      6ba5a08c
    • Michal Nowak's avatar
      Various README.md and README fixes · 4e2fdd7e
      Michal Nowak authored
      Fixing typos, typographical glitches. Added backticks around binaries,
      modules, and libraries so it's more consistent. Added a paragraph with
      ISC Security Policy.
      4e2fdd7e
    • Michał Kępień's avatar
      Merge branch 'michal/add-freebsd-to-ci' into 'master' · 7a3896ef
      Michał Kępień authored
      Add FreeBSD to CI
      
      See merge request !2242
      7a3896ef
    • Michał Kępień's avatar
      Add FreeBSD to GitLab CI · 51af91d0
      Michał Kępień authored
      Ensure BIND can be tested on FreeBSD in GitLab to more quickly catch
      build and test errors on that operating system.  Make the relevant jobs
      optional until the CI environment supporting them is deemed stable
      enough for continuous use.
      
      FreeBSD jobs are run using the Custom executor feature of GitLab Runner.
      Unlike the Docker executor, the Custom executor does not support the
      "image" option and thus some way of informing the runner about the OS
      version to use for a given job is necessary.  Arguably the simplest way
      of doing that without a lot of code duplication in .gitlab-ci.yml would
      be to use a YAML template with a "variables" block specifying the
      desired FreeBSD release to use, but including such a template in a job
      definition would cause issues in case other variables also needed to be
      set for that job (e.g. CFLAGS or EXTRA_CONFIGURE for build jobs).  Thus,
      only one FreeBSD YAML template is defined instead and the Custom
      executor scripts on FreeBSD runners extract the OS version to use from
      the CI job name.  This allows .gitlab-ci.yml variables to be defined for
      FreeBSD jobs in the same way as for Docker-based jobs.
      51af91d0
    • Michał Kępień's avatar
      Tweak lib/dns/tests/tkey_test requirements · 154f2ca6
      Michał Kępień authored
      Currently, the lib/dns/tests/tkey_test unit test is only run when the
      linker supports the --wrap option.  However, linker support for that
      option is only needed for static builds.  As a result, the unit test
      mentioned before is not being run everywhere it can be run as even for
      builds done using --with-libtool, the test is not run unless the linker
      supports the --wrap option.
      
      Tweak preprocessor directives in lib/dns/tests/tkey_test.c so that this
      test is run:
      
        - for all builds using --with-libtool,
        - for static builds done using a linker supporting the --wrap option.
      154f2ca6
    • Michał Kępień's avatar
      Make lib/dns/tests/tkey_test.c more portable · 119f3e0c
      Michał Kępień authored
      Weak symbols are handled differently by different dynamic linkers.  With
      glibc, lib/dns/tests/tkey_test works as expected no matter whether
      --with-libtool is used or not: __attribute__((weak)) prevents a static
      build from failing and it just so happens that the desired symbols are
      picked at runtime for dynamic builds.  However, with BSD libc, the
      libdns functions called from lib/dns/tests/tkey_test.c use the "real"
      memory allocation functions from libisc, thus breaking that unit test.
      (Note: similar behavior can be reproduced with glibc by setting the
      LD_DYNAMIC_WEAK environment variable.)
      
      The simplest way to make lib/dns/tests/tkey_test work reliably is to
      drop all uses of __attribute__((weak)) in it - this way, the memory
      functions inside lib/dns/tests/tkey_test.c will always be used instead
      of the "real" libisc ones for dynamic builds.  However, this would not
      work with static builds as it would result in multiple strong symbols
      with the same name being present in a single binary.
      
      Work around the problem by only compiling in the overriding definitions
      of memory functions when building using --with-libtool.  For static
      builds, keep relying on the --wrap linker option for replacing calls to
      the functions we are interested in.
      119f3e0c
    • Michał Kępień's avatar
      Set --logfile for all kyua invocations · 1bffa602
      Michał Kępień authored
      When kyua is called without the --logfile command line option, the log
      file is created at a default location which is derived from the HOME
      environment variable.  On FreeBSD GitLab CI runners, /home is a
      read-only directory and thus kyua invocations not using the --logfile
      option fail when HOME is set to something beneath /home.  Set --logfile
      to /dev/null for all kyua invocations whose logs are irrelevant in order
      to prevent kyua failures caused by HOME being non-writable.
      1bffa602
    • Michał Kępień's avatar
      Merge branch 'michal/misc-doc-fixes' into 'master' · 87018ce2
      Michał Kępień authored
      Miscellaneous documentation fixes
      
      See merge request isc-projects/bind9!2329
      87018ce2
    • Michał Kępień's avatar
      Fix latest BIND version number in CHANGES · 995d6b74
      Michał Kępień authored
      BIND version number in CHANGES was not updated when the 9.15.4 release
      was prepared.  Make sure the correct version number is used.
      995d6b74
    • Michał Kępień's avatar
      Fix <command> XML tag · b0ee065e
      Michał Kępień authored
      Restore proper spelling of the <command> XML tag to prevent release note
      text from getting mangled.
      b0ee065e
    • Michał Kępień's avatar
      README: do not mention /usr/include on macOS · 5af0b1d1
      Michał Kępień authored
      For newer versions of Xcode, "xcode-select --install" no longer installs
      system headers into /usr/include (instead, they are installed in the
      Xcode directory tree), so do not mention that path in the macOS section
      of README to prevent confusion.
      5af0b1d1
    • Mark Andrews's avatar
      Merge branch 'marka-split-notes-master' into 'master' · 0023060d
      Mark Andrews authored
      split notes.xml into sections
      
      See merge request isc-projects/bind9!2326
      0023060d
    • Mark Andrews's avatar
      split notes.xml into sections · 0d51dec3
      Mark Andrews authored
      0d51dec3
    • Mark Andrews's avatar
      Merge branch '1043-cppcheck-detected-code-issues' into 'master' · 44fa4d20
      Mark Andrews authored
      Resolve "cppcheck-detected code issues"
      
      Closes #1043
      
      See merge request isc-projects/bind9!2239
      44fa4d20
    • Mark Andrews's avatar
      address or suppress cppcheck warnings · b59fe46e
      Mark Andrews authored
      b59fe46e
    • Ondřej Surý's avatar
      Merge branch 'ondrej/refactor-and-cleanup-isc_mem_create' into 'master' · 30b6e93a
      Ondřej Surý authored
      Refactor and cleanup isc_mem_create()
      
      See merge request isc-projects/bind9!2315
      30b6e93a
    • Ondřej Surý's avatar
      Remove now useless ISC_MEMFLAG_NOLOCK memflag · aeea5ece
      Ondřej Surý authored
      Previously the libisc allocator had ability to run unlocked when threading was
      disabled.  As the threading is now always on, remove the ISC_MEMFLAG_NOLOCK
      memory flag as it serves no purpose.
      aeea5ece
    • Ondřej Surý's avatar
      Remove unused isc_mem_createx() function · 19fbdef3
      Ondřej Surý authored
      The isc_mem_createx() function was only used in the tests to eliminate using the
      default flags (which as of writing this commit message was ISC_MEMFLAG_INTERNAL
      and ISC_MEMFLAG_FILL).  This commit removes the isc_mem_createx() function from
      the public API.
      19fbdef3
    • Ondřej Surý's avatar
    • Ondřej Surý's avatar
    • Ondřej Surý's avatar
      Simplify isc_mem_create() to always use defaults and never fail · 1b716a39
      Ondřej Surý authored
      Previously, the isc_mem_create() and isc_mem_createx() functions took `max_size`
      and `target_size` as first two arguments.  Those values were never used in the
      BIND 9 code.  The refactoring removes those arguments and let BIND 9 always use
      the default values.
      
      Previously, the isc_mem_create() and isc_mem_createx() functions could have
      failed because of failed memory allocation.  As this was no longer true and the
      functions have always returned ISC_R_SUCCESS, the have been refactored to return
      void.
      1b716a39
  5. 09 Sep, 2019 5 commits