1. 25 Feb, 2018 1 commit
  2. 23 Feb, 2018 1 commit
  3. 15 Feb, 2018 4 commits
    • Michał Kępień's avatar
      Do not recheck DNS_ZONEFLG_LOADPENDING in zone_asyncload() · f5079bb8
      Michał Kępień authored
      Remove a block of code which dates back to commit 8a2ab2b9, when
      dns_zone_asyncload() did not yet check DNS_ZONEFLG_LOADPENDING.
      Currently, no race in accessing DNS_ZONEFLG_LOADPENDING is possible any
      more, because:
      
        - dns_zone_asyncload() is still the only function which may queue
          zone_asyncload(),
      
        - dns_zone_asyncload() accesses DNS_ZONEFLG_LOADPENDING under a lock
          (and potentially queues an event under the same lock),
      
        - DNS_ZONEFLG_LOADPENDING is not cleared until the load actually
          completes.
      
      Thus, the rechecking code can be safely removed from zone_asyncload().
      
      Note that this also brings zone_asyncload() to a state in which the
      completion callback is always invoked.  This is required to prevent
      leaking memory in case something goes wrong in zone_asyncload() and a
      zone table the zone belongs to is indefinitely left with a positive
      reference count.
      f5079bb8
    • Michał Kępień's avatar
      Asynchronous zone load events have no way of getting canceled · b9e9361c
      Michał Kępień authored
      Code handling cancellation of asynchronous zone load events was likely
      copied over from other functions when asynchronous zone loading was
      first implemented in commit 8a2ab2b9.  However, unlike those other
      functions, asynchronous zone loading events currently have no way of
      getting canceled once they get posted, which means the aforementioned
      code is effectively dead.  Remove it to prevent confusion.
      b9e9361c
    • Michał Kępień's avatar
      Only clear DNS_ZONEFLG_LOADPENDING in zone_asyncload() if zone loading is completed immediately · 29b7efdd
      Michał Kępień authored
      zone_load() is not always synchronous, it may only initiate an
      asynchronous load and return DNS_R_CONTINUE, which means zone loading
      has not yet been completed.  In such a case, zone_asyncload() must not
      clear DNS_ZONEFLG_LOADPENDING immediately and leave that up to
      zone_postload().
      29b7efdd
    • Michał Kępień's avatar
      Lock zone before checking whether its asynchronous load is already pending · 0e4fba2c
      Michał Kępień authored
      While this is not an issue in named, which only calls
      dns_zone_asyncload() from task-exclusive mode, this function is exported
      by libdns and thus may in theory be concurrently called for the same
      zone by multiple threads.  It also does not hurt to be consistent
      locking-wise with other DNS_ZONEFLG_LOADPENDING accesses.
      0e4fba2c
  4. 12 Feb, 2018 1 commit
  5. 23 Jan, 2018 1 commit
  6. 12 Jan, 2018 1 commit
  7. 03 Jan, 2018 2 commits
  8. 13 Dec, 2017 1 commit
  9. 05 Dec, 2017 1 commit
  10. 04 Dec, 2017 1 commit
  11. 29 Nov, 2017 1 commit
  12. 23 Nov, 2017 1 commit
  13. 17 Nov, 2017 1 commit
    • Mark Andrews's avatar
      4821. [bug] When resigning ensure that the SOA's expire time is · 656eed7c
      Mark Andrews authored
                              always later that the resigning time of other records.
                              [RT #46473]
      
      4820.   [bug]           dns_db_subtractrdataset should transfer the resigning
                              information to the new header. [RT #46473]
      
      4819.   [bug]           Fully backout the transaction when adding a RRset
                              to the resigning / removal heaps fail. [RT #46473]
      656eed7c
  14. 09 Nov, 2017 1 commit
  15. 08 Nov, 2017 1 commit
  16. 02 Nov, 2017 1 commit
  17. 27 Oct, 2017 1 commit
    • Evan Hunt's avatar
      [master] tag initializing keys · c9f8165a
      Evan Hunt authored
      4798.	[func]		Keys specified in "managed-keys" statements
      			are tagged as "initializing" until they have been
      			updated by a key refresh query. If initialization
      			fails it will be visible from "rndc secroots".
      			[RT #46267]
      c9f8165a
  18. 25 Oct, 2017 1 commit
  19. 12 Oct, 2017 3 commits
  20. 11 Oct, 2017 1 commit
  21. 06 Oct, 2017 3 commits
  22. 05 Oct, 2017 1 commit
  23. 04 Oct, 2017 1 commit
  24. 03 Oct, 2017 1 commit
  25. 26 Sep, 2017 1 commit
  26. 18 Sep, 2017 1 commit
  27. 14 Sep, 2017 3 commits
  28. 13 Sep, 2017 2 commits
  29. 17 Aug, 2017 1 commit