1. 24 Jan, 2019 1 commit
  2. 10 Jan, 2019 1 commit
  3. 07 Dec, 2018 1 commit
  4. 06 Dec, 2018 15 commits
    • Michał Kępień's avatar
      make hook actions return an enum instead of a bool · 0e12988d
      Michał Kępień authored
      Use an enum instead of a bool for the return type of hook actions in
      order to facilitate adding further hook processing models in the future.
      0e12988d
    • Evan Hunt's avatar
      name change from "hook modules" to "plugins" · fd20f10d
      Evan Hunt authored
      - "hook" is now used only for hook points and hook actions
      - the "hook" statement in named.conf is now "plugin"
      - ns_module and ns_modlist are now ns_plugin and ns_plugins
      - ns_module_load is renamed ns_plugin_register
      - the mandatory functions in plugin modules (hook_register,
        hook_check, hook_version, hook_destroy) have been renamed
      fd20f10d
    • Evan Hunt's avatar
      8da0c0e7
    • Evan Hunt's avatar
      restore filter-aaaa syntax checking · 7a47e4d8
      Evan Hunt authored
      - added functionality to check hook parameters in named-checkconf,
        and restored the checkconf tests that were removed from the
        filter-aaaa test.
      7a47e4d8
    • Evan Hunt's avatar
      refactor to support multiple module instances · b94945e6
      Evan Hunt authored
      - use a per-view module list instead of global hook_modules
      - create an 'instance' pointer when registering modules, store it in
        the module structure, and use it as action_data when calling
        hook functions - this enables multiple module instances to be set
        up in parallel
      - also some nomenclature changes and cleanup
      b94945e6
    • Michał Kępień's avatar
    • Evan Hunt's avatar
      copy ns_hook objects before adding them to a hook table · 0b988256
      Evan Hunt authored
      - this is necessary because adding the same hook to multiple views
        causes the ISC_LIST link value to become inconsistent; it isn't
        noticeable when only one hook action is ever registered at a
        given hook point, but it will break things when there are two.
      0b988256
    • Evan Hunt's avatar
      use entirely local persistent data in modules · 74683fbc
      Evan Hunt authored
      - eliminate qctx->hookdata and client->hookflags.
      - use a memory pool to allocate data blobs in the filter-aaaa module,
        and associate them with the client address in a hash table
      - instead of detaching the client in query_done(), mark it for deletion
        and then call ns_client_detach() from qctx_destroy(); this ensures
        that it will still exist when the QCTX_DESTROYED hook point is
        reached.
      74683fbc
    • Evan Hunt's avatar
      clear AD flag when altering response messages · 427e9ca3
      Evan Hunt authored
      - the AD flag was not being cleared correctly when filtering
      - enabled dnssec valdiation in the filter-aaaa test to confirm this
        works correctly now
      427e9ca3
    • Evan Hunt's avatar
      improve hook processing macros · 055bf266
      Evan Hunt authored
      - use a get_hooktab() function to determine the hook table.
      - PROCESS_HOOK now jumps to a cleanup tag on failure
      - add PROCESS_ALL_HOOKS in query.c, to run all hook functions at
        a specified hook point without stopping. this is to be used for
        intiialization and destruction functions that must run in every
        module.
      - 'result' is set in PROCESS_HOOK only when a hook function
        interrupts processing.
      - revised terminology: a "callback" is now a "hook action"
      - remove unused NS_PROCESS_HOOK and NS_PROCESS_HOOK_VOID macros.
      055bf266
    • Evan Hunt's avatar
      enable modules to store data in qctx · 81f58e2e
      Evan Hunt authored
      - added a 'hookdata' array to qctx to store pointers to up to
        16 blobs of data which are allocated by modules as needed.
        each module is assigned an ID number as it's loaded, and this
        is the index into the hook data array. this is to be used for
        holding persistent state between calls to a hook module for a
        specific query.
      - instead of using qctx->filter_aaaa, we now use qctx->hookdata.
        (this was the last piece of filter-aaaa specific code outside the
        module.)
      - added hook points for qctx initialization and destruction. we get
        a filter-aaaa data pointer from the mempool when initializing and
        store it in the qctx->hookdata table; return to to the mempool
        when destroying the qctx.
      - link the view to the qctx so that detaching the client doesn't cause
        hooks to fail
      - added a qctx_destroy() function which must be called after qctx_init;
        this calls the QCTX_DESTROY hook and detaches the view
      - general cleanup and comments
      81f58e2e
    • Evan Hunt's avatar
      add a parser to filter-aaaa.so and pass in the parameters · 9911c835
      Evan Hunt authored
      - make some cfg-parsing functions global so they can be run
        from filter-aaaa.so
      - add filter-aaaa options to the hook module's parser
      - mark filter-aaaa options in named.conf as obsolete, remove
        from named and checkconf, and update the filter-aaaa test not to
        use checkconf anymore
      - remove filter-aaaa-related struct members from dns_view
      9911c835
    • Evan Hunt's avatar
      add hook statement to configuration parser · d2f46443
      Evan Hunt authored
      - allow multiple "hook" statements at global or view level
      - add "optional bracketed text" type for optional parameter list
      - load hook module from specified path rather than hardcoded path
      - add a hooktable pointer (and a callback for freeing it) to the
        view structure
      - change the hooktable functions so they no longer update ns__hook_table
        by default, and modify PROCESS_HOOK so it uses the view hooktable, if
        set, rather than ns__hook_table. (ns__hook_table is retained for
        use by unit tests.)
      - update the filter-aaaa system test to load filter-aaaa.so
      - add a prereq script to check for dlopen support before running
        the filter-aaaa system test
      
      not yet done:
      - configuration parameters are not being passed to the filter-aaaa
        module; the filter-aaaa ACL and filter-aaaa-on-{v4,v6} settings are
        still stored in dns_view
      d2f46443
    • Evan Hunt's avatar
      e2ac439e
    • Evan Hunt's avatar
      initial implementation of filter-aaaa.so as a shared object · d3f0f71b
      Evan Hunt authored
      - temporary kluge! in this version, for testing purposes,
        named always searches for a filter-aaaa module at /tmp/filter-aaaa.so.
        this enables the filter-aaaa system test to run even though the
        code to configure hooks in named.conf hasn't been written yet.
      - filter-aaaa-on-v4, filter-aaaa-on-v6 and the filter-aaaa ACL are
        still configured in the view as they were before, not in the hook.
      d3f0f71b