- 16 Jun, 2022 1 commit
-
-
Michal Nowak authored
pylint 2.14.2 reports the following warnings: bin/tests/system/checkds/tests-checkds.py:265:0: W1404: Implicit string concatenation found in call (implicit-str-concat) bin/tests/system/checkds/tests-checkds.py:273:0: W1404: Implicit string concatenation found in call (implicit-str-concat)
-
- 08 Jun, 2022 1 commit
-
-
Tom Krizek authored
This patch is strictly the result of: $ black $(git ls-files '*.py') There have been no manual changes.
-
- 14 Mar, 2022 2 commits
-
-
Michał Kępień authored
Ensure all "import dns.*" statements are always placed after pytest.importorskip('dns') calls, in order to allow the latter to fulfill their purpose. Explicitly import all dnspython modules used by each dnspython-based test to avoid relying on nested imports. Replace function-scoped imports with global imports to reduce code duplication.
-
Michał Kępień authored
The intended purpose of the @pytest.mark.dnspython{,2} decorators was to cause dnspython-based tests to be skipped if dnspython is not available (or not recent enough). However, a number of system tests employing those decorators contain global "import dns.resolver" statements which trigger ImportError exceptions during test initialization if dnspython is not available. In other words, the @pytest.mark.dnspython{,2} decorators serve no useful purpose. Currently, whenever a Python-based test requires dnspython, that requirement applies to all tests in a given *.py file. Given that, employ global pytest.importorskip() calls to ensure dnspython-based parts of various system tests are skipped when dnspython is not available. Remove all occurrences of the @pytest.mark.dnspython{,2} decorators (and all associated code) to prevent confusion.
-
- 11 Jan, 2022 1 commit
-
-
Ondřej Surý authored
This commit converts the license handling to adhere to the REUSE specification. It specifically: 1. Adds used licnses to LICENSES/ directory 2. Add "isc" template for adding the copyright boilerplate 3. Changes all source files to include copyright and SPDX license header, this includes all the C sources, documentation, zone files, configuration files. There are notes in the doc/dev/copyrights file on how to add correct headers to the new files. 4. Handle the rest that can't be modified via .reuse/dep5 file. The binary (or otherwise unmodifiable) files could have license places next to them in <foo>.license file, but this would lead to cluttered repository and most of the files handled in the .reuse/dep5 file are system test files.
-
- 16 Sep, 2021 1 commit
-
-
Michał Kępień authored
Address the following warnings reported by PyLint 2.10.2: ************* Module tests-checkds bin/tests/system/checkds/tests-checkds.py:70:9: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) bin/tests/system/checkds/tests-checkds.py:120:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) bin/tests/system/checkds/tests-checkds.py:206:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) ************* Module yamlget bin/tests/system/digdelv/yamlget.py:22:5: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) ************* Module stress_http_quota bin/tests/system/doth/stress_http_quota.py:131:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) ************* Module tests-rpz-passthru-logging bin/tests/system/rpzextra/tests-rpz-passthru-logging.py:40:9: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) bin/tests/system/rpzextra/tests-rpz-passthru-logging.py:44:9: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
-
- 30 Jun, 2021 1 commit
-
-
Matthijs Mekking authored
Add a Pytest based system test for the 'checkds' feature. There is one nameserver (ns9, because it should be started the latest) that has configured several zones with dnssec-policy. The zones are set in such a state that they are waiting for DS publication or DS withdrawal. Then several other name servers act as parent servers that either have the DS for these published, or not. Also one server in the mix is to test a badly configured parental-agent. There are tests for DS publication, DS publication error handling, DS withdrawal and DS withdrawal error handling. The tests ensures that the zone is DNSSEC valid, and that the DSPublish/DSRemoved key metadata is set (or not in case of the error handling). It does not test if the rollover continues, this is already tested in the kasp system test (that uses 'rndc -dnssec checkds' to set the DSPublish/DSRemoved key metadata).
-