1. 15 Jun, 2018 10 commits
    • Michał Kępień's avatar
      Implement zoneverify_log_error() and zoneverify_print() · d949a5d8
      Michał Kępień authored
      These functions will be used in the process of replacing fatal(),
      check_result(), and fprintf() calls throughout lib/dns/zoneverify.c with
      code that does not call exit().  They are intended for:
      
        - zoneverify_log_error(): logging problems encountered while
          performing zone verification,
      
        - zoneverify_print(): printing status messages and reports which are
          only useful in standalone tools.
      
      To make using dns_zone_logv() possible, add a new "zone" argument to
      dns_zoneverify_dnssec() that standalone tools are expected to set to
      NULL.
      d949a5d8
    • Michał Kępień's avatar
      Move algorithm tables to the verification context structure · 730cc3e3
      Michał Kępień authored
      Tables representing algorithm use in the verified zone are commonly
      accessed throughout dns_zoneverify_dnssec().  Move them into the
      structure representing a verification context.  While this does not
      really simplify currently existing code, it will facilitate passing data
      around between smaller functions that dns_zoneverify_dnssec() is about
      to get split into.
      730cc3e3
    • Michał Kępień's avatar
      Move commonly used dns_rdataset_t structures to the verification context structure · 5d666f53
      Michał Kępień authored
      Eight structures representing four RRsets and their signatures are
      commonly accessed throughout dns_zoneverify_dnssec().  Move them into
      the structure representing a verification context.  While this does not
      really simplify currently existing code, it will facilitate passing data
      around between smaller functions that dns_zoneverify_dnssec() is about
      to get split into.
      5d666f53
    • Michał Kępień's avatar
      Move commonly used variables to the verification context structure · 43d0fb84
      Michał Kępień authored
      Move variables commonly used throughout dns_zoneverify_dnssec() and its
      helper functions to the structure representing a verification context in
      order to reduce the number of arguments passed between functions.
      43d0fb84
    • Michał Kępień's avatar
      Do not use static variables in lib/dns/zoneverify.c · ffc79977
      Michał Kępień authored
      Make dns_zoneverify_dnssec() eligible for multithreaded use by replacing
      the static variables it accesses with a stack-allocated structure
      containing these variables.  Implement setup and cleanup routines for
      that structure, ensuring no error in these routines causes exit() to be
      called any more.  Pass a pointer to that structure to functions
      requiring access to variables which were previously static.
      ffc79977
    • Michał Kępień's avatar
      Rename verifyzone() to dns_zoneverify_dnssec() · 7554e8d2
      Michał Kępień authored
      This makes the function's name match the naming convention used for
      libdns functions.
      7554e8d2
    • Michał Kępień's avatar
      Move verifyzone() and its dependencies into lib/dns/zoneverify.c · 3a14450d
      Michał Kępień authored
      This commit only moves code around, with the following exceptions:
      
        - the check_dns_dbiterator_current() macro and functions
          is_delegation() and has_dname() were removed from
          bin/dnssec/dnssectool.{c,h} and duplicated in two locations:
          bin/dnssec/dnssec-signzone.c and lib/dns/zoneverify.c; these
          functions are used both by the code in bin/dnssec/dnssec-signzone.c
          and verifyzone(), but are not a good fit for being exported by a
          code module responsible for zone verification,
      
        - fatal() and check_result() were duplicated in lib/dns/zoneverify.c
          as static functions which do not use the "program" variable any more
          (as it is only set by the tools in bin/dnssec/); this is a temporary
          step which only aims to prevent compilation from breaking - these
          duplicate functions will be removed once lib/dns/zoneverify.c is
          refactored not to use them,
      
        - the list of header files included by lib/dns/zoneverify.c was
          expanded to encompass all header files that are actually used by the
          code in that file,
      
        - a description of the purpose of the commented out "fields" inside
          struct nsec3_chain_fixed was added.
      3a14450d
    • Michał Kępień's avatar
      Replace type_format() and TYPE_FORMATSIZE with their libdns counterparts · ffe8ddd9
      Michał Kępień authored
      Rather than use custom functions and macros local to bin/dnssec/, use
      their counterparts provided by libdns.
      ffe8ddd9
    • Michał Kępień's avatar
      Merge branch '341-constify-dns_rdata_tostruct' into 'master' · c37537cf
      Michał Kępień authored
      Resolve "constify dns_rdata_tostruct"
      
      Closes #341
      
      See merge request !378
      c37537cf
    • Mark Andrews's avatar
  2. 14 Jun, 2018 10 commits
  3. 13 Jun, 2018 15 commits
  4. 12 Jun, 2018 5 commits