GitLab

Resolve "Cppcheck format issues."

See merge request !1696

Mark Andrews authored Mar 14, 2019 and Evan Hunt committed Mar 14, 2019

(cherry picked from commit 1eba2c5b)

Resolve "Assert the hevent->rdataset is non-NULL."

See merge request !1694

Mark Andrews authored Feb 20, 2019 and Evan Hunt committed Mar 14, 2019

(cherry picked from commit d8d04edf)

Merge branch '937-potential-null-pointer-dereference-in-bin-tests-system-dlzexternal-driver-c-v9_11' into 'v9_11'

Resolve "potential null pointer dereference in bin/tests/system/dlzexternal/driver.c"

See merge request !1691

Mark Andrews authored Mar 14, 2019 and Evan Hunt committed Mar 14, 2019

(cherry picked from commit 7bf67503)

Merge branch '935-fix-ecc-algorithms-unused-constants-in-pkcs-11-build-c116fb96-falls-short' into 'v9_11'

Resolve "Fix ECC algorithms unused constants in PKCS#11 build (c116fb96) falls short"

See merge request !1682

Resolve "Missing unlocks in sdlz.c"

See merge request !1680

(cherry picked from commit 32f2ae37)

(cherry picked from commit ff8bf617)

fix race in socket code

See merge request !1674

Witold Kręcicki authored Mar 12, 2019 and Evan Hunt committed Mar 12, 2019

(cherry picked from commit 50f60542)

Witold Kręcicki authored Feb 13, 2019 and Evan Hunt committed Mar 12, 2019

When sending an udp query (resquery_send) we first issue an asynchronous
isc_socket_connect and increment query->connects, then isc_socket_sendto2
and increment query->sends.
If we happen to cancel this query (fctx_cancelquery) we need to cancel
all operations we might have issued on this socket. If we are under very high
load the callback from isc_socket_connect (resquery_udpconnected) might have
not yet been fired. In this case we only cancel the CONNECT event on socket,
and ignore the SEND that's waiting there (as there is an `else if`).
Then we call dns_dispatch_removeresponse which kills the dispatcher socket
and calls isc_socket_close - but if system is under very high load, the send
we issued earlier might still not be complete - which triggers an assertion
because we're trying to close a socket that's still in use.

The fix is to always check if we have incomplete sends on the socket and cancel
them if we do.

(cherry picked from commit 56183a39)

[v9_11] Silence a Perl warning output by stop.pl

See merge request !1670

On Unix systems, the CYGWIN environment variable is not set at all when
BIND system tests are run.  If a named instance crashes on shutdown or
otherwise fails to clean up its pidfile and the CYGWIN environment
variable is not set, stop.pl will print an uninitialized value warning
on standard error.  Prevent this by using defined().

(cherry picked from commit 91e5a99b)

Allow ifconfig to be called from any directory

See merge request !1668

Petr Menšík authored Feb 25, 2019 and Mark Andrews committed Mar 12, 2019

ifconfig.sh depends on config.guess for platform guessing. It uses it to
choose between ifconfig or ip tools to configure interfaces. If
system-wide automake script is installed and local was not found, use
platform guess. It should work well on mostly any sane platform. Still
prefers local guess, but passes when if cannot find it.

(cherry picked from commit 38301052)

use qname in redirect2

See merge request !1664

Mark Andrews authored Feb 22, 2019 and Evan Hunt committed Mar 11, 2019

(cherry picked from commit ad785e4f)

Mark Andrews authored Feb 21, 2019 and Evan Hunt committed Mar 11, 2019

(cherry picked from commit 8758d36a)

Stabilize the "gost" system test

See merge request !1642

In the "gost" system test, the ./NS RRset returned in the response to
ns2's priming query might not yet be validated when ns2 assembles the
response to the ./SOA query.  If that happens, the ./NS RRset will not
be placed in the AUTHORITY section of the response to the ./SOA query,
triggering a false positive for the "gost" system test as the ./NS RRset
is always present in the response sent by ns1 (since it is authoritative
for the root zone).  As the purpose of the "gost" system test is to
check whether a zone signed using GOST is properly validated and only
positive responses are inspected, use the +noauth dig option for all
queries in that test, so that the contents of the AUTHORITY section do
not influence its outcome.

[v9_11] Stabilize "delzsk.example" zone checks

See merge request !1659

When a zone is converted from NSEC to NSEC3, the private record at zone
apex indicating that NSEC3 chain creation is in progress may be removed
during a different (later) zone_nsec3chain() call than the one which
adds the NSEC3PARAM record.  The "delzsk.example" zone check only waits
for the NSEC3PARAM record to start appearing in dig output while private
records at zone apex directly affect "rndc signing -list" output.  This
may trigger false positives for the "autosign" system test as the output
of the "rndc signing -list" command used for checking ZSK deletion
progress may contain extra lines which are not accounted for.  Ensure
the private record is removed from zone apex before triggering ZSK
deletion in the aforementioned check.

Also future-proof the ZSK deletion progress check by making it only look
at lines it should care about.

(cherry picked from commit e02de04e)

[v9_11] "dnssec" system test tweaks

See merge request !1657

Mark Andrews authored Feb 21, 2019 and Michał Kępień committed Mar 11, 2019

(cherry picked from commit dee1f1a4)

For checks querying a named instance with "dnssec-accept-expired yes;"
set, authoritative responses have a TTL of 300 seconds.  Assuming empty
resolver cache, TTLs of RRsets in the ANSWER section of the first
response to a given query will always match their authoritative
counterparts.  Also note that for a DNSSEC-validating named resolver,
validated RRsets replace any existing non-validated RRsets with the same
owner name and type, e.g. cached from responses received while resolving
CD=1 queries.  Since TTL capping happens before a validated RRset is
inserted into the cache and RRSIG expiry time does not impose an upper
TTL bound when "dnssec-accept-expired yes;" is set and, as pointed out
above, the original TTLs of the relevant RRsets equal 300 seconds, the
RRsets in the ANSWER section of the responses to expiring.example/SOA
and expired.example/SOA queries sent with CD=0 should always be exactly
120 seconds, never a lower value.  Make the relevant TTL checks stricter
to reflect that.

(cherry picked from commit a85cc414)

Always expecting a TTL of exactly 300 seconds for RRsets found in the
ADDITIONAL section of responses received for CD=1 queries sent during
TTL capping checks is too strict since these responses will contain
records cached from multiple DNS messages received during the resolution
process.

In responses to queries sent with CD=1, ns.expiring.example/A in the
ADDITIONAL section will come from a delegation returned by ns2 while the
ANSWER section will come from an authoritative answer returned by ns3.
If the queries to ns2 and ns3 happen at different Unix timestamps,
RRsets cached from the older response will have a different TTL by the
time they are returned to dig, triggering a false positive.

Allow a safety margin of 60 seconds for checks inspecting the ADDITIONAL
section of responses to queries sent with CD=1 to fix the issue.  A
safety margin this large is likely overkill, but it is used nevertheless
for consistency with similar safety margins used in other TTL capping
checks.

(cherry picked from commit 8baf8590)

Changes introduced by commit 6b8e4d6e
were incomplete as not all time-sensitive checks were updated to match
revised "nta-lifetime" and "nta-recheck" values.  Prevent rare false
positives by updating all NTA-related checks so that they work reliably
with "nta-lifetime 12s;" and "nta-recheck 9s;".  Update comments as well
to prevent confusion.

(cherry picked from commit 9a36a1bb)

[v9_11] Fix regex used for mangling druz/DNSKEY (in the "dlv" system test)

See merge request !1648

During "dlv" system test setup, the "sed" regex used for mangling the
DNSKEY RRset for the "druz" zone does not include the plus sign ("+"),
which may:

  - cause the replacement to happen near the end of DNSKEY RDATA, which
    can cause the latter to become an invalid Base64 string,

  - prevent the replacement from being performed altogether.

Both cases prevent the "dlv" system test from behaving as intended and
may trigger false positives.  Add the missing character to the
aforementioned regex to ensure the replacement is always performed on
bytes 10-25 of DNSKEY RDATA.

(cherry picked from commit fd13fef2)

[v9_11] Make delv use OS-supplied ephemeral port range

See merge request !1646

5180.	[bug]		delv now honors the operating system's preferred
			ephemeral port range. [GL #925]

(cherry picked from commit bf983249)

Make delv honor the operating system's preferred ephemeral port range
instead of always using the default 1024-65535 range for outgoing
messages.

(cherry picked from commit ada6846a)

cleanup: use dns_secalg_t and dns_dsdigest_t where appropriate

See merge request !1644

Tony Finch authored Feb 08, 2019 and Mark Andrews committed Mar 08, 2019

Use them in structs for various rdata types where they are missing.
This doesn't change the structs since we are replacing explicit
uint8_t field types with aliases for uint8_t.

Use dns_dsdigest_t in library function arguments.

(cherry picked from commit 0f219714)

#include <limits.h> for PATH_MAX, define if not found

See merge request !1638

(cherry picked from commit 1fc7be36)

silence a warning about potential snprintf overrun

See merge request !1634