1. 14 Jan, 2020 1 commit
  2. 18 Nov, 2019 1 commit
  3. 30 Jul, 2019 1 commit
    • Michał Kępień's avatar
      Include <sched.h> where necessary for musl libc · 59528d0e
      Michał Kępień authored
      All unit tests define the UNIT_TESTING macro, which causes <cmocka.h> to
      replace malloc(), calloc(), realloc(), and free() with its own functions
      tracking memory allocations.  In order for this not to break
      compilation, the system header declaring the prototypes for these
      standard functions must be included before <cmocka.h>.
      
      Normally, these prototypes are only present in <stdlib.h>, so we make
      sure it is included before <cmocka.h>.  However, musl libc also defines
      the prototypes for calloc() and free() in <sched.h>, which is included
      by <pthread.h>, which is included e.g. by <isc/mutex.h>.  Thus, unit
      tests including "dnstest.h" (which includes <isc/mem.h>, which includes
      <isc/mutex.h>) after <cmocka.h> will not compile with musl libc as for
      these programs, <sched.h> will be included after <cmocka.h>.
      
      Always including <cmocka.h> after all other header files is not a
      feasible solution as that causes the mock assertion macros defined in
      <isc/util.h> to mangle the contents of <cmocka.h>, thus breaking
      compilation.  We cannot really use the __noreturn__ or analyzer_noreturn
      attributes with cmocka assertion functions because they do return if the
      tested condition is true.  The problem is that what BIND unit tests do
      is incompatible with Clang Static Analyzer's assumptions: since we use
      cmocka, our custom assertion handlers are present in a shared library
      (i.e. it is the cmocka library that checks the assertion condition, not
      a macro in unit test code).  Redefining cmocka's assertion macros in
      <isc/util.h> is an ugly hack to overcome that problem - unfortunately,
      this is the only way we can think of to make Clang Static Analyzer
      properly process unit test code.  Giving up on Clang Static Analyzer
      being able to properly process unit test code is not a satisfactory
      solution.
      
      Undefining _GNU_SOURCE for unit test code could work around the problem
      (musl libc's <sched.h> only defines the prototypes for calloc() and
      free() when _GNU_SOURCE is defined), but doing that could introduce
      discrepancies for unit tests including entire *.c files, so it is also
      not a good solution.
      
      All in all, including <sched.h> before <cmocka.h> for all affected unit
      tests seems to be the most benign way of working around this musl libc
      quirk.  While quite an ugly solution, it achieves our goals here, which
      are to keep the benefit of proper static analysis of unit test code and
      to fix compilation against musl libc.
      59528d0e
  4. 19 Jun, 2019 1 commit
    • Ondřej Surý's avatar
      Rename mctx in dnstest.c to dt_mctx to prevent any global/local name clashes · 52f98c57
      Ondřej Surý authored
      The common construct seen in the BIND 9 source is func(isc_mem_t *mctx, ...).
      Unfortunately, the dnstest.{h,c} has been using mctx as a global symbol, which
      in turn generated a lot of errors when update.c got included in update_test.c.
      
      As a rule of thumb, we should avoid naming global symbols with generic names
      (like mctx) and we should prefix them with "namespace" (like dt_mctx).
      52f98c57
  5. 08 Mar, 2019 1 commit
  6. 15 Nov, 2018 1 commit
  7. 31 Aug, 2018 1 commit
  8. 28 Aug, 2018 2 commits
  9. 08 Aug, 2018 1 commit
  10. 08 May, 2018 1 commit
    • Michał Kępień's avatar
      Rework dns_test_makezone() · bfbeef36
      Michał Kępień authored
      The dns_test_makezone() helper function always assigns the created zone
      to some view, which is not always necessary and complicates cleanup of
      non-managed zones as they are required not to be assigned to any view.
      
      Rework dns_test_makezone() in order to make it easier to use in unit
      tests operating on non-managed zones.  Use dns_name_fromstring() instead
      of dns_name_fromtext() to simplify code.  Do not use the CHECK() macro
      and add comments to make code flow simpler to follow.  Use
      dns_test_makeview() instead of dns_view_create().
      
      Adjust existing unit tests using this function so that they still pass.
      bfbeef36
  11. 06 Apr, 2018 2 commits
  12. 23 Feb, 2018 1 commit
  13. 27 Jun, 2016 1 commit
  14. 14 Jun, 2012 1 commit
  15. 10 Mar, 2012 1 commit
  16. 07 Mar, 2012 1 commit
  17. 03 Sep, 2011 2 commits
  18. 02 Sep, 2011 2 commits