GitLab

Witold Krecicki authored Aug 30, 2018 and Evan Hunt committed Aug 31, 2018

(cherry picked from commit 0f0dfc7f)

Resolve "Resolver test was failing"

See merge request !742

(cherry picked from commit feaf381a)

Merge branch '418-bind-in-auto-dnssec-mode-should-support-signature-expiration-jitter-v9_11' into 'v9_11'

Resolve "BIND in auto-dnssec mode should support signature expiration jitter"

See merge request !740

(cherry picked from commit d68499e1)

(cherry picked from commit 8e5abc6c)

increase jitter to cover the entire potential steady state expire range when initially signing the zone

(cherry picked from commit 050fca21)

Resolve "unclosed files in lib/dns/tests/zt_test.c"

See merge request !738

(cherry picked from commit 455bb232)

Add missing CHANGES entry

See merge request !729

silence "missing print.h" warning

See merge request !725

(cherry picked from commit 3c18b7d3)

Resolve "rndc reconfig now performs stat() for all zones"

See merge request !519

Disable make clean at the end of configure step in GitLab CI

See merge request !716

(cherry picked from commit a1d783bb)

update {krb5,ms}-{self,subdomain} descriptions

See merge request !710

(cherry picked from commit a3c5c2c2)

(cherry picked from commit 0370d136)

Reset dig exit code after a TCP connection is established

See merge request !707

Michał Kępień authored Aug 24, 2018 and Mark Andrews committed Aug 27, 2018

5020.	[bug]		dig returned a non-zero exit code when it received a
			reply over TCP after a retry. [GL #487]

(cherry picked from commit 59057bee)

Michał Kępień authored Aug 24, 2018 and Mark Andrews committed Aug 27, 2018

The "exitcode" variable is set to 9 if a TCP connection fails, but is
not reset to 0 if a subsequent TCP connection succeeds.  This causes dig
to return a non-zero exit code if it succeeds in getting a TCP response
after a retry.  Fix by resetting "exitcode" to 0 if connect_done()
receives an event with the "result" field set to ISC_R_SUCCESS.

(cherry picked from commit deb3b85c)

[v9_11] Run and check update_copyrights script in precheck stage

See merge request !700

Ondřej Surý authored Aug 23, 2018 and Ondřej Surý committed Aug 24, 2018

(cherry picked from commit 40163692)

Ondřej Surý authored Aug 23, 2018 and Ondřej Surý committed Aug 24, 2018

(cherry picked from commit 31b53609)

Ondřej Surý authored Aug 23, 2018 and Ondřej Surý committed Aug 24, 2018

(cherry picked from commit 65de91f5)

Ondřej Surý authored Aug 23, 2018 and Ondřej Surý committed Aug 24, 2018

(cherry picked from commit db3d6926)

Merge branch '470-log-a-message-when-ixfr-from-differences-is-set-for-an-inline-signed-zone-v9_11' into 'v9_11'

[v9_11] Log a message when "ixfr-from-differences" is set for an inline-signed zone

See merge request !696

5019.	[cleanup]	A message is now logged when ixfr-from-differences is
			set at zone level for an inline-signed zone. [GL #470]

(cherry picked from commit 4fb5d072)

For inline-signed zones, the value of "ixfr-from-differences" is
hardcoded to:

  - "yes" for the raw version of the zone,
  - "no" for the signed version of the zone.

In other words, any user-provided "ixfr-from-differences" setting is
effectively ignored for an inline-signed zone.  Ensure the user is aware
of that by adding a note to the ARM and logging a message when an
"ixfr-from-differences" option is found at the zone level.

(cherry picked from commit 087157d1)

[v9_11] Fix intermittent "mkeys" system test failures

See merge request !694

$RANDFILE, i.e. bin/tests/system/random.data, should only be written to
if a system test requires support for cryptography and that file does
not already exist.  Otherwise, when multiple system tests are run in
parallel, that file might get truncated due to bin/tools/genrandom.c
using fopen() with mode "w" when writing the destination file.  With
unfortunate timing, this may cause system tests employing BIND tools
which need entropy (e.g. dnssec-keygen) to fail.

Make sure bin/tests/system/metadata/tests.sh no longer calls
bin/tools/genrandom since $RANDFILE is guaranteed to already be created
by the time bin/tools/genrandom is currently called because
bin/tests/system/metadata/prereq.sh uses bin/tests/system/testcrypto.sh.

Make sure bin/tests/system/sfcache/prereq.sh only writes to $RANDFILE if
it does not already exist.

(cherry picked from commit c12388f5)

[v9_11] Prevent a race in the "inline" system test

See merge request !693

A short time window exists between logging the addition of an NSEC3PARAM
record to a zone and committing it to the current version of the zone
database.  If a query arrives during such a time window, an unsigned
response will be returned.  One of the checks in the "inline" system
test requires NSEC3 records to be present in an answer - that check
would fail in the case described above.  Use rndc instead of log
watching for checking whether zone signing and NSEC3 chain modifications
are complete in order to prevent intermittent "inline" system test
failures.

(cherry picked from commit e36c869e)

use sizeof(CK_SLOT_ID)

See merge request !690

(cherry picked from commit 42b16771)

(cherry picked from commit 2c1d8b2e)

unlink before unlock

See merge request !688

(cherry picked from commit 05531d3a)