...
 
Commits (4)
  • Mark Andrews's avatar
    remove unused variable · 5f6b5492
    Mark Andrews authored
    (cherry picked from commit 7af9883b)
    5f6b5492
  • Mark Andrews's avatar
    Typedef my_bool if missing. · 3387fa03
    Mark Andrews authored
    ORACLE MySQL 8.0 has dropped the my_bool type, so we need to reinstate
    it back when compiling with that version or higher.  MariaDB is still
    keeping the my_bool type.  The numbering between the two (MariaDB 5.x
    jumped to MariaDB 10.x) doesn't make the life of the developer easy.
    
    (cherry picked from commit c6d5d5c8)
    3387fa03
  • Ondřej Surý's avatar
    Use compound literals in mysql_options() call · 2f3272ef
    Ondřej Surý authored
    Makes use of compound literals instead of using extra my_bool
    variable just to hold "true/1" value.
    
    (cherry picked from commit 715b7a7c)
    2f3272ef
  • Mark Andrews's avatar
    Merge branch... · a5ec7f9c
    Mark Andrews authored
    Merge branch '1678-bind-fails-to-build-with-mysql-support-against-mysql8-mysql-connector-8-v9_16' into 'v9_16'
    
    Resolve "BIND fails to build with MYSQL support against mysql8/mysql-connector-8"
    
    See merge request !3305
    a5ec7f9c
......@@ -62,6 +62,10 @@
#include <dlz/sdlz_helper.h>
#include <named/globals.h>
#if !defined(LIBMARIADB) && MYSQL_VERSION_ID >= 80000
typedef bool my_bool;
#endif /* !defined(LIBMARIADB) && MYSQL_VERSION_ID >= 80000 */
static dns_sdlzimplementation_t *dlz_mysql = NULL;
#define dbc_search_limit 30
......@@ -759,9 +763,6 @@ mysql_create(const char *dlzname, unsigned int argc, char *argv[],
char *endp;
int j;
unsigned int flags = 0;
#if MYSQL_VERSION_ID >= 50000
my_bool auto_reconnect = 1;
#endif /* if MYSQL_VERSION_ID >= 50000 */
UNUSED(driverarg);
UNUSED(dlzname);
......@@ -897,21 +898,21 @@ mysql_create(const char *dlzname, unsigned int argc, char *argv[],
pass = getParameterValue(argv[1], "pass=");
socket = getParameterValue(argv[1], "socket=");
#if MYSQL_VERSION_ID >= 50000
/* enable automatic reconnection. */
if (mysql_options((MYSQL *)dbi->dbconn, MYSQL_OPT_RECONNECT,
&auto_reconnect) != 0)
&(my_bool){ 1 }) != 0)
{
isc_log_write(dns_lctx, DNS_LOGCATEGORY_DATABASE,
DNS_LOGMODULE_DLZ, ISC_LOG_WARNING,
"mysql driver failed to set "
"MYSQL_OPT_RECONNECT option, continuing");
"MYSQL_OPT_RECONNECT option, "
"continuing");
}
#endif /* if MYSQL_VERSION_ID >= 50000 */
for (j = 0; dbc == NULL && j < 4; j++)
for (j = 0; dbc == NULL && j < 4; j++) {
dbc = mysql_real_connect((MYSQL *)dbi->dbconn, host, user, pass,
dbname, port, socket, flags);
}
/* let user know if we couldn't connect. */
if (dbc == NULL) {
......
......@@ -59,6 +59,10 @@
#include <dlz_minimal.h>
#include <dlz_pthread.h>
#if !defined(LIBMARIADB) && MYSQL_VERSION_ID >= 80000
typedef bool my_bool;
#endif /* !defined(LIBMARIADB) && MYSQL_VERSION_ID >= 80000 */
#define dbc_search_limit 30
#define ALLNODES 1
#define ALLOWXFR 2
......@@ -812,9 +816,6 @@ dlz_create(const char *dlzname, unsigned int argc, char *argv[], void **dbdata,
char *endp;
int j;
const char *helper_name;
#if MYSQL_VERSION_ID >= 50000
my_bool auto_reconnect = 1;
#endif /* if MYSQL_VERSION_ID >= 50000 */
#if PTHREADS
int dbcount;
int i;
......@@ -1012,17 +1013,15 @@ dlz_create(const char *dlzname, unsigned int argc, char *argv[], void **dbdata,
dbc = NULL;
#if MYSQL_VERSION_ID >= 50000
/* enable automatic reconnection. */
if (mysql_options((MYSQL *)dbi->dbconn, MYSQL_OPT_RECONNECT,
&auto_reconnect) != 0)
&(my_bool){ 1 }) != 0)
{
mysql->log(ISC_LOG_WARNING, "MySQL module failed to "
"set "
"MYSQL_OPT_RECONNECT "
"option, continuing");
}
#endif /* if MYSQL_VERSION_ID >= 50000 */
for (j = 0; dbc == NULL && j < 4; j++) {
dbc = mysql_real_connect(
......
......@@ -61,6 +61,10 @@
#include <dlz_minimal.h>
#include <dlz_pthread.h>
#if !defined(LIBMARIADB) && MYSQL_VERSION_ID >= 80000
typedef bool my_bool;
#endif /* !defined(LIBMARIADB) && MYSQL_VERSION_ID >= 80000 */
/*
* The SQL queries that will be used for lookups and updates are defined
* here. They will be processed into queries by the build_query()
......@@ -1020,7 +1024,6 @@ dlz_create(const char *dlzname, unsigned int argc, char *argv[], void **dbdata,
*/
if (mysql_thread_safe()) {
for (n = 0; n < MAX_DBI; n++) {
my_bool opt = 1;
dlz_mutex_init(&state->db[n].mutex, NULL);
dlz_mutex_lock(&state->db[n].mutex);
state->db[n].id = n;
......@@ -1029,7 +1032,7 @@ dlz_create(const char *dlzname, unsigned int argc, char *argv[], void **dbdata,
mysql_options(state->db[n].sock,
MYSQL_READ_DEFAULT_GROUP, modname);
mysql_options(state->db[n].sock, MYSQL_OPT_RECONNECT,
&opt);
&(my_bool){ 1 });
dlz_mutex_unlock(&state->db[n].mutex);
}
......
......@@ -887,9 +887,6 @@ dlz_create(const char *dlzname, unsigned int argc, char *argv[], void **dbdata,
char *tmp = NULL;
char *endp;
const char *helper_name;
#if SQLITE3_VERSION_ID >= 50000
my_bool auto_reconnect = 1;
#endif /* if SQLITE3_VERSION_ID >= 50000 */
#if PTHREADS
int dbcount;
int i, ret;
......