BIND issues
https://gitlab.isc.org/isc-projects/bind9/-/issues
2019-11-26T12:17:02Z
https://gitlab.isc.org/isc-projects/bind9/-/issues/1360
ThreadSanitizer: data race adb.c:2790 in dns_adb_detach
2019-11-26T12:17:02Z
Ondřej Surý
ThreadSanitizer: data race adb.c:2790 in dns_adb_detach
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 4 at 0x7b6400011410 by thread T6:
#0 dns_adb_detach adb.c:2790 (libdns.1503.dy...
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 4 at 0x7b6400011410 by thread T6:
#0 dns_adb_detach adb.c:2790 (libdns.1503.dylib:x86_64+0x9fda)
#1 fctx_destroy resolver.c:4400 (libdns.1503.dylib:x86_64+0x1302bf)
#2 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#3 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 4 at 0x7b6400011410 by thread T8 (mutexes: write M55586239839015768):
#0 dns_adb_detach adb.c:2793 (libdns.1503.dylib:x86_64+0xa007)
#1 fctx_destroy resolver.c:4400 (libdns.1503.dylib:x86_64+0x1302bf)
#2 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#3 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 1025 at 0x7b6400011300 allocated by thread T5:
#0 malloc <null>:6892352 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_view_createresolver view.c:778 (libdns.1503.dylib:x86_64+0x18bd72)
#3 configure_view server.c:4552 (named:x86_64+0x100027d3f)
#4 load_configuration server.c:8916 (named:x86_64+0x100021275)
#5 run_server server.c:9638 (named:x86_64+0x10000de29)
#6 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M55586239839015768 is already destroyed.
Thread T6 (tid=4654359, running) created by main thread at:
#0 pthread_create <null>:6892400 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T8 (tid=4654361, running) created by main thread at:
#0 pthread_create <null>:6892400 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:6892304 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race adb.c:2790 in dns_adb_detach
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1359
ThreadSanitizer: data race rbtdb.c:4472 in find_deepest_zonecut
2019-11-22T00:20:05Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:4472 in find_deepest_zonecut
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0, c9e358fbf5f5ad6c833b5be21f8afcf02b939c80
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 2 at 0x7b2000027ce8 by thread T1:
#0...
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0, c9e358fbf5f5ad6c833b5be21f8afcf02b939c80
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 2 at 0x7b2000027ce8 by thread T1:
#0 find_deepest_zonecut rbtdb.c:4472 (libdns.1503.dylib:x86_64+0xc9416)
#1 cache_find rbtdb.c:4738 (libdns.1503.dylib:x86_64+0xb5f48)
#2 dns_db_findext db.c:551 (libdns.1503.dylib:x86_64+0x2b74e)
#3 query_lookup query.c:5515 (libns.1501.dylib:x86_64+0x1350e)
#4 ns__query_start query.c:5441 (libns.1501.dylib:x86_64+0x1146c)
#5 ns_query_start query.c:5162 (libns.1501.dylib:x86_64+0x172c8)
#6 ns__client_request client.c:2152 (libns.1501.dylib:x86_64+0x66a2)
#7 dnslisten_readcb tcpdns.c:185 (libisc.1503.dylib:x86_64+0x209b9)
#8 read_cb tcp.c:346 (libisc.1503.dylib:x86_64+0x1d15f)
#9 uv__stream_io <null>:1541328 (libuv.1.dylib:x86_64+0xeda1)
Previous write of size 2 at 0x7b2000027ce8 by thread T7:
#0 decrement_reference rbtdb.c:1603 (libdns.1503.dylib:x86_64+0xc32a1)
#1 detachnode rbtdb.c:5197 (libdns.1503.dylib:x86_64+0xb7024)
#2 rdataset_disassociate rbtdb.c:8377 (libdns.1503.dylib:x86_64+0xc0330)
#3 dns_rdataset_disassociate rdataset.c:118 (libdns.1503.dylib:x86_64+0x120089)
#4 fctx_destroy resolver.c:4395 (libdns.1503.dylib:x86_64+0x130251)
#5 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#6 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 124 at 0x7b2000027c80 allocated by thread T6:
#0 malloc <null>:1541360 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_rbt_addnode rbt.c:1382 (libdns.1503.dylib:x86_64+0xa9d06)
#3 findnodeintree rbtdb.c:2739 (libdns.1503.dylib:x86_64+0xc896a)
#4 findnode rbtdb.c:2784 (libdns.1503.dylib:x86_64+0xb532b)
#5 dns_db_findnode db.c:447 (libdns.1503.dylib:x86_64+0x2b158)
#6 resquery_response resolver.c:6018 (libdns.1503.dylib:x86_64+0x141e7a)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Thread T1 (tid=4654354, running) created by main thread at:
#0 pthread_create <null>:1541408 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:895 (named:x86_64+0x10000acbe)
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:1541408 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T6 (tid=4654359, running) created by main thread at:
#0 pthread_create <null>:1541312 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:4472 in find_deepest_zonecut
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1358
ThreadSanitizer: data race rbtdb.c:905 in ttl_sooner
2019-11-26T17:25:53Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:905 in ttl_sooner
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 4 at 0x7b2c00015934 by thread T6:
#0 ttl_sooner rbtdb.c:905 (libdns.1503.dylib...
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 4 at 0x7b2c00015934 by thread T6:
#0 ttl_sooner rbtdb.c:905 (libdns.1503.dylib:x86_64+0xb183e)
#1 isc_heap_delete heap.c:229 (libisc.1503.dylib:x86_64+0x94cf)
#2 decrement_reference rbtdb.c:1572 (libdns.1503.dylib:x86_64+0xc31dc)
#3 detachnode rbtdb.c:5197 (libdns.1503.dylib:x86_64+0xb7024)
#4 rdataset_disassociate rbtdb.c:8377 (libdns.1503.dylib:x86_64+0xc0330)
#5 dns_rdataset_disassociate rdataset.c:118 (libdns.1503.dylib:x86_64+0x120089)
#6 fctx_destroy resolver.c:4395 (libdns.1503.dylib:x86_64+0x130251)
#7 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#8 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 4 at 0x7b2c00015934 by thread T7 (mutexes: write M1037934011638359720):
#0 addrdataset rbtdb.c:876 (libdns.1503.dylib:x86_64+0xb8d07)
#1 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#2 validated resolver.c:5627 (libdns.1503.dylib:x86_64+0x14b277)
#3 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 167 at 0x7b2c00015920 allocated by thread T7:
#0 malloc <null>:6890784 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 addrdataset rbtdb.c:6450 (libdns.1503.dylib:x86_64+0xb88d4)
#3 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#4 validated resolver.c:5627 (libdns.1503.dylib:x86_64+0x14b277)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M1037934011638359720 is already destroyed.
Thread T6 (tid=4654359, running) created by main thread at:
#0 pthread_create <null>:6890832 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:6890832 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:905 in ttl_sooner
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
Ondřej Surý
Ondřej Surý
https://gitlab.isc.org/isc-projects/bind9/-/issues/1357
ThreadSanitizer: data race rbtdb.c:925 in set_index
2019-11-26T17:26:01Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:925 in set_index
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 4 at 0x7b5800031e70 by thread T6:
#0 set_index rbtdb.c:925 (libdns.1503.dylib...
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 4 at 0x7b5800031e70 by thread T6:
#0 set_index rbtdb.c:925 (libdns.1503.dylib:x86_64+0xb190e)
#1 isc_heap_delete heap.c:219 (libisc.1503.dylib:x86_64+0x948f)
#2 decrement_reference rbtdb.c:1572 (libdns.1503.dylib:x86_64+0xc31dc)
#3 detachnode rbtdb.c:5197 (libdns.1503.dylib:x86_64+0xb7024)
#4 rdataset_disassociate rbtdb.c:8377 (libdns.1503.dylib:x86_64+0xc0330)
#5 dns_rdataset_disassociate rdataset.c:118 (libdns.1503.dylib:x86_64+0x120089)
#6 fctx_destroy resolver.c:4395 (libdns.1503.dylib:x86_64+0x130251)
#7 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#8 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous read of size 4 at 0x7b5800031e70 by thread T7 (mutexes: write M1037934011638359720):
#0 expire_header rbtdb.c:883 (libdns.1503.dylib:x86_64+0xc2857)
#1 addrdataset rbtdb.c:6568 (libdns.1503.dylib:x86_64+0xb9976)
#2 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#3 validated resolver.c:5627 (libdns.1503.dylib:x86_64+0x14b277)
#4 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 723 at 0x7b5800031e00 allocated by thread T6:
#0 malloc <null>:6890784 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 addrdataset rbtdb.c:6450 (libdns.1503.dylib:x86_64+0xb88d4)
#3 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#4 validated resolver.c:5638 (libdns.1503.dylib:x86_64+0x14b31e)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M1037934011638359720 is already destroyed.
Thread T6 (tid=4654359, running) created by main thread at:
#0 pthread_create <null>:6890832 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:6890832 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:925 in set_index
```
a slightly different variant, but same location:
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 4 at 0x7b2c00015990 by thread T6:
#0 set_index rbtdb.c:925 (libdns.1503.dylib:x86_64+0xb190e)
#1 sink_down heap.c:185 (libisc.1503.dylib:x86_64+0x960d)
#2 decrement_reference rbtdb.c:1572 (libdns.1503.dylib:x86_64+0xc31dc)
#3 detachnode rbtdb.c:5197 (libdns.1503.dylib:x86_64+0xb7024)
#4 rdataset_disassociate rbtdb.c:8377 (libdns.1503.dylib:x86_64+0xc0330)
#5 dns_rdataset_disassociate rdataset.c:118 (libdns.1503.dylib:x86_64+0x120089)
#6 fctx_destroy resolver.c:4395 (libdns.1503.dylib:x86_64+0x130251)
#7 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#8 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 4 at 0x7b2c00015990 by thread T7 (mutexes: write M1037934011638359720):
#0 set_index rbtdb.c:925 (libdns.1503.dylib:x86_64+0xb190e)
#1 float_up heap.c:159 (libisc.1503.dylib:x86_64+0x93f0)
#2 addrdataset rbtdb.c:6599 (libdns.1503.dylib:x86_64+0xb9abc)
#3 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#4 validated resolver.c:5627 (libdns.1503.dylib:x86_64+0x14b277)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 167 at 0x7b2c00015920 allocated by thread T7:
#0 malloc <null>:6890768 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 addrdataset rbtdb.c:6450 (libdns.1503.dylib:x86_64+0xb88d4)
#3 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#4 validated resolver.c:5627 (libdns.1503.dylib:x86_64+0x14b277)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M1037934011638359720 is already destroyed.
Thread T6 (tid=4654359, running) created by main thread at:
#0 pthread_create <null>:6890816 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:6890816 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:925 in set_index
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1356
ThreadSanitizer: data race rbtdb.c:1463 in free_rdataset
2019-11-26T17:26:19Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:1463 in free_rdataset
Binary: `named`
Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 8 at 0x7b440003b650 by thread T6:
#0 free_rdataset rbtdb.c:1463 (libdns.1503.dylib:x...
Binary: `named`
Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 8 at 0x7b440003b650 by thread T6:
#0 free_rdataset rbtdb.c:1463 (libdns.1503.dylib:x86_64+0xbf956)
#1 decrement_reference rbtdb.c:1572 (libdns.1503.dylib:x86_64+0xc31dc)
#2 detachnode rbtdb.c:5197 (libdns.1503.dylib:x86_64+0xb7024)
#3 rdataset_disassociate rbtdb.c:8377 (libdns.1503.dylib:x86_64+0xc0330)
#4 dns_rdataset_disassociate rdataset.c:118 (libdns.1503.dylib:x86_64+0x120089)
#5 fctx_destroy resolver.c:4395 (libdns.1503.dylib:x86_64+0x130251)
#6 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 8 at 0x7b440003b650 by thread T7 (mutexes: write M1037934011638359720):
#0 add32 rbtdb.c:6237 (libdns.1503.dylib:x86_64+0xbd6af)
#1 addrdataset rbtdb.c:6599 (libdns.1503.dylib:x86_64+0xb9abc)
#2 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#3 validated resolver.c:5627 (libdns.1503.dylib:x86_64+0x14b277)
#4 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 273 at 0x7b440003b600 allocated by thread T5:
#0 malloc <null>:6890864 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_db_create db.c:118 (libdns.1503.dylib:x86_64+0x2a09c)
#3 dns_cache_create cache.c:173 (libdns.1503.dylib:x86_64+0x1c5d0)
#4 configure_view server.c:4484 (named:x86_64+0x1000279cf)
#5 load_configuration server.c:8916 (named:x86_64+0x100021275)
#6 run_server server.c:9638 (named:x86_64+0x10000de29)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M1037934011638359720 is already destroyed.
Thread T6 (tid=4654359, running) created by main thread at:
#0 pthread_create <null>:6890912 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:6890912 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:6890816 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:1463 in free_rdataset
```
Perhaps this could be a culprit for #1263?
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1355
ThreadSanitizer: data race rbtdb.c:6279 in add32
2019-11-26T17:26:22Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:6279 in add32
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 8 at 0x7b200001e9e0 by thread T5 (mutexes: write M1026675012569932440):
#0 ad...
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 8 at 0x7b200001e9e0 by thread T5 (mutexes: write M1026675012569932440):
#0 add32 rbtdb.c:6279 (libdns.1503.dylib:x86_64+0xbd702)
#1 addrdataset rbtdb.c:6599 (libdns.1503.dylib:x86_64+0xb9abc)
#2 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#3 validated resolver.c:5710 (libdns.1503.dylib:x86_64+0x14b790)
#4 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous read of size 8 at 0x7b200001e9e0 by thread T8:
#0 decrement_reference rbtdb.c:1960 (libdns.1503.dylib:x86_64+0xc2bf9)
#1 detachnode rbtdb.c:5197 (libdns.1503.dylib:x86_64+0xb7024)
#2 rdataset_disassociate rbtdb.c:8377 (libdns.1503.dylib:x86_64+0xc0330)
#3 dns_rdataset_disassociate rdataset.c:118 (libdns.1503.dylib:x86_64+0x120089)
#4 fctx_destroy resolver.c:4395 (libdns.1503.dylib:x86_64+0x130251)
#5 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#6 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 121 at 0x7b200001e980 allocated by thread T5:
#0 malloc <null>:5829376 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_rbt_addnode rbt.c:1382 (libdns.1503.dylib:x86_64+0xa9d06)
#3 findnodeintree rbtdb.c:2739 (libdns.1503.dylib:x86_64+0xc896a)
#4 findnode rbtdb.c:2784 (libdns.1503.dylib:x86_64+0xb532b)
#5 dns_db_findnode db.c:447 (libdns.1503.dylib:x86_64+0x2b158)
#6 resquery_response resolver.c:6018 (libdns.1503.dylib:x86_64+0x141e7a)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M1026675012569932440 is already destroyed.
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:5829424 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T8 (tid=4654361, running) created by main thread at:
#0 pthread_create <null>:5829424 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:6279 in add32
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1354
ThreadSanitizer: data race message.c:3283 in dns_message_sectiontotext
2019-11-26T13:00:04Z
Ondřej Surý
ThreadSanitizer: data race message.c:3283 in dns_message_sectiontotext
* Binary: `named`
* Commit: `c5b6f21515d44c997aa4aa259d2e0653a843fba0`
* Tests: autosign, cacheclean, checknames, fetchlimit, forward
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 4 at 0x0001093a6698 by thread T5:
...
* Binary: `named`
* Commit: `c5b6f21515d44c997aa4aa259d2e0653a843fba0`
* Tests: autosign, cacheclean, checknames, fetchlimit, forward
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 4 at 0x0001093a6698 by thread T5:
#0 dns_message_sectiontotext message.c:3283 (libdns.1503.dylib:x86_64+0x7be45)
#1 dns_message_totext message.c:4266 (libdns.1503.dylib:x86_64+0x8d835)
#2 logfmtpacket message.c:4401 (libdns.1503.dylib:x86_64+0x8dee6)
#3 dns_message_logfmtpacket message.c:4367 (libdns.1503.dylib:x86_64+0x8dfed)
#4 resquery_send resolver.c:2764 (libdns.1503.dylib:x86_64+0x13dbbe)
#5 fctx_query resolver.c:2142 (libdns.1503.dylib:x86_64+0x13a003)
#6 fctx_try resolver.c:4129 (libdns.1503.dylib:x86_64+0x136b61)
#7 rctx_done resolver.c:9397 (libdns.1503.dylib:x86_64+0x144328)
#8 resquery_response resolver.c (libdns.1503.dylib:x86_64+0x13ece7)
#9 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 4 at 0x0001093a6698 by thread T7:
#0 dns_message_sectiontotext message.c:3366 (libdns.1503.dylib:x86_64+0x7cb17)
#1 dns_message_totext message.c:4266 (libdns.1503.dylib:x86_64+0x8d835)
#2 logfmtpacket message.c:4401 (libdns.1503.dylib:x86_64+0x8dee6)
#3 dns_message_logfmtpacket message.c:4367 (libdns.1503.dylib:x86_64+0x8dfed)
#4 resquery_send resolver.c:2764 (libdns.1503.dylib:x86_64+0x13dbbe)
#5 fctx_query resolver.c:2142 (libdns.1503.dylib:x86_64+0x13a003)
#6 fctx_try resolver.c:4129 (libdns.1503.dylib:x86_64+0x136b61)
#7 fctx_start resolver.c:4647 (libdns.1503.dylib:x86_64+0x12f383)
#8 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is global 'dns_master_indent' at 0x0001093a6698 (libdns.1503.dylib+0x000000251698)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:5820288 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:5820288 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race message.c:3283 in dns_message_sectiontotext
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
Mark Andrews
Mark Andrews
https://gitlab.isc.org/isc-projects/bind9/-/issues/1353
ThreadSanitizer: data race rbtdb.c in update_header
2019-11-28T18:33:07Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c in update_header
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 8 at 0x7b4c00003160 by thread T7 (mutexes: write M290055290576030928):
#0 upd...
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 8 at 0x7b4c00003160 by thread T7 (mutexes: write M290055290576030928):
#0 update_header rbtdb.c (libdns.1503.dylib:x86_64+0xc9fe5)
#1 find_deepest_zonecut rbtdb.c:4558 (libdns.1503.dylib:x86_64+0xc9886)
#2 cache_find rbtdb.c:4738 (libdns.1503.dylib:x86_64+0xb5f48)
#3 dns_db_find db.c:511 (libdns.1503.dylib:x86_64+0x2b4df)
#4 dns_view_find view.c:1019 (libdns.1503.dylib:x86_64+0x18cb59)
#5 dbfind_name adb.c:3658 (libdns.1503.dylib:x86_64+0xd8e3)
#6 dns_adb_createfind adb.c:3083 (libdns.1503.dylib:x86_64+0xc163)
#7 findname resolver.c:3371 (libdns.1503.dylib:x86_64+0x13ae8b)
#8 fctx_try resolver.c:3660 (libdns.1503.dylib:x86_64+0x136402)
#9 fctx_start resolver.c:4647 (libdns.1503.dylib:x86_64+0x12f383)
#10 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 8 at 0x7b4c00003160 by thread T5:
#0 update_header rbtdb.c (libdns.1503.dylib:x86_64+0xc9fe5)
#1 cache_findzonecut rbtdb.c:5146 (libdns.1503.dylib:x86_64+0xb6cb7)
#2 dns_db_findzonecut db.c:577 (libdns.1503.dylib:x86_64+0x2b900)
#3 dns_view_findzonecut view.c:1309 (libdns.1503.dylib:x86_64+0x18d4be)
#4 rctx_done resolver.c:9348 (libdns.1503.dylib:x86_64+0x1443e8)
#5 resquery_response resolver.c (libdns.1503.dylib:x86_64+0x13ece7)
#6 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 447 at 0x7b4c00003100 allocated by thread T5:
#0 malloc <null>:7941664 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 addrdataset rbtdb.c:6450 (libdns.1503.dylib:x86_64+0xb88d4)
#3 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#4 resquery_response resolver.c:6226 (libdns.1503.dylib:x86_64+0x1426c0)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M290055290576030928 is already destroyed.
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:7941712 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:7941712 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c in update_header
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1352
ThreadSanitizer: data race rbtdb.c:{10066,10068,10069,10070} in update_header
2019-11-28T18:33:08Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:{10066,10068,10069,10070} in update_header
* Binary: `named`
* Commit: `c5b6f21515d44c997aa4aa259d2e0653a843fba0`
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 8 at 0x7b30000115e0 by thread T7 (mutexes: write M290055290576030928):
#0 up...
* Binary: `named`
* Commit: `c5b6f21515d44c997aa4aa259d2e0653a843fba0`
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 8 at 0x7b30000115e0 by thread T7 (mutexes: write M290055290576030928):
#0 update_header rbtdb.c:10066 (libdns.1503.dylib:x86_64+0xc9f52)
#1 find_deepest_zonecut rbtdb.c:4558 (libdns.1503.dylib:x86_64+0xc9886)
#2 cache_find rbtdb.c:4738 (libdns.1503.dylib:x86_64+0xb5f48)
#3 dns_db_find db.c:511 (libdns.1503.dylib:x86_64+0x2b4df)
#4 dns_view_find view.c:1019 (libdns.1503.dylib:x86_64+0x18cb59)
#5 dbfind_name adb.c:3658 (libdns.1503.dylib:x86_64+0xd8e3)
#6 dns_adb_createfind adb.c:3083 (libdns.1503.dylib:x86_64+0xc163)
#7 findname resolver.c:3371 (libdns.1503.dylib:x86_64+0x13ae8b)
#8 fctx_try resolver.c:3660 (libdns.1503.dylib:x86_64+0x136402)
#9 fctx_start resolver.c:4647 (libdns.1503.dylib:x86_64+0x12f383)
#10 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 8 at 0x7b30000115e0 by thread T5:
#0 update_header rbtdb.c:10068 (libdns.1503.dylib:x86_64+0xca06e)
#1 cache_findzonecut rbtdb.c:5146 (libdns.1503.dylib:x86_64+0xb6cb7)
#2 dns_db_findzonecut db.c:577 (libdns.1503.dylib:x86_64+0x2b900)
#3 dns_view_findzonecut view.c:1309 (libdns.1503.dylib:x86_64+0x18d4be)
#4 rctx_done resolver.c:9348 (libdns.1503.dylib:x86_64+0x1443e8)
#5 resquery_response resolver.c (libdns.1503.dylib:x86_64+0x13ece7)
#6 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 183 at 0x7b3000011580 allocated by thread T5:
#0 malloc <null>:7941664 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 addrdataset rbtdb.c:6450 (libdns.1503.dylib:x86_64+0xb88d4)
#3 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#4 resquery_response resolver.c:6341 (libdns.1503.dylib:x86_64+0x1424a7)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M290055290576030928 is already destroyed.
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:7941712 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:7941712 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:10066 in update_header
```
And same memory block, just different location:
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 8 at 0x7b30000115e8 by thread T7 (mutexes: write M290055290576030928):
#0 update_header rbtdb.c:10068 (libdns.1503.dylib:x86_64+0xc9f6d)
#1 find_deepest_zonecut rbtdb.c:4558 (libdns.1503.dylib:x86_64+0xc9886)
#2 cache_find rbtdb.c:4738 (libdns.1503.dylib:x86_64+0xb5f48)
#3 dns_db_find db.c:511 (libdns.1503.dylib:x86_64+0x2b4df)
#4 dns_view_find view.c:1019 (libdns.1503.dylib:x86_64+0x18cb59)
#5 dbfind_name adb.c:3658 (libdns.1503.dylib:x86_64+0xd8e3)
#6 dns_adb_createfind adb.c:3083 (libdns.1503.dylib:x86_64+0xc163)
#7 findname resolver.c:3371 (libdns.1503.dylib:x86_64+0x13ae8b)
#8 fctx_try resolver.c:3660 (libdns.1503.dylib:x86_64+0x136402)
#9 fctx_start resolver.c:4647 (libdns.1503.dylib:x86_64+0x12f383)
#10 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 8 at 0x7b30000115e8 by thread T5:
#0 update_header rbtdb.c:10068 (libdns.1503.dylib:x86_64+0xca06e)
#1 cache_findzonecut rbtdb.c:5146 (libdns.1503.dylib:x86_64+0xb6cb7)
#2 dns_db_findzonecut db.c:577 (libdns.1503.dylib:x86_64+0x2b900)
#3 dns_view_findzonecut view.c:1309 (libdns.1503.dylib:x86_64+0x18d4be)
#4 rctx_done resolver.c:9348 (libdns.1503.dylib:x86_64+0x1443e8)
#5 resquery_response resolver.c (libdns.1503.dylib:x86_64+0x13ece7)
#6 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 183 at 0x7b3000011580 allocated by thread T5:
#0 malloc <null>:7941664 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 addrdataset rbtdb.c:6450 (libdns.1503.dylib:x86_64+0xb88d4)
#3 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#4 resquery_response resolver.c:6341 (libdns.1503.dylib:x86_64+0x1424a7)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M290055290576030928 is already destroyed.
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:7941712 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:7941712 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:10068 in update_header
```
One more:
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 4 at 0x7b30000115d8 by thread T7 (mutexes: write M290055290576030928):
#0 update_header rbtdb.c:10069 (libdns.1503.dylib:x86_64+0xca0f1)
#1 find_deepest_zonecut rbtdb.c:4558 (libdns.1503.dylib:x86_64+0xc9886)
#2 cache_find rbtdb.c:4738 (libdns.1503.dylib:x86_64+0xb5f48)
#3 dns_db_find db.c:511 (libdns.1503.dylib:x86_64+0x2b4df)
#4 dns_view_find view.c:1019 (libdns.1503.dylib:x86_64+0x18cb59)
#5 dbfind_name adb.c:3658 (libdns.1503.dylib:x86_64+0xd8e3)
#6 dns_adb_createfind adb.c:3083 (libdns.1503.dylib:x86_64+0xc163)
#7 findname resolver.c:3371 (libdns.1503.dylib:x86_64+0x13ae8b)
#8 fctx_try resolver.c:3660 (libdns.1503.dylib:x86_64+0x136402)
#9 fctx_start resolver.c:4647 (libdns.1503.dylib:x86_64+0x12f383)
#10 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 4 at 0x7b30000115d8 by thread T5:
#0 update_header rbtdb.c:10069 (libdns.1503.dylib:x86_64+0xca0f1)
#1 cache_findzonecut rbtdb.c:5146 (libdns.1503.dylib:x86_64+0xb6cb7)
#2 dns_db_findzonecut db.c:577 (libdns.1503.dylib:x86_64+0x2b900)
#3 dns_view_findzonecut view.c:1309 (libdns.1503.dylib:x86_64+0x18d4be)
#4 rctx_done resolver.c:9348 (libdns.1503.dylib:x86_64+0x1443e8)
#5 resquery_response resolver.c (libdns.1503.dylib:x86_64+0x13ece7)
#6 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 183 at 0x7b3000011580 allocated by thread T5:
#0 malloc <null>:7941664 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 addrdataset rbtdb.c:6450 (libdns.1503.dylib:x86_64+0xb88d4)
#3 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#4 resquery_response resolver.c:6341 (libdns.1503.dylib:x86_64+0x1424a7)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M290055290576030928 is already destroyed.
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:7941712 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:7941712 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:10069 in update_header
```
and from a different location (seems like `rdatasetheader_t *header` is unlocked and it should be):
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 8 at 0x7b440003b610 by thread T1:
#0 update_header rbtdb.c:10070 (libdns.1503.dylib:x86_64+0xca1c7)
#1 find_deepest_zonecut rbtdb.c:4558 (libdns.1503.dylib:x86_64+0xc9886)
#2 cache_find rbtdb.c:4738 (libdns.1503.dylib:x86_64+0xb5f48)
#3 dns_db_findext db.c:551 (libdns.1503.dylib:x86_64+0x2b74e)
#4 query_lookup query.c:5515 (libns.1501.dylib:x86_64+0x1350e)
#5 ns__query_start query.c:5441 (libns.1501.dylib:x86_64+0x1146c)
#6 ns_query_start query.c:5162 (libns.1501.dylib:x86_64+0x172c8)
#7 ns__client_request client.c:2152 (libns.1501.dylib:x86_64+0x66a2)
#8 dnslisten_readcb tcpdns.c:185 (libisc.1503.dylib:x86_64+0x209b9)
#9 read_cb tcp.c:346 (libisc.1503.dylib:x86_64+0x1d15f)
#10 uv__stream_io <null>:1541232 (libuv.1.dylib:x86_64+0xeda1)
Previous read of size 8 at 0x7b440003b610 by thread T7:
#0 free_rdataset rbtdb.c:1463 (libdns.1503.dylib:x86_64+0xbf956)
#1 decrement_reference rbtdb.c:1572 (libdns.1503.dylib:x86_64+0xc31dc)
#2 detachnode rbtdb.c:5197 (libdns.1503.dylib:x86_64+0xb7024)
#3 rdataset_disassociate rbtdb.c:8377 (libdns.1503.dylib:x86_64+0xc0330)
#4 dns_rdataset_disassociate rdataset.c:118 (libdns.1503.dylib:x86_64+0x120089)
#5 fctx_destroy resolver.c:4395 (libdns.1503.dylib:x86_64+0x130251)
#6 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 273 at 0x7b440003b600 allocated by thread T5:
#0 malloc <null>:1541264 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_db_create db.c:118 (libdns.1503.dylib:x86_64+0x2a09c)
#3 dns_cache_create cache.c:173 (libdns.1503.dylib:x86_64+0x1c5d0)
#4 configure_view server.c:4484 (named:x86_64+0x1000279cf)
#5 load_configuration server.c:8916 (named:x86_64+0x100021275)
#6 run_server server.c:9638 (named:x86_64+0x10000de29)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Thread T1 (tid=4654354, running) created by main thread at:
#0 pthread_create <null>:1541312 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:895 (named:x86_64+0x10000acbe)
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:1541312 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:1541216 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:10070 in update_header
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1351
ThreadSanitizer: data race rbtdb.c:1960 in decrement_reference
2019-11-26T17:26:40Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:1960 in decrement_reference
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 8 at 0x7b200001bbc8 by thread T6 (mutexes: write M1014290113594662432):
#0 dec...
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0
* Tests: autosign
```
WARNING: ThreadSanitizer: data race (pid=45980)
Read of size 8 at 0x7b200001bbc8 by thread T6 (mutexes: write M1014290113594662432):
#0 decrement_reference rbtdb.c:1960 (libdns.1503.dylib:x86_64+0xc2c09)
#1 detachnode rbtdb.c:5197 (libdns.1503.dylib:x86_64+0xb7024)
#2 dns_db_detachnode db.c:606 (libdns.1503.dylib:x86_64+0x2bad0)
#3 resquery_response resolver.c:6410 (libdns.1503.dylib:x86_64+0x142c04)
#4 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 8 at 0x7b200001bbc8 by thread T5 (mutexes: write M1035682211824674264):
#0 dns_rbt_addnode rbt.c (libdns.1503.dylib:x86_64+0xaa632)
#1 findnodeintree rbtdb.c:2739 (libdns.1503.dylib:x86_64+0xc896a)
#2 findnode rbtdb.c:2784 (libdns.1503.dylib:x86_64+0xb532b)
#3 dns_db_findnode db.c:447 (libdns.1503.dylib:x86_64+0x2b158)
#4 resquery_response resolver.c:6629 (libdns.1503.dylib:x86_64+0x1432d4)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 116 at 0x7b200001bb80 allocated by thread T6:
#0 malloc <null>:6886992 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_rbt_addnode rbt.c:1274 (libdns.1503.dylib:x86_64+0xa98fa)
#3 findnodeintree rbtdb.c:2739 (libdns.1503.dylib:x86_64+0xc896a)
#4 findnode rbtdb.c:2784 (libdns.1503.dylib:x86_64+0xb532b)
#5 dns_db_findnode db.c:447 (libdns.1503.dylib:x86_64+0x2b158)
#6 resquery_response resolver.c:6018 (libdns.1503.dylib:x86_64+0x141e7a)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M1014290113594662432 is already destroyed.
Mutex M1035682211824674264 is already destroyed.
Thread T6 (tid=4654359, running) created by main thread at:
#0 pthread_create <null>:6887040 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:6887040 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:1960 in decrement_reference
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1350
ThreadSanitizer: data race rbt.c:1312 in dns_rbt_addnode
2019-11-28T00:10:55Z
Ondřej Surý
ThreadSanitizer: data race rbt.c:1312 in dns_rbt_addnode
Binary: `named`
Commit: d744a6fc238fc685411d8bc673c951cb80d6cb81
Tests: mkeys
```
WARNING: ThreadSanitizer: data race (pid=9284)
Write of size 4 at 0x7b2400019cf4 by thread T8 (mutexes: write M18726, write M18318):
#0 dns_rbt_addn...
Binary: `named`
Commit: d744a6fc238fc685411d8bc673c951cb80d6cb81
Tests: mkeys
```
WARNING: ThreadSanitizer: data race (pid=9284)
Write of size 4 at 0x7b2400019cf4 by thread T8 (mutexes: write M18726, write M18318):
#0 dns_rbt_addnode rbt.c:1312 (libdns.1505.dylib:x86_64+0xaabba)
#1 findnodeintree rbtdb.c:2738 (libdns.1505.dylib:x86_64+0xc965a)
#2 findnode rbtdb.c:2783 (libdns.1505.dylib:x86_64+0xb641b)
#3 dns_db_findnode db.c:447 (libdns.1505.dylib:x86_64+0x2bcd8)
#4 validated resolver.c:5501 (libdns.1505.dylib:x86_64+0x14b9c1)
#5 run task.c:1134 (libisc.1504.dylib:x86_64+0x3be51)
Previous read of size 4 at 0x7b2400019cf4 by thread T7 (mutexes: write M18786):
#0 addrdataset rbtdb.c:6524 (libdns.1505.dylib:x86_64+0xb9fe7)
#1 dns_db_addrdataset db.c:744 (libdns.1505.dylib:x86_64+0x2ce6e)
#2 addoptout ncache.c:271 (libdns.1505.dylib:x86_64+0x98317)
#3 dns_ncache_add ncache.c:101 (libdns.1505.dylib:x86_64+0x97abc)
#4 resquery_response resolver.c:6479 (libdns.1505.dylib:x86_64+0x144186)
#5 run task.c:1134 (libisc.1504.dylib:x86_64+0x3be51)
Location is heap block of size 138 at 0x7b2400019ce0 allocated by thread T7:
#0 malloc <null>:9010464 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1504.dylib:x86_64+0x21bbf)
#2 isc___mem_allocate mem.c:598 (libisc.1504.dylib:x86_64+0x22a1c)
#3 isc___mem_get mem.c:2387 (libisc.1504.dylib:x86_64+0x22037)
#4 isc__mem_get mem.c:2365 (libisc.1504.dylib:x86_64+0x1cd3e)
#5 create_node rbt.c:2189 (libdns.1505.dylib:x86_64+0xabcc5)
#6 dns_rbt_addnode rbt.c:1146 (libdns.1505.dylib:x86_64+0xab888)
#7 findnodeintree rbtdb.c:2738 (libdns.1505.dylib:x86_64+0xc965a)
#8 findnode rbtdb.c:2783 (libdns.1505.dylib:x86_64+0xb641b)
#9 dns_db_findnode db.c:447 (libdns.1505.dylib:x86_64+0x2bcd8)
#10 resquery_response resolver.c:6632 (libdns.1505.dylib:x86_64+0x144064)
#11 run task.c:1134 (libisc.1504.dylib:x86_64+0x3be51)
Mutex M18726 (0x7b7c00003030) created at:
#0 pthread_mutex_init <null>:9010320 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2b9a3)
#1 isc__mutex_init mutex.c:286 (libisc.1504.dylib:x86_64+0x58ca9)
#2 dns_resolver_create resolver.c:10030 (libdns.1505.dylib:x86_64+0x12b7b0)
#3 dns_view_createresolver view.c:763 (libdns.1505.dylib:x86_64+0x18ca48)
#4 configure_view server.c:4553 (named:x86_64+0x10002aebf)
#5 load_configuration server.c:8903 (named:x86_64+0x100023fa6)
#6 run_server server.c:9639 (named:x86_64+0x10001100d)
#7 run task.c:1134 (libisc.1504.dylib:x86_64+0x3be51)
Mutex M18318 (0x7b5c00012060) created at:
#0 pthread_rwlock_init <null>:9010320 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2bd21)
#1 isc_rwlock_init rwlock.c:41 (libisc.1504.dylib:x86_64+0x34ffb)
#2 dns_rbtdb_create rbtdb.c:8094 (libdns.1505.dylib:x86_64+0xb1960)
#3 dns_db_create db.c:118 (libdns.1505.dylib:x86_64+0x2ac1c)
#4 dns_cache_create cache.c:173 (libdns.1505.dylib:x86_64+0x1d150)
#5 configure_view server.c:4485 (named:x86_64+0x10002ab4f)
#6 load_configuration server.c:8903 (named:x86_64+0x100023fa6)
#7 run_server server.c:9639 (named:x86_64+0x10001100d)
#8 run task.c:1134 (libisc.1504.dylib:x86_64+0x3be51)
Mutex M18786 (0x7b7c00003648) created at:
#0 pthread_mutex_init <null>:9010320 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2b9a3)
#1 isc__mutex_init mutex.c:286 (libisc.1504.dylib:x86_64+0x58ca9)
#2 dns_resolver_create resolver.c:10030 (libdns.1505.dylib:x86_64+0x12b7b0)
#3 dns_view_createresolver view.c:763 (libdns.1505.dylib:x86_64+0x18ca48)
#4 configure_view server.c:4553 (named:x86_64+0x10002aebf)
#5 load_configuration server.c:8903 (named:x86_64+0x100023fa6)
#6 run_server server.c:9639 (named:x86_64+0x10001100d)
#7 run task.c:1134 (libisc.1504.dylib:x86_64+0x3be51)
Thread T8 (tid=2457582, running) created by main thread at:
#0 pthread_create <null>:9010512 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1504.dylib:x86_64+0x58db1)
#2 isc_taskmgr_create task.c:1410 (libisc.1504.dylib:x86_64+0x3b340)
#3 main main.c:902 (named:x86_64+0x10000df16)
Thread T7 (tid=2457581, running) created by main thread at:
#0 pthread_create <null>:9010512 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1504.dylib:x86_64+0x58db1)
#2 isc_taskmgr_create task.c:1410 (libisc.1504.dylib:x86_64+0x3b340)
#3 main main.c:902 (named:x86_64+0x10000df16)
SUMMARY: ThreadSanitizer: data race rbt.c:1312 in dns_rbt_addnode
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1349
ThreadSanitizer: data race rbt.c:1310 in dns_rbt_addnode
2019-11-26T17:26:47Z
Ondřej Surý
ThreadSanitizer: data race rbt.c:1310 in dns_rbt_addnode
Found in the ns3 log running `named` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the serve-stale system test:
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 8 at 0x7b1800005f60 by thread T6 (mutexes: wr...
Found in the ns3 log running `named` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the serve-stale system test:
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 8 at 0x7b1800005f60 by thread T6 (mutexes: write M1014290113594662432):
#0 dns_rbt_addnode rbt.c:1310 (libdns.1503.dylib:x86_64+0xa9a8e)
#1 findnodeintree rbtdb.c:2739 (libdns.1503.dylib:x86_64+0xc896a)
#2 findnode rbtdb.c:2784 (libdns.1503.dylib:x86_64+0xb532b)
#3 dns_db_findnode db.c:447 (libdns.1503.dylib:x86_64+0x2b158)
#4 resquery_response resolver.c:6018 (libdns.1503.dylib:x86_64+0x141e7a)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous read of size 8 at 0x7b1800005f60 by thread T5 (mutexes: write M223627196072301008):
#0 dns_rbt_findnode rbt.c:1467 (libdns.1503.dylib:x86_64+0xab002)
#1 cache_find rbtdb.c:4720 (libdns.1503.dylib:x86_64+0xb54fa)
#2 dns_db_find db.c:511 (libdns.1503.dylib:x86_64+0x2b4df)
#3 dns_view_find view.c:1019 (libdns.1503.dylib:x86_64+0x18cb59)
#4 dbfind_name adb.c:3658 (libdns.1503.dylib:x86_64+0xd8e3)
#5 dns_adb_createfind adb.c:3083 (libdns.1503.dylib:x86_64+0xc163)
#6 findname resolver.c:3371 (libdns.1503.dylib:x86_64+0x13ae8b)
#7 fctx_try resolver.c:3660 (libdns.1503.dylib:x86_64+0x136402)
#8 fctx_start resolver.c:4647 (libdns.1503.dylib:x86_64+0x12f383)
#9 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 89 at 0x7b1800005f40 allocated by thread T5:
#0 malloc <null>:6885552 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_rbtdb_create rbtdb.c:8200 (libdns.1503.dylib:x86_64+0xb0e92)
#3 dns_db_create db.c:118 (libdns.1503.dylib:x86_64+0x2a09c)
#4 dns_cache_create cache.c:173 (libdns.1503.dylib:x86_64+0x1c5d0)
#5 configure_view server.c:4484 (named:x86_64+0x1000279cf)
#6 load_configuration server.c:8916 (named:x86_64+0x100021275)
#7 run_server server.c:9638 (named:x86_64+0x10000de29)
#8 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M1014290113594662432 is already destroyed.
Mutex M223627196072301008 is already destroyed.
Thread T6 (tid=4654359, running) created by main thread at:
#0 pthread_create <null>:6885600 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:6885600 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbt.c:1310 in dns_rbt_addnode
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1348
ThreadSanitizer: data race rbtdb.c:5211 in detachnode
2019-11-26T17:27:41Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:5211 in detachnode
Found in the ns3 log running `named` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the serve-stale system test:
```
WARNING: ThreadSanitizer: data race (pid=31139)
Write of size 4 at 0x7b5c000300e8 by thread T6:
#0 deta...
Found in the ns3 log running `named` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the serve-stale system test:
```
WARNING: ThreadSanitizer: data race (pid=31139)
Write of size 4 at 0x7b5c000300e8 by thread T6:
#0 detachnode rbtdb.c:5211 (libdns.1503.dylib:x86_64+0xb70df)
#1 rdataset_disassociate rbtdb.c:8377 (libdns.1503.dylib:x86_64+0xc0330)
#2 dns_rdataset_disassociate rdataset.c:118 (libdns.1503.dylib:x86_64+0x120089)
#3 fctx_destroy resolver.c:4395 (libdns.1503.dylib:x86_64+0x130251)
#4 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 4 at 0x7b5c000300e8 by thread T1:
#0 maybe_free_rbtdb rbtdb.c:1183 (libdns.1503.dylib:x86_64+0xbba77)
#1 detach rbtdb.c:1212 (libdns.1503.dylib:x86_64+0xb30b3)
#2 dns_db_detach db.c:159 (libdns.1503.dylib:x86_64+0x2a3b3)
#3 query_reset query.c:674 (libns.1501.dylib:x86_64+0xfa10)
#4 query_cleanup query.c:751 (libns.1501.dylib:x86_64+0x1762b)
#5 ns__client_reset_cb client.c:188 (libns.1501.dylib:x86_64+0x4ce8)
#6 isc_nmhandle_unref netmgr.c:874 (libisc.1503.dylib:x86_64+0x1b50b)
#7 isc__nm_uvreq_put netmgr.c:1002 (libisc.1503.dylib:x86_64+0x1bdb8)
#8 udp_send_cb udp.c:436 (libisc.1503.dylib:x86_64+0x1f785)
#9 uv__udp_run_completed <null>:6891168 (libuv.1.dylib:x86_64+0x1278f)
Location is heap block of size 785 at 0x7b5c0002fe80 allocated by thread T8:
#0 malloc <null>:6891200 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_db_create db.c:118 (libdns.1503.dylib:x86_64+0x2a09c)
#3 xfrin_recv_done xfrin.c:280 (libdns.1503.dylib:x86_64+0x1943ae)
#4 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Thread T6 (tid=4591544, running) created by main thread at:
#0 pthread_create <null>:6891248 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T1 (tid=4591539, running) created by main thread at:
#0 pthread_create <null>:6891248 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:895 (named:x86_64+0x10000acbe)
Thread T8 (tid=4591546, running) created by main thread at:
#0 pthread_create <null>:6891152 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:5211 in detachnode
```
While similar to the previous issue, the memory block is different.
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1347
ThreadSanitizer: data race rbtdb.c:5200 in detachnode
2019-11-26T17:27:45Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:5200 in detachnode
Found in the ns3 log running `named` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the serve-stale system test:
```
WARNING: ThreadSanitizer: data race (pid=31139)
Read of size 1 at 0x7b680004c11c by thread T6:
#0 detac...
Found in the ns3 log running `named` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the serve-stale system test:
```
WARNING: ThreadSanitizer: data race (pid=31139)
Read of size 1 at 0x7b680004c11c by thread T6:
#0 detachnode rbtdb.c:5200 (libdns.1503.dylib:x86_64+0xb705f)
#1 rdataset_disassociate rbtdb.c:8377 (libdns.1503.dylib:x86_64+0xc0330)
#2 dns_rdataset_disassociate rdataset.c:118 (libdns.1503.dylib:x86_64+0x120089)
#3 fctx_destroy resolver.c:4395 (libdns.1503.dylib:x86_64+0x130251)
#4 fctx_doshutdown resolver.c:4570 (libdns.1503.dylib:x86_64+0x14c626)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 1 at 0x7b680004c11c by thread T1:
#0 maybe_free_rbtdb rbtdb.c:1173 (libdns.1503.dylib:x86_64+0xbb9b9)
#1 detach rbtdb.c:1212 (libdns.1503.dylib:x86_64+0xb30b3)
#2 dns_db_detach db.c:159 (libdns.1503.dylib:x86_64+0x2a3b3)
#3 query_reset query.c:674 (libns.1501.dylib:x86_64+0xfa10)
#4 query_cleanup query.c:751 (libns.1501.dylib:x86_64+0x1762b)
#5 ns__client_reset_cb client.c:188 (libns.1501.dylib:x86_64+0x4ce8)
#6 isc_nmhandle_unref netmgr.c:874 (libisc.1503.dylib:x86_64+0x1b50b)
#7 isc__nm_uvreq_put netmgr.c:1002 (libisc.1503.dylib:x86_64+0x1bdb8)
#8 udp_send_cb udp.c:436 (libisc.1503.dylib:x86_64+0x1f785)
#9 uv__udp_run_completed <null>:6891168 (libuv.1.dylib:x86_64+0x1278f)
Location is heap block of size 1529 at 0x7b680004bc00 allocated by thread T8:
#0 malloc <null>:6891200 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_db_create db.c:118 (libdns.1503.dylib:x86_64+0x2a09c)
#3 xfrin_recv_done xfrin.c:280 (libdns.1503.dylib:x86_64+0x1943ae)
#4 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Thread T6 (tid=4591544, running) created by main thread at:
#0 pthread_create <null>:6891248 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T1 (tid=4591539, running) created by main thread at:
#0 pthread_create <null>:6891248 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:895 (named:x86_64+0x10000acbe)
Thread T8 (tid=4591546, running) created by main thread at:
#0 pthread_create <null>:6891152 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:5200 in detachnode
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1346
ThreadSanitizer: data race rbt.c:1392 in dns_rbt_addnode
2019-11-26T17:27:49Z
Ondřej Surý
ThreadSanitizer: data race rbt.c:1392 in dns_rbt_addnode
Found in the ns3 log running `named` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the serve-stale system test:
```
WARNING: ThreadSanitizer: data race (pid=31139)
Write of size 4 at 0x7b1800005df8 by thread T5 (mutexes: wr...
Found in the ns3 log running `named` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the serve-stale system test:
```
WARNING: ThreadSanitizer: data race (pid=31139)
Write of size 4 at 0x7b1800005df8 by thread T5 (mutexes: write M999934889782418456):
#0 dns_rbt_addnode rbt.c:1392 (libdns.1503.dylib:x86_64+0xaa64d)
#1 findnodeintree rbtdb.c:2739 (libdns.1503.dylib:x86_64+0xc896a)
#2 findnode rbtdb.c:2784 (libdns.1503.dylib:x86_64+0xb532b)
#3 dns_db_findnode db.c:447 (libdns.1503.dylib:x86_64+0x2b158)
#4 validated resolver.c:5620 (libdns.1503.dylib:x86_64+0x14b111)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 4 at 0x7b1800005df8 by thread T6:
#0 dns_rbt_deletenode rbt.c:2777 (libdns.1503.dylib:x86_64+0xadece)
#1 delete_node rbtdb.c (libdns.1503.dylib:x86_64+0xc3f7f)
#2 decrement_reference rbtdb.c:2070 (libdns.1503.dylib:x86_64+0xc3449)
#3 prune_tree rbtdb.c:2120 (libdns.1503.dylib:x86_64+0xc3894)
#4 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 89 at 0x7b1800005dc0 allocated by thread T5:
#0 malloc <null>:5828000 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_rbtdb_create rbtdb.c:8200 (libdns.1503.dylib:x86_64+0xb0e92)
#3 dns_db_create db.c:118 (libdns.1503.dylib:x86_64+0x2a09c)
#4 dns_cache_create cache.c:173 (libdns.1503.dylib:x86_64+0x1c5d0)
#5 configure_view server.c:4484 (named:x86_64+0x1000279cf)
#6 load_configuration server.c:8916 (named:x86_64+0x100021275)
#7 run_server server.c:9638 (named:x86_64+0x10000de29)
#8 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M999934889782418456 is already destroyed.
Thread T5 (tid=4591543, running) created by main thread at:
#0 pthread_create <null>:5828048 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T6 (tid=4591544, running) created by main thread at:
#0 pthread_create <null>:5828048 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbt.c:1392 in dns_rbt_addnode
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1345
ThreadSanitizer: data race rbt.c:1706 in dns_rbt_findnode
2019-11-26T17:27:51Z
Ondřej Surý
ThreadSanitizer: data race rbt.c:1706 in dns_rbt_findnode
Found in the ns3 log running `named` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the serve-stale system test:
```
WARNING: ThreadSanitizer: data race (pid=31139)
Read of size 8 at 0x7b2000017bc8 by thread T5 (mutexes: wri...
Found in the ns3 log running `named` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the serve-stale system test:
```
WARNING: ThreadSanitizer: data race (pid=31139)
Read of size 8 at 0x7b2000017bc8 by thread T5 (mutexes: write M999934889782418456):
#0 dns_rbt_findnode rbt.c:1706 (libdns.1503.dylib:x86_64+0xab710)
#1 findnodeintree rbtdb.c:2723 (libdns.1503.dylib:x86_64+0xc8902)
#2 findnode rbtdb.c:2784 (libdns.1503.dylib:x86_64+0xb532b)
#3 dns_db_findnode db.c:447 (libdns.1503.dylib:x86_64+0x2b158)
#4 validated resolver.c:5620 (libdns.1503.dylib:x86_64+0x14b111)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 8 at 0x7b2000017bc8 by thread T6:
#0 dns_rbt_deletenode rbt.c:2554 (libdns.1503.dylib:x86_64+0xacf36)
#1 delete_node rbtdb.c (libdns.1503.dylib:x86_64+0xc3f7f)
#2 decrement_reference rbtdb.c:2070 (libdns.1503.dylib:x86_64+0xc3449)
#3 prune_tree rbtdb.c:2120 (libdns.1503.dylib:x86_64+0xc3894)
#4 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 116 at 0x7b2000017b80 allocated by thread T8:
#0 malloc <null>:5826944 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 dns_rbt_addnode rbt.c:1146 (libdns.1503.dylib:x86_64+0xaa798)
#3 findnodeintree rbtdb.c:2739 (libdns.1503.dylib:x86_64+0xc896a)
#4 findnode rbtdb.c:2784 (libdns.1503.dylib:x86_64+0xb532b)
#5 dns_db_findnode db.c:447 (libdns.1503.dylib:x86_64+0x2b158)
#6 resquery_response resolver.c:6629 (libdns.1503.dylib:x86_64+0x1432d4)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M999934889782418456 is already destroyed.
Thread T5 (tid=4591543, running) created by main thread at:
#0 pthread_create <null>:5826992 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T6 (tid=4591544, running) created by main thread at:
#0 pthread_create <null>:5826992 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T8 (tid=4591546, running) created by main thread at:
#0 pthread_create <null>:5826896 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbt.c:1706 in dns_rbt_findnode
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1344
ThreadSanitizer: data race rbtdb.c:2987 in bind_rdataset
2019-11-19T08:20:10Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:2987 in bind_rdataset
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0 c9e358fbf5f5ad6c833b5be21f8afcf02b939c80
* Tests: serve-stale, autosign
```
WARNING: ThreadSanitizer: data race (pid=31139)
Write of size 4 at 0x7b2c00010218 by thre...
* Binary: `named`
* Commit: c5b6f21515d44c997aa4aa259d2e0653a843fba0 c9e358fbf5f5ad6c833b5be21f8afcf02b939c80
* Tests: serve-stale, autosign
```
WARNING: ThreadSanitizer: data race (pid=31139)
Write of size 4 at 0x7b2c00010218 by thread T6 (mutexes: write M657661300922451992, write M1030334187267172112):
#0 bind_rdataset rbtdb.c:2987 (libdns.1503.dylib:x86_64+0xbfdb5)
#1 zone_find rbtdb.c:4249 (libdns.1503.dylib:x86_64+0xc5c2e)
#2 dns_db_find db.c:511 (libdns.1503.dylib:x86_64+0x2b4df)
#3 dns_view_findzonecut view.c:1284 (libdns.1503.dylib:x86_64+0x18d567)
#4 dns_resolver_createfetch resolver.c:4891 (libdns.1503.dylib:x86_64+0x12c797)
#5 zone_maintenance zone.c:10586 (libdns.1503.dylib:x86_64+0x1ca57d)
#6 zone_timer zone.c:13669 (libdns.1503.dylib:x86_64+0x1aadb5)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 4 at 0x7b2c00010218 by thread T8:
#0 bind_rdataset rbtdb.c:2987 (libdns.1503.dylib:x86_64+0xbfdb5)
#1 rdatasetiter_current rbtdb.c:8810 (libdns.1503.dylib:x86_64+0xcc7d1)
#2 dns_rdatasetiter_current rdatasetiter.c:70 (libdns.1503.dylib:x86_64+0x1227cf)
#3 dump_rdatasets_raw masterdump.c:1224 (libdns.1503.dylib:x86_64+0x6f46e)
#4 dumptostreaminc masterdump.c:1686 (libdns.1503.dylib:x86_64+0x6d4e8)
#5 dump_quantum masterdump.c:1421 (libdns.1503.dylib:x86_64+0x704cf)
#6 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 171 at 0x7b2c000101d0 allocated by thread T8:
#0 malloc <null>:6875376 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 loading_addrdataset rbtdb.c:7027 (libdns.1503.dylib:x86_64+0xbbe1e)
#3 dns_diff_load diff.c:508 (libdns.1503.dylib:x86_64+0x30973)
#4 xfrin_recv_done xfrin.c:324 (libdns.1503.dylib:x86_64+0x194627)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M657661300922451992 is already destroyed.
Mutex M1030334187267172112 is already destroyed.
Thread T6 (tid=4591544, running) created by main thread at:
#0 pthread_create <null>:6875424 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T8 (tid=4591546, running) created by main thread at:
#0 pthread_create <null>:6875424 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:2987 in bind_rdataset
```
```
WARNING: ThreadSanitizer: data race (pid=45980)
Write of size 4 at 0x7b30000115c8 by thread T7 (mutexes: write M290055290576030928):
#0 bind_rdataset rbtdb.c:2987 (libdns.1503.dylib:x86_64+0xbfdb5)
#1 find_deepest_zonecut rbtdb.c:4543 (libdns.1503.dylib:x86_64+0xc96df)
#2 cache_find rbtdb.c:4738 (libdns.1503.dylib:x86_64+0xb5f48)
#3 dns_db_find db.c:511 (libdns.1503.dylib:x86_64+0x2b4df)
#4 dns_view_find view.c:1019 (libdns.1503.dylib:x86_64+0x18cb59)
#5 dbfind_name adb.c:3658 (libdns.1503.dylib:x86_64+0xd8e3)
#6 dns_adb_createfind adb.c:3083 (libdns.1503.dylib:x86_64+0xc163)
#7 findname resolver.c:3371 (libdns.1503.dylib:x86_64+0x13ae8b)
#8 fctx_try resolver.c:3660 (libdns.1503.dylib:x86_64+0x136402)
#9 fctx_start resolver.c:4647 (libdns.1503.dylib:x86_64+0x12f383)
#10 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 4 at 0x7b30000115c8 by thread T5:
#0 bind_rdataset rbtdb.c:2987 (libdns.1503.dylib:x86_64+0xbfdb5)
#1 cache_findzonecut rbtdb.c:5132 (libdns.1503.dylib:x86_64+0xb6bde)
#2 dns_db_findzonecut db.c:577 (libdns.1503.dylib:x86_64+0x2b900)
#3 dns_view_findzonecut view.c:1309 (libdns.1503.dylib:x86_64+0x18d4be)
#4 rctx_done resolver.c:9348 (libdns.1503.dylib:x86_64+0x1443e8)
#5 resquery_response resolver.c (libdns.1503.dylib:x86_64+0x13ece7)
#6 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 183 at 0x7b3000011580 allocated by thread T5:
#0 malloc <null>:7941664 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 addrdataset rbtdb.c:6450 (libdns.1503.dylib:x86_64+0xb88d4)
#3 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#4 resquery_response resolver.c:6341 (libdns.1503.dylib:x86_64+0x1424a7)
#5 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M290055290576030928 is already destroyed.
Thread T7 (tid=4654360, running) created by main thread at:
#0 pthread_create <null>:7941712 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
Thread T5 (tid=4654358, running) created by main thread at:
#0 pthread_create <null>:7941712 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race rbtdb.c:2987 in bind_rdataset
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1343
ThreadSanitizer: data race netmgr.c:813 in isc__nmhandle_get
2019-11-26T17:27:54Z
Ondřej Surý
ThreadSanitizer: data race netmgr.c:813 in isc__nmhandle_get
Found in ns3 log while running `named` in the serve-stale system compiled test compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0:
```
WARNING: ThreadSanitizer: data race (pid=31106)
Write of size 8 at 0x7b7c00000978 by thread T3 (...
Found in ns3 log while running `named` in the serve-stale system compiled test compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0:
```
WARNING: ThreadSanitizer: data race (pid=31106)
Write of size 8 at 0x7b7c00000978 by thread T3 (mutexes: write M803183881061665024):
#0 isc__nmhandle_get netmgr.c:813 (libisc.1503.dylib:x86_64+0x1b1d0)
#1 udp_recv_cb udp.c:309 (libisc.1503.dylib:x86_64+0x1ea53)
#2 uv__udp_io <null>:3676272 (libuv.1.dylib:x86_64+0x13244)
Previous read of size 8 at 0x7b7c00000978 by thread T1:
#0 isc_nmhandle_unref netmgr.c:899 (libisc.1503.dylib:x86_64+0x1b704)
#1 isc__nm_uvreq_put netmgr.c:1002 (libisc.1503.dylib:x86_64+0x1bdb8)
#2 udp_send_cb udp.c:436 (libisc.1503.dylib:x86_64+0x1f785)
#3 uv__udp_run_completed <null>:3676272 (libuv.1.dylib:x86_64+0x1278f)
Location is heap block of size 3313 at 0x7b7c00000000 allocated by thread T5:
#0 malloc <null>:3676304 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 ns_interface_setup interfacemgr.c:448 (libns.1501.dylib:x86_64+0xe9c0)
#3 ns_interfacemgr_scan0 interfacemgr.c:1067 (libns.1501.dylib:x86_64+0xd830)
#4 ns_interfacemgr_scan interfacemgr.c:1174 (libns.1501.dylib:x86_64+0xc7ee)
#5 load_configuration server.c:8696 (named:x86_64+0x10001f899)
#6 run_server server.c:9638 (named:x86_64+0x10000de29)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Mutex M803183881061665024 is already destroyed.
Thread T3 (tid=4591307, running) created by main thread at:
#0 pthread_create <null>:3676352 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:895 (named:x86_64+0x10000acbe)
Thread T1 (tid=4591305, running) created by main thread at:
#0 pthread_create <null>:3676352 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:895 (named:x86_64+0x10000acbe)
Thread T5 (tid=4591309, running) created by main thread at:
#0 pthread_create <null>:3676256 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main main.c:902 (named:x86_64+0x10000ad16)
SUMMARY: ThreadSanitizer: data race netmgr.c:813 in isc__nmhandle_get
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
https://gitlab.isc.org/isc-projects/bind9/-/issues/1342
feature-test build rules fails to preserve ThreadSanitizer options (-fsanitiz...
2019-11-19T08:30:47Z
Ondřej Surý
feature-test build rules fails to preserve ThreadSanitizer options (-fsanitizer=thread)
```
$ ./feature-test
dyld: lazy symbol binding failed: Symbol not found: ___tsan_init
Referenced from: /Users/ondrej/Projects/bind9/lib/isc/.libs/libisc.1503.dylib
Expected in: flat namespace
dyld: Symbol not found: ___tsan_init
R...
```
$ ./feature-test
dyld: lazy symbol binding failed: Symbol not found: ___tsan_init
Referenced from: /Users/ondrej/Projects/bind9/lib/isc/.libs/libisc.1503.dylib
Expected in: flat namespace
dyld: Symbol not found: ___tsan_init
Referenced from: /Users/ondrej/Projects/bind9/lib/isc/.libs/libisc.1503.dylib
Expected in: flat namespace
Abort trap: 6
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
Ondřej Surý
Ondřej Surý
https://gitlab.isc.org/isc-projects/bind9/-/issues/1341
ThreadSanitizer: data race rbtdb.c:5756 in add32
2019-11-19T17:05:32Z
Ondřej Surý
ThreadSanitizer: data race rbtdb.c:5756 in add32
Found by running `dnssec-signzone` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the dnssec system test:
```
WARNING: ThreadSanitizer: data race (pid=18887)
Write of size 8 at 0x7b5c00000928 by thread T5:
#0 add32 rbtdb...
Found by running `dnssec-signzone` compiled from c5b6f21515d44c997aa4aa259d2e0653a843fba0 in the dnssec system test:
```
WARNING: ThreadSanitizer: data race (pid=18887)
Write of size 8 at 0x7b5c00000928 by thread T5:
#0 add32 rbtdb.c:5756 (libdns.1503.dylib:x86_64+0xbd8e9)
#1 addrdataset rbtdb.c:6599 (libdns.1503.dylib:x86_64+0xb9abc)
#2 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#3 diff_apply diff.c:364 (libdns.1503.dylib:x86_64+0x302cc)
#4 dns_diff_applysilently diff.c:457 (libdns.1503.dylib:x86_64+0x306bb)
#5 signname dnssec-signzone.c:1147 (dnssec-signzone:x86_64+0x10000c9dd)
#6 sign dnssec-signzone.c:1627 (dnssec-signzone:x86_64+0x10000de57)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Previous write of size 8 at 0x7b5c00000928 by thread T8:
#0 add32 rbtdb.c:5756 (libdns.1503.dylib:x86_64+0xbd8e9)
#1 addrdataset rbtdb.c:6599 (libdns.1503.dylib:x86_64+0xb9abc)
#2 dns_db_addrdataset db.c:744 (libdns.1503.dylib:x86_64+0x2c2ee)
#3 diff_apply diff.c:364 (libdns.1503.dylib:x86_64+0x302cc)
#4 dns_diff_applysilently diff.c:457 (libdns.1503.dylib:x86_64+0x306bb)
#5 signname dnssec-signzone.c:1147 (dnssec-signzone:x86_64+0x10000c9dd)
#6 sign dnssec-signzone.c:1627 (dnssec-signzone:x86_64+0x10000de57)
#7 run task.c:1134 (libisc.1503.dylib:x86_64+0x2c9e1)
Location is heap block of size 801 at 0x7b5c00000700 allocated by main thread:
#0 malloc <null>:5823120 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4e65a)
#1 default_memalloc mem.c:685 (libisc.1503.dylib:x86_64+0x17ae1)
#2 newversion rbtdb.c:1281 (libdns.1503.dylib:x86_64+0xb37ee)
#3 dns_db_newversion db.c:383 (libdns.1503.dylib:x86_64+0x2adbf)
#4 main dnssec-signzone.c:3738 (dnssec-signzone:x86_64+0x1000036fa)
Thread T5 (tid=4542388, running) created by main thread at:
#0 pthread_create <null>:5823168 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main dnssec-signzone.c:3800 (dnssec-signzone:x86_64+0x100006289)
Thread T8 (tid=4542391, running) created by main thread at:
#0 pthread_create <null>:5823168 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a9cd)
#1 isc_thread_create thread.c:75 (libisc.1503.dylib:x86_64+0x46d1c)
#2 main dnssec-signzone.c:3800 (dnssec-signzone:x86_64+0x100006289)
SUMMARY: ThreadSanitizer: data race rbtdb.c:5756 in add32
```
December 2019 (9.11.14, 9.14.9, 9.15.7)
Mark Andrews
Mark Andrews