Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
BIND
BIND
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 627
    • Issues 627
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 116
    • Merge Requests 116
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #1040

Closed
Open
Created May 18, 2019 by Evan Hunt@eachOwner

missing cache expiration test

While examining differences between the 9.11 and 9.11 subscription branches I noticed an unexpected change in rbtdb.c:expirenode() - the force_expire variable was set to true in one and false in the other. This bug was introduced when we changed the boolean constants from ISC_TRUE to true and ISC_FALSE to false. In the subscription branch, an ISC_FALSE was changed to true by mistake.

I'm not certain what the effects of this were, but based on the names, I would guess that cache nodes were probably forced to expire in some cases when they shouldn't have been, perhaps leading to more recursion than would otherwise have been necessary.

It's disappointing that no unit or system test noticed the change, and we should consider writing one that would.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None