Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
BIND
BIND
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 629
    • Issues 629
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 112
    • Merge Requests 112
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #1076

Closed
Open
Created Jun 07, 2019 by Vicky Risk@vickyMaintainer

[ISC-support #10104] possible use of uninitialized value in zone_touched()

Migrated from BUGS RT #42440

From code inspection, it looks like bind9/lib/dns/zone.c:zone_touched() could use an uninitialized value of 'modtime' here:

isc_time_t modtime;
[...]
result = isc_file_getmodtime(zone->masterfile, &modtime);
if (result != ISC_R_SUCCESS ||
isc_time_compare(&modtime, &zone->loadtime) > 0)
{
zone->loadtime = modtime;
return (ISC_TRUE);
}

if isc_file_getmodtime() fails. I don't know the intent of the implementation in this case, but depending on the intent this would probably either have to be intact or set to 'now' instead. (I don't have a particular opinion. I'd leave how to fix it to you).

From Support ticket #10104

Edited Jul 11, 2019 by Cathy Almond
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None