Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 527
    • Issues 527
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 96
    • Merge requests 96
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #109
Closed
Open
Created Feb 24, 2018 by Petr Menšík@pemensikContributor

[PATCH] dnssec-keygen: double free after keygen error

Hello,

while I was playing with FIPS mode support, I found dnssec-keygen is crashing reliably in that mode. If RSA_generate_key_ex fails for any reason and OpenSSL 1.1+ is used, freed pointer is not reset to null. In err label it is then freed again. I doubt it is possible to trigger this error remotely, but it might be security related. I will leave that to you for consideration. I think always assigning explicit NULL outside BN_GENCB_free would not hurt. Changed by the second patch.

Is there reason why EVP_PKEY_CTX is not used for key generation instead? Is patch with more recent generic API welcome?

0001-Fix-double-free-on-RSA_generate_key_ex-failure.patch0002-Do-not-assign-NULL-conditionally-in-OpenSSL-1.1-make.patch

Assignee
Assign to
Time tracking