Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
BIND
BIND
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 627
    • Issues 627
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 116
    • Merge Requests 116
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #119

Closed
Open
Created Feb 27, 2018 by Ghost User@ghost

Remove unnecessary INSIST() in code

diff --git a/lib/ns/query.c b/lib/ns/query.c
index 6f8df29dce..e9f0590f07 100644
--- a/lib/ns/query.c
+++ b/lib/ns/query.c
@@ -3882,8 +3882,8 @@ rpz_rewrite(ns_client_t *client, dns_rdatatype_t qtype,
                st->popt = popt;
                st->rpz_ver = rpz_ver;
                client->query.rpz_st = st;
-               if (popt.dnsrps_enabled) {
 #ifdef USE_DNSRPS
+               if (popt.dnsrps_enabled) {
                        if (st->rpsdb != NULL) {
                                dns_db_detach(&st->rpsdb);
                        }
@@ -3898,10 +3898,8 @@ rpz_rewrite(ns_client_t *client, dns_rdatatype_t qtype,
                                st->m.policy = DNS_RPZ_POLICY_ERROR;
                                return (ISC_R_SUCCESS);
                        }
-#else
-                       INSIST(0);
-#endif
                }
+#endif
        }
 
        /*
Assignee
Assign to
BIND-9.13.0
Milestone
BIND-9.13.0 (Past due)
Assign milestone
Time tracking
None
Due date
None