Follow-up from "Change the return value for dns_name_dup() to void and cleanup the code"

The following discussion from !2518 (merged) should be addressed:

• @michal started a discussion: (+2 comments)

  🎖 ACHIEVEMENT UNLOCKED: RABBIT HOLE UNCOVERED! 🎖

  With isc_mem_get() and dns_name_dup() no longer being able to fail, I believe the following functions can now only return ISC_R_SUCCESS and thus should be refactored to have a return type of void:

  • lib/dns/catz.c:dns_catz_entry_new
  • lib/dns/lookup.c:build_event
  • lib/dns/rdata.c:name_duporclone
  • lib/dns/resolver.c:dns_resolver_addalternate
  • lib/dns/ssu.c:dns_ssutable_addrule
  • lib/dns/view.c:dns_view_adddelegationonly
  • lib/dns/view.c:dns_view_excludedelegationonly
  • lib/dns/zone.c:set_addrkeylist