ThreadSanitizer: data race (bin/named/.libs/named+0x449fe2) in ns__client_setup lib/ns/client.c:2278:13 (#1485) · Issues · ISC Open Source Projects / BIND

ThreadSanitizer: data race (bin/named/.libs/named+0x449fe2) in ns__client_setup lib/ns/client.c:2278:13

There are more variants where the second thread runs:

fetch_callback()

WARNING: ThreadSanitizer: data race
  Write of size 8 at 0x000000000001 by thread T1:
    #0 memset <null>
    #1 ns__client_setup lib/ns/client.c:2278:13
    #2 ns__client_request lib/ns/client.c:1643:12
    #3 processbuffer lib/isc/netmgr/tcpdns.c:177:3
    #4 dnslisten_readcb lib/isc/netmgr/tcpdns.c:231:12
    #5 read_cb lib/isc/netmgr/tcp.c:768:4
    #6 <null> <null>

  Previous read of size 8 at 0x000000000001 by thread T2:
    #0 fetch_callback lib/ns/query.c:5680:29
    #1 dispatch lib/isc/task.c:1143:7
    #2 run lib/isc/task.c:1328:2

  Location is heap block of size 7489 at 0x000000000012 allocated by thread T1:
    #0 malloc <null>
    #1 default_memalloc lib/isc/mem.c:685:8
    #2 mem_get lib/isc/mem.c:598:8
    #3 mem_allocateunlocked lib/isc/mem.c:1222:8
    #4 isc___mem_allocate lib/isc/mem.c:1242:7
    #5 isc__mem_allocate lib/isc/mem.c:2387:10
    #6 isc___mem_get lib/isc/mem.c:1007:11
    #7 isc__mem_get lib/isc/mem.c:2365:10
    #8 alloc_handle lib/isc/netmgr/netmgr.c:918:3
    #9 isc__nmhandle_get lib/isc/netmgr/netmgr.c:942:12
    #10 processbuffer lib/isc/netmgr/tcpdns.c:176:15
    #11 dnslisten_readcb lib/isc/netmgr/tcpdns.c:231:12
    #12 read_cb lib/isc/netmgr/tcp.c:768:4
    #13 <null> <null>

  Thread T1 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_nm_start lib/isc/netmgr/netmgr.c:149:3
    #3 create_managers bin/named/./main.c:895:15
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

  Thread T2 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_taskmgr_create lib/isc/task.c:1419:3
    #3 create_managers bin/named/./main.c:902:11
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

SUMMARY: ThreadSanitizer: data race in memset

WARNING: ThreadSanitizer: data race
  Write of size 8 at 0x000000000001 by thread T1:
    #0 memset <null>
    #1 ns__client_setup lib/ns/client.c:2278:13
    #2 ns__client_request lib/ns/client.c:1643:12
    #3 udp_recv_cb lib/isc/netmgr/udp.c:317:2
    #4 <null> <null>

  Previous read of size 8 at 0x000000000001 by thread T2:
    #0 fetch_callback lib/ns/query.c:5680:29
    #1 dispatch lib/isc/task.c:1143:7
    #2 run lib/isc/task.c:1328:2

  Location is heap block of size 7489 at 0x000000000010 allocated by thread T1:
    #0 malloc <null>
    #1 default_memalloc lib/isc/mem.c:685:8
    #2 mem_get lib/isc/mem.c:598:8
    #3 mem_allocateunlocked lib/isc/mem.c:1222:8
    #4 isc___mem_allocate lib/isc/mem.c:1242:7
    #5 isc__mem_allocate lib/isc/mem.c:2387:10
    #6 isc___mem_get lib/isc/mem.c:1007:11
    #7 isc__mem_get lib/isc/mem.c:2365:10
    #8 alloc_handle lib/isc/netmgr/netmgr.c:918:3
    #9 isc__nmhandle_get lib/isc/netmgr/netmgr.c:942:12
    #10 udp_recv_cb lib/isc/netmgr/udp.c:312:13
    #11 <null> <null>

  Thread T1 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_nm_start lib/isc/netmgr/netmgr.c:149:3
    #3 create_managers bin/named/./main.c:895:15
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

  Thread T2 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_taskmgr_create lib/isc/task.c:1419:3
    #3 create_managers bin/named/./main.c:902:11
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

SUMMARY: ThreadSanitizer: data race in memset

isc_sockaddr_pf()

WARNING: ThreadSanitizer: data race
  Write of size 8 at 0x000000000001 by thread T1:
    #0 memset <null>
    #1 ns__client_setup lib/ns/client.c:2278:13
    #2 ns__client_request lib/ns/client.c:1643:12
    #3 udp_recv_cb lib/isc/netmgr/udp.c:317:2
    #4 <null> <null>

  Previous read of size 2 at 0x000000000001 by thread T2:
    #0 isc_sockaddr_pf lib/isc/sockaddr.c:326:28
    #1 ns_client_send lib/ns/client.c:633:11
    #2 respond lib/ns/update.c:1559:2
    #3 updatedone_action lib/ns/update.c:3391:2
    #4 dispatch lib/isc/task.c:1143:7
    #5 run lib/isc/task.c:1328:2

  Location is heap block of size 7473 at 0x000000000013 allocated by thread T1:
    #0 malloc <null>
    #1 default_memalloc lib/isc/mem.c:685:8
    #2 mem_get lib/isc/mem.c:598:8
    #3 isc___mem_get lib/isc/mem.c:1013:9
    #4 isc__mem_get lib/isc/mem.c:2365:10
    #5 alloc_handle lib/isc/netmgr/netmgr.c:918:3
    #6 isc__nmhandle_get lib/isc/netmgr/netmgr.c:942:12
    #7 udp_recv_cb lib/isc/netmgr/udp.c:312:13
    #8 <null> <null>

  Thread T1 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_nm_start lib/isc/netmgr/netmgr.c:149:3
    #3 create_managers bin/named/./main.c:895:15
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

  Thread T2 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_taskmgr_create lib/isc/task.c:1419:3
    #3 create_managers bin/named/./main.c:902:11
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

SUMMARY: ThreadSanitizer: data race in memset

updatedone_action()

WARNING: ThreadSanitizer: data race
  Write of size 8 at 0x000000000001 by thread T1:
    #0 memset <null>
    #1 ns__client_setup lib/ns/client.c:2278:13
    #2 ns__client_request lib/ns/client.c:1643:12
    #3 udp_recv_cb lib/isc/netmgr/udp.c:317:2
    #4 <null> <null>

  Previous read of size 8 at 0x000000000001 by thread T2:
    #0 updatedone_action lib/ns/update.c:3393:29
    #1 dispatch lib/isc/task.c:1143:7
    #2 run lib/isc/task.c:1328:2

  Location is heap block of size 7473 at 0x000000000010 allocated by thread T1:
    #0 malloc <null>
    #1 default_memalloc lib/isc/mem.c:685:8
    #2 mem_get lib/isc/mem.c:598:8
    #3 isc___mem_get lib/isc/mem.c:1013:9
    #4 isc__mem_get lib/isc/mem.c:2365:10
    #5 alloc_handle lib/isc/netmgr/netmgr.c:918:3
    #6 isc__nmhandle_get lib/isc/netmgr/netmgr.c:942:12
    #7 udp_recv_cb lib/isc/netmgr/udp.c:312:13
    #8 <null> <null>

  Thread T1 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_nm_start lib/isc/netmgr/netmgr.c:149:3
    #3 create_managers bin/named/./main.c:895:15
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

  Thread T2 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_taskmgr_create lib/isc/task.c:1419:3
    #3 create_managers bin/named/./main.c:902:11
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

SUMMARY: ThreadSanitizer: data race in memset

WARNING: ThreadSanitizer: data race
  Write of size 8 at 0x000000000001 by thread T1:
    #0 memset <null>
    #1 ns__client_setup lib/ns/client.c:2278:13
    #2 ns__client_request lib/ns/client.c:1643:12
    #3 udp_recv_cb lib/isc/netmgr/udp.c:317:2
    #4 <null> <null>

  Previous read of size 8 at 0x000000000001 by thread T2:
    #0 updatedone_action lib/ns/update.c:3393:29
    #1 dispatch lib/isc/task.c:1143:7
    #2 run lib/isc/task.c:1328:2

  Location is heap block of size 7489 at 0x000000000010 allocated by thread T1:
    #0 malloc <null>
    #1 default_memalloc lib/isc/mem.c:685:8
    #2 mem_get lib/isc/mem.c:598:8
    #3 mem_allocateunlocked lib/isc/mem.c:1222:8
    #4 isc___mem_allocate lib/isc/mem.c:1242:7
    #5 isc__mem_allocate lib/isc/mem.c:2387:10
    #6 isc___mem_get lib/isc/mem.c:1007:11
    #7 isc__mem_get lib/isc/mem.c:2365:10
    #8 alloc_handle lib/isc/netmgr/netmgr.c:918:3
    #9 isc__nmhandle_get lib/isc/netmgr/netmgr.c:942:12
    #10 udp_recv_cb lib/isc/netmgr/udp.c:312:13
    #11 <null> <null>

  Thread T1 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_nm_start lib/isc/netmgr/netmgr.c:149:3
    #3 create_managers bin/named/./main.c:895:15
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

  Thread T2 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_taskmgr_create lib/isc/task.c:1419:3
    #3 create_managers bin/named/./main.c:902:11
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

SUMMARY: ThreadSanitizer: data race in memset

There are more variants where the second thread runs:

* `fetch_callback()`
```
WARNING: ThreadSanitizer: data race
  Write of size 8 at 0x000000000001 by thread T1:
    #0 memset <null>
    #1 ns__client_setup lib/ns/client.c:2278:13
    #2 ns__client_request lib/ns/client.c:1643:12
    #3 processbuffer lib/isc/netmgr/tcpdns.c:177:3
    #4 dnslisten_readcb lib/isc/netmgr/tcpdns.c:231:12
    #5 read_cb lib/isc/netmgr/tcp.c:768:4
    #6 <null> <null>

Previous read of size 8 at 0x000000000001 by thread T2:
    #0 fetch_callback lib/ns/query.c:5680:29
    #1 dispatch lib/isc/task.c:1143:7
    #2 run lib/isc/task.c:1328:2

Location is heap block of size 7489 at 0x000000000012 allocated by thread T1:
    #0 malloc <null>
    #1 default_memalloc lib/isc/mem.c:685:8
    #2 mem_get lib/isc/mem.c:598:8
    #3 mem_allocateunlocked lib/isc/mem.c:1222:8
    #4 isc___mem_allocate lib/isc/mem.c:1242:7
    #5 isc__mem_allocate lib/isc/mem.c:2387:10
    #6 isc___mem_get lib/isc/mem.c:1007:11
    #7 isc__mem_get lib/isc/mem.c:2365:10
    #8 alloc_handle lib/isc/netmgr/netmgr.c:918:3
    #9 isc__nmhandle_get lib/isc/netmgr/netmgr.c:942:12
    #10 processbuffer lib/isc/netmgr/tcpdns.c:176:15
    #11 dnslisten_readcb lib/isc/netmgr/tcpdns.c:231:12
    #12 read_cb lib/isc/netmgr/tcp.c:768:4
    #13 <null> <null>

Thread T1 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_nm_start lib/isc/netmgr/netmgr.c:149:3
    #3 create_managers bin/named/./main.c:895:15
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

Thread T2 (running) created by main thread at:
    #0 pthread_create <null>
    #1 isc_thread_create lib/isc/pthreads/thread.c:75:8
    #2 isc_taskmgr_create lib/isc/task.c:1419:3
    #3 create_managers bin/named/./main.c:902:11
    #4 setup bin/named/./main.c:1235:11
    #5 main bin/named/./main.c:1515:2

SUMMARY: ThreadSanitizer: data race in memset
```

```
WARNING: ThreadSanitizer: data race
  Write of size 8 at 0x000000000001 by thread T1:
    #0 memset <null>
    #1 ns__client_setup lib/ns/client.c:2278:13
    #2 ns__client_request lib/ns/client.c:1643:12
    #3 udp_recv_cb lib/isc/netmgr/udp.c:317:2
    #4 <null> <null>

Previous read of size 8 at 0x000000000001 by thread T2:
    #0 fetch_callback lib/ns/query.c:5680:29
    #1 dispatch lib/isc/task.c:1143:7
    #2 run lib/isc/task.c:1328:2

Location is heap block of size 7489 at 0x000000000010 allocated by thread T1:
    #0 malloc <null>
    #1 default_memalloc lib/isc/mem.c:685:8
    #2 mem_get lib/isc/mem.c:598:8
    #3 mem_allocateunlocked lib/isc/mem.c:1222:8
    #4 isc___mem_allocate lib/isc/mem.c:1242:7
    #5 isc__mem_allocate lib/isc/mem.c:2387:10
    #6 isc___mem_get lib/isc/mem.c:1007:11
    #7 isc__mem_get lib/isc/mem.c:2365:10
    #8 alloc_handle lib/isc/netmgr/netmgr.c:918:3
    #9 isc__nmhandle_get lib/isc/netmgr/netmgr.c:942:12
    #10 udp_recv_cb lib/isc/netmgr/udp.c:312:13
    #11 <null> <null>

SUMMARY: ThreadSanitizer: data race in memset
```

* `isc_sockaddr_pf()`
```
WARNING: ThreadSanitizer: data race
  Write of size 8 at 0x000000000001 by thread T1:
    #0 memset <null>
    #1 ns__client_setup lib/ns/client.c:2278:13
    #2 ns__client_request lib/ns/client.c:1643:12
    #3 udp_recv_cb lib/isc/netmgr/udp.c:317:2
    #4 <null> <null>

Previous read of size 2 at 0x000000000001 by thread T2:
    #0 isc_sockaddr_pf lib/isc/sockaddr.c:326:28
    #1 ns_client_send lib/ns/client.c:633:11
    #2 respond lib/ns/update.c:1559:2
    #3 updatedone_action lib/ns/update.c:3391:2
    #4 dispatch lib/isc/task.c:1143:7
    #5 run lib/isc/task.c:1328:2

Location is heap block of size 7473 at 0x000000000013 allocated by thread T1:
    #0 malloc <null>
    #1 default_memalloc lib/isc/mem.c:685:8
    #2 mem_get lib/isc/mem.c:598:8
    #3 isc___mem_get lib/isc/mem.c:1013:9
    #4 isc__mem_get lib/isc/mem.c:2365:10
    #5 alloc_handle lib/isc/netmgr/netmgr.c:918:3
    #6 isc__nmhandle_get lib/isc/netmgr/netmgr.c:942:12
    #7 udp_recv_cb lib/isc/netmgr/udp.c:312:13
    #8 <null> <null>

SUMMARY: ThreadSanitizer: data race in memset
```

* `updatedone_action()`
```
WARNING: ThreadSanitizer: data race
  Write of size 8 at 0x000000000001 by thread T1:
    #0 memset <null>
    #1 ns__client_setup lib/ns/client.c:2278:13
    #2 ns__client_request lib/ns/client.c:1643:12
    #3 udp_recv_cb lib/isc/netmgr/udp.c:317:2
    #4 <null> <null>

Previous read of size 8 at 0x000000000001 by thread T2:
    #0 updatedone_action lib/ns/update.c:3393:29
    #1 dispatch lib/isc/task.c:1143:7
    #2 run lib/isc/task.c:1328:2

Location is heap block of size 7473 at 0x000000000010 allocated by thread T1:
    #0 malloc <null>
    #1 default_memalloc lib/isc/mem.c:685:8
    #2 mem_get lib/isc/mem.c:598:8
    #3 isc___mem_get lib/isc/mem.c:1013:9
    #4 isc__mem_get lib/isc/mem.c:2365:10
    #5 alloc_handle lib/isc/netmgr/netmgr.c:918:3
    #6 isc__nmhandle_get lib/isc/netmgr/netmgr.c:942:12
    #7 udp_recv_cb lib/isc/netmgr/udp.c:312:13
    #8 <null> <null>

SUMMARY: ThreadSanitizer: data race in memset
```

Previous read of size 8 at 0x000000000001 by thread T2:
    #0 updatedone_action lib/ns/update.c:3393:29
    #1 dispatch lib/isc/task.c:1143:7
    #2 run lib/isc/task.c:1328:2

SUMMARY: ThreadSanitizer: data race in memset
```

Edited Dec 12, 2019 by Ondřej Surý

Discussion
Designs

The one place for your designs

To enable design management, you'll need to meet the requirements. If you need help, reach out to our support team for assistance.