Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
BIND
BIND
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 579
    • Issues 579
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 110
    • Merge Requests 110
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #168

Closed
Open
Opened Mar 19, 2018 by Ghost User@ghost

coverity: Incorrect shifting in DNS_RPZ_ZMASK

________________________________________________________________________________________________________
*** CID 1430160:    (BAD_SHIFT)
/lib/ns/query.c: 2610 in rpz_get_zbits()
2604             *      the smallest name,
2605             *      the longest IP address prefix,
2606             *      the lexically smallest address.
2607             */
2608            if (st->m.policy != DNS_RPZ_POLICY_MISS) {
2609                    if (st->m.type >= rpz_type) {
>>>     CID 1430160:    (BAD_SHIFT)
>>>     In expression "1 << st->m.rpz->num + 1", left shifting by more than 31 bits has undefined behavior.  The shift amount, "st->m.rpz->num + 1", is as much as 63.
2610                            zbits &= DNS_RPZ_ZMASK(st->m.rpz->num);
2611                    } else{
2612                            zbits &= DNS_RPZ_ZMASK(st->m.rpz->num) >> 1;
2613                    }
2614            }
2615
/lib/ns/query.c: 2612 in rpz_get_zbits()
2606             *	the lexically smallest address.
2607             */
2608            if (st->m.policy != DNS_RPZ_POLICY_MISS) {
2609                    if (st->m.type >= rpz_type) {
2610                            zbits &= DNS_RPZ_ZMASK(st->m.rpz->num);
2611                    } else{
>>>     CID 1430160:    (BAD_SHIFT)
>>>     In expression "1 << st->m.rpz->num + 1", left shifting by more than 31 bits has undefined behavior.  The shift amount, "st->m.rpz->num + 1", is as much as 63.
2612                            zbits &= DNS_RPZ_ZMASK(st->m.rpz->num) >> 1;
2613                    }
2614            }
2615
2616            /*
2617             * If the client wants recursion, allow only compatible policies.
Edited Mar 19, 2018 by Ghost User
Assignee
Assign to
BIND-9.13.0
Milestone
BIND-9.13.0 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: isc-projects/bind9#168