Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
BIND
BIND
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 586
    • Issues 586
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 112
    • Merge Requests 112
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #1731

Closed
Open
Opened Apr 02, 2020 by Michał Kępień@michalMaintainer0 of 5 tasks completed0/5 tasks

Sort Automake files nicely

The following discussion from !985 (merged) should be addressed:

  • @michal started a discussion: (+1 comment)

    I think all such lists should be sorted alphabetically. I mean, why sort *_SOURCES but no AM_CPPFLAGS?

    I can spare you the trouble and do all the sorting myself, and I would leave that for the last moment before merging.

  • @michal started a discussion: (+1 comment)

    Apart from block contents, I would also sort the blocks themselves alphabetically, perhaps with LIBLTDL_* being the sole exception. It just seems to make navigating the file a bit easier and - maybe just for me - it indicates that dependency resolution is done elsewhere.

    I think I will stop flagging the sorting issue now and just check everything again later.

  • @michal started a discussion: (+1 comment)

    Maybe a matter of taste, but I would first define "standard" library components and then add all the if blocks below that. (Right now, we specify SOURCES, then optional SOURCES, then CFLAGS, then optional CFLAGS; I would change that to SOURCES → CFLAGS → optional SOURCES → optional CFLAGS.)

  • @michal started a discussion: (+1 comment)

    Is there any reason for not sorting the entries in each of the AC_CONFIG_FILES blocks above alphabetically? A quick test shows that the order does not matter.

  • Ensure Automake if/endif style is consistent tree-wide

Edited Apr 03, 2020 by Michał Kępień
Assignee
Assign to
BIND 9.17 Backburner
Milestone
BIND 9.17 Backburner
Assign milestone
Time tracking
None
Due date
None
Reference: isc-projects/bind9#1731