Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 633
    • Issues 633
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 90
    • Merge requests 90
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Issues
  • #2012
Closed
Open
Issue created Jul 07, 2020 by Mark Andrews@markaDeveloper

Add assertion check to silence dereference before NULL check in tsig_test.c

363        /*
364         * Start digesting.
365         */
   	deref_ptr_in_call: Dereferencing pointer tsigout. [show details]
366        result = add_mac(outctx, tsigout);
367        assert_int_equal(result, ISC_R_SUCCESS);
...
474        if (tsigin != NULL) {
475                isc_buffer_free(&tsigin);
476        }
   	
CID 281475 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking tsigout suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
477        if (tsigout != NULL) {
478                isc_buffer_free(&tsigout);
479        }
Assignee
Assign to
Time tracking