Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
BIND
BIND
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 583
    • Issues 583
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 110
    • Merge Requests 110
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #2243

Closed
Open
Opened Nov 02, 2020 by Michal Nowak@mnowakMaintainer

CID 312970: Incorrect expression (COPY_PASTE_ERROR) in tcp.c

Coverity identified possible issue on main in 8fcad58e:

*** CID 312970:  Incorrect expression  (COPY_PASTE_ERROR)
/lib/isc/netmgr/tcp.c: 282 in tcp_connect_cb()
276     	}
277     
278     	isc__nm_incstats(sock->mgr, sock->statsindex[STATID_CONNECT]);
279     	r = uv_tcp_getpeername(&sock->uv_handle.tcp, (struct sockaddr *)&ss,
280     			       &(int){ sizeof(ss) });
281     	if (r != 0) {
>>>     CID 312970:  Incorrect expression  (COPY_PASTE_ERROR)
>>>     "status" in "isc___nm_uverr2result(status, true, "netmgr/tcp.c", 282U)" looks like a copy-paste error.
282     		failed_connect_cb(sock, req, isc__nm_uverr2result(status));
283     		return;
284     	}
285     
286     	atomic_store(&sock->connecting, false);
287     

It's possible that Coverity is dead wrong about this, if so let me know and I add it to ignore list in Coverity Scan dashboard.

Assignee
Assign to
November 2020 (9.11.25, 9.11.25-S1, 9.16.9, 9.16.9-S1, 9.17.7)
Milestone
November 2020 (9.11.25, 9.11.25-S1, 9.16.9, 9.16.9-S1, 9.17.7) (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: isc-projects/bind9#2243