CID 312970: Incorrect expression (COPY_PASTE_ERROR) in tcp.c
Coverity identified possible issue on main in 8fcad58e:
*** CID 312970: Incorrect expression (COPY_PASTE_ERROR)
/lib/isc/netmgr/tcp.c: 282 in tcp_connect_cb()
276 }
277
278 isc__nm_incstats(sock->mgr, sock->statsindex[STATID_CONNECT]);
279 r = uv_tcp_getpeername(&sock->uv_handle.tcp, (struct sockaddr *)&ss,
280 &(int){ sizeof(ss) });
281 if (r != 0) {
>>> CID 312970: Incorrect expression (COPY_PASTE_ERROR)
>>> "status" in "isc___nm_uverr2result(status, true, "netmgr/tcp.c", 282U)" looks like a copy-paste error.
282 failed_connect_cb(sock, req, isc__nm_uverr2result(status));
283 return;
284 }
285
286 atomic_store(&sock->connecting, false);
287 It's possible that Coverity is dead wrong about this, if so let me know and I add it to ignore list in Coverity Scan dashboard.