Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 576
    • Issues 576
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 113
    • Merge requests 113
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Issues
  • #2304
Closed
Open
Issue created Nov 25, 2020 by Michal Nowak@mnowakOwner

Insecure data handling and null pointer dereferences in test-async.c

@each Coverity identified following problems in the new bin/tests/system/hooks/driver/test-async.c:

*** CID 313488:  Insecure data handling  (TAINTED_SCALAR)
/bin/tests/system/hooks/driver/test-async.c: 345 in async_query_done_begin()
339     	}
340     
341     	/* initial call */
342     	state->async = true;
343     	state->hookpoint = NS_QUERY_DONE_BEGIN;
344     	state->origresult = *resp;
>>>     CID 313488:  Insecure data handling  (TAINTED_SCALAR)
>>>     Passing tainted variable "qctx->client" to a tainted sink.
345     	ns_query_hookasync(qctx, doasync, state);
346     	return (NS_HOOK_RETURN);
347     }
348     
349     static ns_hookresult_t
350     async_qctx_destroy(void *arg, void *cbdata, isc_result_t *resp) {
*** CID 281450:  Null pointer dereferences  (REVERSE_INULL)
/bin/tests/system/hooks/driver/test-async.c: 163 in plugin_register()
157     
158     	*instp = inst;
159     
160     	return (ISC_R_SUCCESS);
161     
162     cleanup:
>>>     CID 281450:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "inst" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
163     	if (result != ISC_R_SUCCESS && inst != NULL) {
164     		plugin_destroy((void **)&inst);
165     	}
166     
167     	return (result);
168     }

More information at https://scan8.coverity.com/reports.htm#v38342/p12579/fileInstanceId=37570751&defectInstanceId=11302475&mergedDefectId=313488.

Assignee
Assign to
Time tracking