Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 532
    • Issues 532
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 101
    • Merge requests 101
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #2350

Closed
Open
Created Dec 15, 2020 by Michal Nowak@mnowakOwner

Dead code guarded by PK11_RSA_PKCS_REPLACE in pkcs11rsa_link.c

PK11_RSA_PKCS_REPLACE is not defined in configure or described in documentation and is therefore invisible for the user on main and v9_16.

In v9_11 one might set it via ./configure --enable-native-pkcs11 --with-pkcs11=/opt/Keyper/PKCS11Provider/pkcs11.so (see configure.ac, line 2324), which sets -DPK11_FLAVOR=PK11_AEP_FLAVOR, which in lib/isc/include/pk11/site.h via #if PK11_FLAVOR == PK11_AEP_FLAVOR defines PK11_RSA_PKCS_REPLACE.

#else /* ifndef PK11_RSA_PKCS_REPLACE */ blocks in lib/dns/pkcs11rsa_link.c are either dead code forgotten when OpenSSL was made mandatory with c3b8130f in v9_13_3 and thus should be dropped, made available by configure, or the least documented in e.g. OPTIONS.md.

Assignee
Assign to
Time tracking