CID 314969: Control flow issues (DEADCODE) in zoneconf.c
Coverity Scan identified the following issue in bin/named/zoneconf.c
on Sunday December 27 on v9_16
and main
:
*** CID 314969: Control flow issues (DEADCODE)
/bin/named/zoneconf.c: 2212 in named_zone_inlinesigning()
2206 if (!inline_signing && !zone_is_dynamic &&
2207 cfg_map_get(zoptions, "dnssec-policy", &signing) == ISC_R_SUCCESS &&
2208 signing != NULL)
2209 {
2210 if (strcmp(cfg_obj_asstring(signing), "none") != 0) {
2211 inline_signing = true;
>>> CID 314969: Control flow issues (DEADCODE)
>>> Execution cannot reach the expression ""no"" inside this statement: "dns_zone_log(zone, 1, "inli...".
2212 dns_zone_log(
2213 zone, ISC_LOG_DEBUG(1), "inline-signing: %s",
2214 inline_signing
2215 ? "implicitly through dnssec-policy"
2216 : "no");
2217 } else {
The culprit likely lies in cf420b2a as it's the only change in that file between last two Coverity Scan runs.
Coverity Scan link: https://scan8.coverity.com/reports.htm#v38342/p12579/fileInstanceId=38520332&defectInstanceId=11383777&mergedDefectId=314969.
Edited by Michal Nowak