Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 611
    • Issues 611
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Issues
  • #2419
Closed
Open
Issue created Jan 25, 2021 by Michal Nowak@mnowakMaintainer

CID 316511: Insecure data handling (TAINTED_SCALAR)

*** CID 316511:  Insecure data handling  (TAINTED_SCALAR)
/lib/dns/rdata/generic/hip_55.c: 496 in casecompare_hip()
490     	key_len = uint16_fromregion(&r1);
491     	isc_region_consume(&r1, 2); /* key length */
492     	isc_region_consume(&r2, 4);
493     
494     	INSIST(r1.length >= (unsigned)(hit_len + key_len));
495     	INSIST(r2.length >= (unsigned)(hit_len + key_len));
>>>     CID 316511:  Insecure data handling  (TAINTED_SCALAR)
>>>     Passing tainted expression "hit_len + key_len" to "memcmp", which uses it as an offset.
496     	order = memcmp(r1.base, r2.base, hit_len + key_len);
497     	if (order != 0) {
498     		return (order);
499     	}
500     	isc_region_consume(&r1, hit_len + key_len);
501     	isc_region_consume(&r2, hit_len + key_len);
Assignee
Assign to
Time tracking