Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
BIND
BIND
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 635
    • Issues 635
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 108
    • Merge Requests 108
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #254

Closed
Open
Opened May 11, 2018 by Michael McNally@McNallyDeveloper

"invalid RPZ prefix length" log message improperly displays the prefix labels, not length

Summary

Jinmei reports a likely regression in 9.11.3-S1:

9.11.3-S1 now shows logs like this:

11-May-2018 14:42:12.059 invalid rpz IP address "33.1.2.0.192.rpz-ip.rpz"; invalid IPv4 prefix length of 33.1.2.0.192

Previously (e.g., 9.10.3-P4) it was:

11-May-2018 14:45:00.471 invalid rpz IP address "33.1.2.0.192.rpz-ip.rpz"; invalid IPv4 prefix length of 33

Besides the fact that the new format breaks backward compatibility, I find the new format more confusing than improvement. So I suspect it's more likely to be a regression than an intentional change.

Code-wise the reason for the change is the removal of the first line from the following in lib/dns/rpz.c:name2ipkey():

*cp2 = '\0';
if (prefix_num < 1U || prefix_num > 128U) {
   badname(log_level, src_name, "; invalid prefix length of ", prefix_str);
   return (ISC_R_FAILURE);
}
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: isc-projects/bind9#254