CID 340477: Control flow issues (DEADCODE)
It seems that 18cc459e made some of the code a dead code:
*** CID 340477: Control flow issues (DEADCODE)
/lib/dns/adb.c: 982 in import_rdataset()
976 }
977 nh = NULL;
978 result = dns_rdataset_next(rdataset);
979 }
980
981 if (nh != NULL) {
>>> CID 340477: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "free_adbnamehook(adb, &nh);".
982 free_adbnamehook(adb, &nh);
983 }
984
985 if (addr_bucket != DNS_ADB_INVALIDBUCKET) {
986 UNLOCK(&adb->entrylocks[addr_bucket]);
987 }Here's Coverity Scan tracker for reference: