Fix rpz system test

Error handling in rpz system test is broken - problems detected do not influence the result:

S:rpz:Tue Jun  5 10:46:01 CEST 2018
T:rpz:1:A
A:rpz:System test rpz
I:rpz:PORTRANGE:5300 - 5399
I:rpz:checking QNAME rewrites (1)
I:rpz:'dig .' wrong; diff dig.out-test1-1 dig.out-test1-1_OK
I:rpz:'dig a3-1.tld2' wrong; diff dig.out-test1-3 proto.nodata
I:rpz:'dig a3-2.tld2' wrong; diff dig.out-test1-4 proto.nodata
I:rpz:'dig sub.a3-2.tld2' wrong; diff dig.out-test1-5 dig.out-test1-5_OK
I:rpz:'dig a4-3-cname.tld2' wrong; diff dig.out-test1-8 proto.nodata
I:rpz:'dig a4-1.sub1.tld2' wrong; no address 12.12.12.12 record in dig.out-test1-9
I:rpz:'dig a4-1.sub2.tld2' wrong; no address 12.12.12.12 record in dig.out-test1-10
I:rpz:'dig nxc1.sub1.tld2' wrong; no address 12.12.12.12 record in dig.out-test1-11
I:rpz:'dig nxc2.sub1.tld2' wrong; no address 12.12.12.12 record in dig.out-test1-12
I:rpz:'dig a4-4.tld2' wrong; no address 127.4.4.1 record in dig.out-test1-13
I:rpz:'dig a6-1.tld2' wrong; diff dig.out-test1-14 dig.out-test1-14_OK
I:rpz:'dig a6-2.tld2' wrong; no address 127.6.2.1 record in dig.out-test1-15
I:rpz:'dig a3-6.tld2' wrong; no address 56.56.56.56 record in dig.out-test1-16
I:rpz:'dig a3-7.sub1.tld2' wrong; no address 57.57.57.57 record in dig.out-test1-17
I:rpz:'dig a4-5-cname3.tld2' wrong; no address 127.0.0.16 record in dig.out-test1-18
I:rpz:'dig a4-6-cname3.tld2' wrong; no address 127.0.0.17 record in dig.out-test1-19
I:rpz:'dig c1.crash2.tld3' wrong; diff dig.out-test1-24 proto.nxdomain
I:rpz:'dig a0-1.tld2s +dnssec' wrong; diff dig.out-test1-27 dig.out-test1-27_OK
I:rpz:'dig a0-1-scname.tld2 +dnssec' wrong; diff dig.out-test1-29 dig.out-test1-29_OK
I:rpz:'dig a0-1.tld2s srv +auth +dnssec' wrong; diff dig.out-test1-30 dig.out-test1-30_OK
I:rpz:'dig a3-8.tld2' wrong; response in dig.out-test1-32
I:rpz:'dig tcp a3-9.tld2' wrong; diff dig.out-test1-33 dig.out-test1-33_OK
I:rpz:wrong test1 ns3 statistics of 1 instead of 22
I:rpz:checking NXDOMAIN/NODATA action on QNAME trigger (2)
I:rpz:'dig a3-1.tld2 @10.53.0.6' wrong; diff dig.out-test1-2 proto.nodata
I:rpz:'dig a3-2.tld2 @10.53.0.6' wrong; diff dig.out-test1-3+ proto.nodata
I:rpz:'dig a4-3-cname.tld2 @10.53.0.6' wrong; diff dig.out-test1-6 proto.nodata
I:rpz:'dig a4-1.sub1.tld2 @10.53.0.6' wrong; no address 12.12.12.12 record in dig.out-test1-7
I:rpz:'dig a4-1.sub2.tld2 @10.53.0.6' wrong; no address 12.12.12.12 record in dig.out-test1-8+
I:rpz:'dig a4-4.tld2 @10.53.0.6' wrong; no address 127.4.4.1 record in dig.out-test1-9+
I:rpz:'dig nxc1.sub1.tld2 @10.53.0.6' wrong; no address 12.12.12.12 record in dig.out-test1-10+
I:rpz:'dig nxc2.sub1.tld2 @10.53.0.6' wrong; no address 12.12.12.12 record in dig.out-test1-11+
I:rpz:'dig a6-2.tld2 @10.53.0.6' wrong; no address 127.6.2.1 record in dig.out-test1-12+
I:rpz:'dig a3-6.tld2 @10.53.0.6' wrong; no address 56.56.56.56 record in dig.out-test1-13+
I:rpz:'dig a3-7.sub1.tld2 @10.53.0.6' wrong; no address 57.57.57.57 record in dig.out-test1-14+
I:rpz:'dig a4-5-cname3.tld2 @10.53.0.6' wrong; no address 127.0.0.16 record in dig.out-test1-15+
I:rpz:'dig a4-6-cname3.tld2 @10.53.0.6' wrong; no address 127.0.0.17 record in dig.out-test1-16+
I:rpz:'dig a0-1s-cname.tld2s +dnssec @10.53.0.6' wrong; diff dig.out-test1-19+ proto.nxdomain
I:rpz:wrong test1 ns3 statistics of 19 instead of 22..30
I:rpz:checking IP rewrites (3)
I:rpz:'dig a3-1.tld2' wrong; diff dig.out-test2-1 proto.nodata
I:rpz:'dig a3-2.tld2' wrong; diff dig.out-test2-2 dig.out-test2-2_OK
I:rpz:'dig a4-1.tld2' wrong; diff dig.out-test2-3 dig.out-test2-3_OK
I:rpz:'dig a4-2.tld2 -taaaa' wrong; diff dig.out-test2-5 dig.out-test2-5_OK
I:rpz:'dig a4-2.tld2 -ttxt' wrong; diff dig.out-test2-6 dig.out-test2-6_OK
I:rpz:'dig a4-3.tld2' wrong; diff dig.out-test2-8 proto.nodata
I:rpz:'dig a4-1-aaaa.tld2 -taaaa' wrong; diff dig.out-test2-10 dig.out-test2-10_OK
I:rpz:'dig a5-1-2.tld2' wrong; no address 127.0.0.1 record in dig.out-test2-11
I:rpz:'dig a5-3.tld2' wrong; no address 127.0.0.1 record in dig.out-test2-12
I:rpz:'dig a5-4.tld2' wrong; no address 14.14.14.14 record in dig.out-test2-14
I:rpz:'dig a4-4.tld2' wrong; diff dig.out-test2-15 dig.out-test2-15_OK
I:rpz:'dig c2.crash2.tld3' wrong; diff dig.out-test2-16 proto.nxdomain
I:rpz:'dig a4-4.tld2 -b 10.53.0.1' wrong; no address 127.0.0.17 record in dig.out-test2-17
I:rpz:ns2 zone reload queued
I:rpz:'dig a7-1.tld2' wrong; diff dig.out-test2-19 dig.out-test2-19_OK
I:rpz:ns2 zone reload queued
I:rpz:wrong test2 ns3 statistics of 1 instead of 12
I:rpz:checking radix tree deletions (4)
I:rpz:'dig a3-1.tld2' wrong; diff dig.out-1 dig.out-1_OK
I:rpz:'dig a3-2.tld2' wrong; diff dig.out-2 dig.out-2_OK
I:rpz:'dig a4-1.tld2' wrong; diff dig.out-3 dig.out-3_OK
I:rpz:'dig a4-2.tld2' wrong; diff dig.out-4 dig.out-4_OK
I:rpz:'dig a4-2.tld2 -taaaa' wrong; diff dig.out-5 dig.out-5_OK
I:rpz:'dig a4-2.tld2 -ttxt' wrong; diff dig.out-6 dig.out-6_OK
I:rpz:'dig a4-2.tld2 -tany' wrong; diff dig.out-7 dig.out-7_OK
I:rpz:'dig a4-3.tld2' wrong; diff dig.out-8 dig.out-8_OK
I:rpz:'dig a3-1.tld2 -tAAAA' wrong; diff dig.out-9 dig.out-9_OK
I:rpz:'dig a4-1-aaaa.tld2 -tAAAA' wrong; diff dig.out-10 dig.out-10_OK
I:rpz:'dig a5-1-2.tld2' wrong; diff dig.out-11 dig.out-11_OK
I:rpz:checking NSDNAME rewrites (5)
I:rpz:'dig a3-1.tld2' wrong; diff dig.out-test3-1 dig.out-test3-1_OK
I:rpz:'dig a3-1.tld2 +dnssec' wrong; diff dig.out-test3-2 dig.out-test3-2_OK
I:rpz:'dig a4-2.subsub.sub2.tld2' wrong; no address 12.12.12.12 record in dig.out-test3-6
I:rpz:'dig a3-2.tld2.' wrong; diff dig.out-test3-7 dig.out-test3-7_OK
I:rpz:'dig a0-1.tld2.' wrong; diff dig.out-test3-8 dig.out-test3-8_OK
I:rpz:'dig a4-1.tld2' wrong; no address 12.12.12.12 record in dig.out-test3-9
I:rpz:'dig a3-1.sub3.tld2' wrong; no address 127.0.0.1 record in dig.out-test3-10
I:rpz:'dig a3-1.subsub.sub3.tld2' wrong; no address 127.0.0.2 record in dig.out-test3-11
I:rpz:'dig xxx.crash1.tld2' wrong; diff dig.out-test3-12 proto.nxdomain
I:rpz:wrong test3 ns3 statistics of 0 instead of 7
I:rpz:checking NSIP rewrites (6)
I:rpz:'dig a3-2.tld2.' wrong; diff dig.out-test4-2 dig.out-test4-2_OK
I:rpz:'dig a0-1.tld2.' wrong; diff dig.out-test4-3 dig.out-test4-3_OK
I:rpz:'dig a3-1.tld4' wrong; diff dig.out-test4-4 dig.out-test4-4_OK
I:rpz:checking walled garden NSIP rewrites (7)
I:rpz:'dig a3-1.tld2' wrong; no address 41.41.41.41 record in dig.out-test4a-1
I:rpz:'dig a3-1.tld2 AAAA' wrong; no address 2041::41 record in dig.out-test4a-2
I:rpz:'dig a3-1.tld2 TXT' wrong; diff dig.out-test4a-3 dig.out-test4a-3_OK
I:rpz:wrong test4 ns3 statistics of 0 instead of 4
I:rpz:checking policy overrides (8)
I:rpz:'dig a3-1.tld2' wrong; no address 127.0.0.1 record in dig.out-test5-1
I:rpz:'dig a3-2.tld2' wrong; diff dig.out-test5-2 dig.out-test5-2_OK
I:rpz:'dig a3-3.tld2' wrong; diff dig.out-test5-3 dig.out-test5-3_OK
I:rpz:'dig a3-4.tld2' wrong; diff dig.out-test5-4 dig.out-test5-4_OK
I:rpz:'dig a3-5.tld2' wrong; diff dig.out-test5-5 proto.nodata
I:rpz:'dig a3-5.tld2' wrong; diff dig.out-test5-7 proto.nodata
I:rpz:'dig a3-5.tld2 +norecurse @10.53.0.5' wrong; diff dig.out-test5-8 proto.nxdomain
I:rpz:'dig a3-5.tld2s @10.53.0.5' wrong; diff dig.out-test5-9 proto.nxdomain
I:rpz:'dig a3-5.tld2s +dnssec @10.53.0.5' wrong; diff dig.out-test5-10 proto.nxdomain
I:rpz:'dig a3-7.tld2 -tany' wrong; diff dig.out-test5-12 dig.out-test5-12_OK
I:rpz:'dig a3-8.tld2' wrong; no address 58.58.58.58 record in dig.out-test5-13
I:rpz:'dig a3-9.sub9.tld2' wrong; no address 59.59.59.59 record in dig.out-test5-14
I:rpz:'dig a3-15.tld2' wrong; no address 12.12.12.12 record in dig.out-test5-15
I:rpz:'dig a3-16.tld2' wrong; no address 127.0.0.16 record in dig.out-test5-16
I:rpz:'dig a3-18.tld2' wrong; response in dig.out-test5-18
I:rpz:'dig TCP a3-19.tld2' wrong; no or unexpected truncation in dig.out-test5-19
I:rpz:wrong test5 ns3 statistics of 1 instead of 12
I:rpz:checking crashes (9)
I:rpz:wrong bugs ns3 statistics of 2 instead of 8
I:rpz:performance not checked; queryperf not available
I:rpz:error messages in ns6/named.run starting with:
I:rpz:ns6/named.run:05-Jun-2018 10:46:05.111 client @0x7fa3e40c9870 10.53.0.6#34935 (a0-1.tld2): rpz QNAME rewrite a0-1.tld2 stop on unrecognized qresult in rpz_rewrite()failed:  : SERVFAIL
I:rpz:ns6/named.run:05-Jun-2018 10:46:05.359 client @0x7fa3e404c060 10.53.0.6#51032 (c1.crash2.tld3): rpz QNAME rewrite c1.crash2.tld3 stop on unrecognized qresult in rpz_rewrite()failed:  : SERVFAIL
I:rpz:checking that ttl values are not zeroed when qtype is '*' (10)
I:rpz:failed
I:rpz:checking rpz updates/transfers with parent nodes added after children.................... (11)
I:rpz:checking that going from an empty policy zone works (12)
I:rpz:ns7 zone refresh queued
I:rpz:invalid test mode
I:rpz:DNSRPS sub-test skipped
R:rpz:PASS
E:rpz:Tue Jun  5 10:46:56 CEST 2018

The problems quoted above were introduced by bef18eca and overlooked in a7a2fa29 due to the flaw in error handling.