CID 350712: Error handling issues (CHECKED_RETURN)
Coverity Scan on main
identified the following issue:
*** CID 350712: Error handling issues (CHECKED_RETURN)
/lib/dns/resolver.c: 1262 in fctx_starttimer()
1256 fctx_starttimer(fetchctx_t *fctx) {
1257 isc_interval_t interval;
1258 isc_time_t now;
1259 isc_time_t expires;
1260
1261 isc_interval_set(&interval, 2, 0);
>>> CID 350712: Error handling issues (CHECKED_RETURN)
>>> Calling "isc_time_add" without checking return value (as is done elsewhere 20 out of 21 times).
1262 isc_time_add(&fctx->expires, &interval, &expires);
1263
1264 isc_time_now(&now);
1265 if (isc_time_compare(&expires, &now) <= 0) {
1266 isc_interval_set(&interval, 0, 1);
1267 } else {
The change originated in 27850a5a of !5966 (merged) which dropped return value checking of isc_time_add()
.