Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 530
    • Issues 530
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 100
    • Merge requests 100
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #3215

Closed
Open
Created Mar 16, 2022 by Michal Nowak@mnowakOwner

CID 350712: Error handling issues (CHECKED_RETURN)

Coverity Scan on main identified the following issue:

*** CID 350712:  Error handling issues  (CHECKED_RETURN)
/lib/dns/resolver.c: 1262 in fctx_starttimer()
1256     fctx_starttimer(fetchctx_t *fctx) {
1257     	isc_interval_t interval;
1258     	isc_time_t now;
1259     	isc_time_t expires;
1260     
1261     	isc_interval_set(&interval, 2, 0);
>>>     CID 350712:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "isc_time_add" without checking return value (as is done elsewhere 20 out of 21 times).
1262     	isc_time_add(&fctx->expires, &interval, &expires);
1263     
1264     	isc_time_now(&now);
1265     	if (isc_time_compare(&expires, &now) <= 0) {
1266     		isc_interval_set(&interval, 0, 1);
1267     	} else {

The change originated in 27850a5a of !5966 (merged) which dropped return value checking of isc_time_add().

Assignee
Assign to
Time tracking